From xdivac02@stud.fit.vutbr.cz  Wed May  4 19:01:39 2005
Return-Path: <xdivac02@stud.fit.vutbr.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3710116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 May 2005 19:01:39 +0000 (GMT)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C384D43D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 May 2005 19:01:37 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz) (8.13.4/8.13.3) with ESMTP id j44J16ag088710
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 4 May 2005 21:01:07 +0200 (CEST)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.4/8.13.3/Submit) id j44J16dr088709;
	Wed, 4 May 2005 21:01:06 +0200 (CEST)
Message-Id: <200505041901.j44J16dr088709@eva.fit.vutbr.cz>
Date: Wed, 4 May 2005 21:01:06 +0200 (CEST)
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
Reply-To: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: pf_test6: kif == NULL ...
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         80627
>Category:       kern
>Synopsis:       pf_test6: kif == NULL ...
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-pf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 04 19:10:01 GMT 2005
>Closed-Date:    Tue Aug 23 14:26:19 GMT 2005
>Last-Modified:  Tue Aug 23 14:26:19 GMT 2005
>Originator:     Divacky Roman
>Release:        FreeBSD 6-CURRENT i386
>Organization:
home
>Environment:
FreeBSD witten 6.0-CURRENT FreeBSD 6.0-CURRENT #310: Wed May  4 16:00:30 CEST
2005     root@witten:/usr/obj/usr/src/sys/NEOLOGISM  i386


	
>Description:

pf_test6: kif == NULL, if_xname vr0

this message appears on shutdown with 3.7 pf

>How-To-Repeat:

shutdown?

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mlaier 
Responsible-Changed-By: mlaier 
Responsible-Changed-When: Sun May 8 20:20:20 GMT 2005 
Responsible-Changed-Why:  
Take over, almost forgot it again.  The problem is that IPv6 sends out 
packets after the interface remove hooks are called.  This needs to be 
revised/-ordered. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80627 

From: Max Laier <max@love2party.net>
To: bug-followup@FreeBSD.org,
 xdivac02@stud.fit.vutbr.cz
Cc:  
Subject: Re: kern/80627: pf_test6: kif == NULL ...
Date: Thu, 7 Jul 2005 21:20:46 +0200

 Please test the following patch:
 
 Also available from:
   http://people.freebsd.org/~mlaier/if.c.patch
 
 Index: if.c
 ===================================================================
 RCS file: /usr/store/mlaier/fcvs/src/sys/net/if.c,v
 retrieving revision 1.234
 diff -u -r1.234 if.c
 --- if.c	1 Jul 2005 16:28:31 -0000	1.234
 +++ if.c	7 Jul 2005 19:16:30 -0000
 @@ -652,7 +652,6 @@
  	 */
  	taskqueue_drain(taskqueue_swi, &ifp->if_linktask);
  
 -	EVENTHANDLER_INVOKE(ifnet_departure_event, ifp);
  #ifdef DEV_CARP
  	/* Maybe hook to the generalized departure handler above?!? */
  	if (ifp->if_carp)
 @@ -713,6 +712,7 @@
  
  	/* Announce that the interface is gone. */
  	rt_ifannouncemsg(ifp, IFAN_DEPARTURE);
 +	EVENTHANDLER_INVOKE(ifnet_departure_event, ifp);
  
  	IF_AFDATA_LOCK(ifp);
  	for (dp = domains; dp; dp = dp->dom_next) {
 @@ -1332,9 +1332,9 @@
  		if (ifunit(new_name) != NULL)
  			return (EEXIST);
  		
 -		EVENTHANDLER_INVOKE(ifnet_departure_event, ifp);
  		/* Announce the departure of the interface. */
  		rt_ifannouncemsg(ifp, IFAN_DEPARTURE);
 +		EVENTHANDLER_INVOKE(ifnet_departure_event, ifp);
  
  		log(LOG_INFO, "%s: changing name to '%s'\n",
  		    ifp->if_xname, new_name);
 
 -- 
   Max
State-Changed-From-To: open->feedback 
State-Changed-By: mlaier 
State-Changed-When: Thu Jul 7 20:10:19 GMT 2005 
State-Changed-Why:  
Patch available for testing. 


Responsible-Changed-From-To: mlaier->freebsd-pf 
Responsible-Changed-By: mlaier 
Responsible-Changed-When: Thu Jul 7 20:10:19 GMT 2005 
Responsible-Changed-Why:  
Over to freebsd-pf for evaluation. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80627 
State-Changed-From-To: feedback->patched 
State-Changed-By: mlaier 
State-Changed-When: Thu Jul 14 20:34:52 GMT 2005 
State-Changed-Why:  
Patch committed to HEAD.  MFC to RELENG_6 and _5 in a week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80627 
State-Changed-From-To: patched->closed 
State-Changed-By: mlaier 
State-Changed-When: Tue Aug 23 14:25:43 GMT 2005 
State-Changed-Why:  
MFCed to RELENG_5 and _6  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80627 
>Unformatted:
