From hselasky@c2i.net  Wed Apr 20 13:48:28 2005
Return-Path: <hselasky@c2i.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1652416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 13:48:28 +0000 (GMT)
Received: from swip.net (mailfe10.swip.net [212.247.155.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5A20843D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 13:48:27 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
Received: from mp-217-231-167.daxnet.no ([193.217.231.167] verified)
  by mailfe10.swip.net (CommuniGate Pro SMTP 4.2.9)
  with ESMTP id 139342463 for FreeBSD-gnats-submit@freebsd.org; Wed, 20 Apr 2005 15:48:25 +0200
Message-Id: <200504201649.31894.hselasky@c2i.net>
Date: Wed, 20 Apr 2005 16:49:31 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
Reply-To: hselasky@c2i.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: SIMPLEX flag is not set properly in sound drivers

>Number:         80152
>Category:       kern
>Synopsis:       [sound] [patch] SIMPLEX flag is not set properly in sound drivers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 20 13:50:30 GMT 2005
>Closed-Date:    Fri Jan 06 15:13:08 GMT 2006
>Last-Modified:  Fri Jan 06 15:13:08 GMT 2006
>Originator:     HPS
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 6.0-CURRENT FreeBSD 6.0-CURRENT #45: Mon Mar 21 15:40:17 CET 
2005 root@:/usr/obj/usr/src/sys/custom i386

>Description:

SIMPLEX flag is not set properly in sound drivers

Several device drivers call "pcm_setflags" before "pcm_register". The problem 
is that "pcm_register" clears these flags. Maybe the device drivers should be 
changed, or maybe "pcm_register" should be changed.

>How-To-Repeat:

>Fix:

Here is my solution: In the file "/sys/dev/sound/pcm/sound.c" in the function 
"pcm_register()" "d->flags = 0;" should be changed into:

        /* d->flags = 0; should be cleared by allocator of softc;
         * cannot clear this field here, because several devices set
         * this flag before calling pcm_register()
         */

For example see /sys/dev/sound/isa/sb8.c:
pcm_setflags(dev, pcm_getflags(dev) | SD_F_SIMPLEX);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->sound 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Wed Apr 20 14:10:03 GMT 2005 
Responsible-Changed-Why:  
Reassign misfiled PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80152 
State-Changed-From-To: open->closed 
State-Changed-By: netchild 
State-Changed-When: Fri Jan 6 15:12:59 UTC 2006 
State-Changed-Why:  
This is in 6-stable and -current now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80152 
>Unformatted:
