From harry@schmalzbauer.de  Wed Apr 20 10:48:18 2005
Return-Path: <harry@schmalzbauer.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5D88B16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 10:48:18 +0000 (GMT)
Received: from flb.schmalzbauer.de (flb.schmalzbauer.de [62.245.232.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3377A43D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 10:48:17 +0000 (GMT)
	(envelope-from harry@schmalzbauer.de)
Received: from korso.flintsbach.schmalzbauer.de (korso.flintsbach.schmalzbauer.de [172.21.2.3])
	by flb.schmalzbauer.de (8.13.1/8.13.1) with ESMTP id j3KAmFMF052186
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 12:48:15 +0200 (CEST)
	(envelope-from harry@cale.flintsbach.schmalzbauer.de)
Received: from cale.flintsbach.schmalzbauer.de (cale.flintsbach.schmalzbauer.de [172.21.1.254])
	by korso.flintsbach.schmalzbauer.de (Postfix) with ESMTP id A844913D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 12:48:15 +0200 (CEST)
Received: from cale.flintsbach.schmalzbauer.de (localhost [127.0.0.1])
	by cale.flintsbach.schmalzbauer.de (8.13.3/8.13.3) with ESMTP id j3KAmFTH000786
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Apr 2005 12:48:15 +0200 (CEST)
	(envelope-from harry@cale.flintsbach.schmalzbauer.de)
Received: (from harry@localhost)
	by cale.flintsbach.schmalzbauer.de (8.13.3/8.13.3/Submit) id j3KAmFfR000785;
	Wed, 20 Apr 2005 12:48:15 +0200 (CEST)
	(envelope-from harry)
Message-Id: <200504201048.j3KAmFfR000785@cale.flintsbach.schmalzbauer.de>
Date: Wed, 20 Apr 2005 12:48:15 +0200 (CEST)
From: Harald Schmalzbauer <harry@schmalzbauer.de>
Reply-To: Harald Schmalzbauer <harry@schmalzbauer.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: mdconfig can reboot the system
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         80136
>Category:       kern
>Synopsis:       [md] [reboot] mdconfig can reboot the system
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    trasz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 20 10:50:27 GMT 2005
>Closed-Date:    Sat Mar 27 14:44:07 UTC 2010
>Last-Modified:  Sat Mar 27 14:50:01 UTC 2010
>Originator:     Harald Schmalzbauer
>Release:        FreeBSD 5.4-RC3 i386
>Organization:
>Environment:
System: FreeBSD cale.flintsbach.schmalzbauer.de 5.4-RC3 FreeBSD 5.4-RC3 #0: Sun Apr 17 21:44:15 UTC 2005 harry@cale:/usr/obj/usr/src/sys/CALE i386


	
>Description:
	mdconfig causes a hard reboot when trying to create a preload md
>How-To-Repeat:
	mdconfig -a -t preload -s 12m -u md0
>Fix:

	


>Release-Note:
>Audit-Trail:

From: Kris Kennaway <kris@obsecurity.org>
To: bug-followup@freeBSD.org
Cc:  
Subject: Re: kern/80136: mdconfig can reboot the system
Date: Sat, 23 Apr 2005 15:09:59 -0700

 Adding to audit trail
 
 ----- Forwarded message from Doug White <dwhite@gumbysoft.com> -----
 
 Date: Sat, 23 Apr 2005 15:03:48 -0700 (PDT)
 From: Doug White <dwhite@gumbysoft.com>
 Subject: Re: [harry@schmalzbauer.de: kern/80136: mdconfig can reboot the system]
 In-reply-to: <20050423201514.GA34729@xor.obsecurity.org>
 To: Kris Kennaway <kris@obsecurity.org>
 Cc: qa@freeBSD.org
 
 On Sat, 23 Apr 2005, Kris Kennaway wrote:
 
 > Can anyone confirm?
 
 The "preload" type is undocumented for mdconfig(8).  I figured this type
 was only used if you had a preloaded module already but weren't using
 MD_ROOT... I guess there must be a bug somewhere that triple faults if
 there is no module loaded.
 
State-Changed-From-To: open->feedback 
State-Changed-By: kmacy 
State-Changed-When: Fri Nov 16 09:02:09 UTC 2007 
State-Changed-Why:  

Is this still an issue? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80136 
State-Changed-From-To: feedback->suspended 
State-Changed-By: linimon 
State-Changed-When: Sun Mar 2 02:24:42 UTC 2008 
State-Changed-Why:  
Feedback was not received, but it sounds as though this problem was never 
fixed.  Mark suspended since no one seems to be working on it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80136 
Responsible-Changed-From-To: freebsd-bugs->trasz 
Responsible-Changed-By: trasz 
Responsible-Changed-When: Sun Jan 4 16:12:58 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80136 
State-Changed-From-To: suspended->patched 
State-Changed-By: trasz 
State-Changed-When: Sun Jan 4 16:13:05 UTC 2009 
State-Changed-Why:  
Fixed in //depot/user/trasz/dont_panic Perforce branch. 

http://perforce.freebsd.org/changeView.cgi?CH=155613 


http://www.freebsd.org/cgi/query-pr.cgi?pr=80136 

From: Alexander Best <alexbestms@wwu.de>
To: <bug-followup@FreeBSD.org>
Cc: <trasz@FreeBSD.org>,
 Harald Schmalzbauer <harry@schmalzbauer.de>,
 Kris Kennaway <kris@obsecurity.org>
Subject: Re: kern/80136: [md] [reboot] mdconfig can reboot the system
Date: Fri, 26 Feb 2010 21:17:24 +0100 (CET)

 this still hasn't been fixed in HEAD. please MFP4.
 
 cheers.
 alex

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/80136: commit references a PR
Date: Sat, 27 Feb 2010 10:41:43 +0000 (UTC)

 Author: trasz
 Date: Sat Feb 27 10:41:30 2010
 New Revision: 204408
 URL: http://svn.freebsd.org/changeset/base/204408
 
 Log:
   Fix panic on invalid 'mdconfig -at preload' usage.
   
   PR:		kern/80136
 
 Modified:
   head/sys/dev/md/md.c
 
 Modified: head/sys/dev/md/md.c
 ==============================================================================
 --- head/sys/dev/md/md.c	Sat Feb 27 10:19:39 2010	(r204407)
 +++ head/sys/dev/md/md.c	Sat Feb 27 10:41:30 2010	(r204408)
 @@ -814,6 +814,8 @@ mdcreate_preload(struct md_s *sc, struct
  
  	if (mdio->md_options & ~(MD_AUTOUNIT | MD_FORCE))
  		return (EINVAL);
 +	if (mdio->md_base == 0)
 +		return (EINVAL);
  	sc->flags = mdio->md_options & MD_FORCE;
  	/* Cast to pointer size, then to pointer to avoid warning */
  	sc->pl_ptr = (u_char *)(uintptr_t)mdio->md_base;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: trasz 
State-Changed-When: Sat Mar 27 14:44:06 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80136 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/80136: commit references a PR
Date: Sat, 27 Mar 2010 14:43:53 +0000 (UTC)

 Author: trasz
 Date: Sat Mar 27 14:43:40 2010
 New Revision: 205730
 URL: http://svn.freebsd.org/changeset/base/205730
 
 Log:
   MFC r204408:
   
   Fix panic on invalid 'mdconfig -at preload' usage.
   
   PR:		kern/80136
 
 Modified:
   stable/8/sys/dev/md/md.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/dev/md/md.c
 ==============================================================================
 --- stable/8/sys/dev/md/md.c	Sat Mar 27 13:43:18 2010	(r205729)
 +++ stable/8/sys/dev/md/md.c	Sat Mar 27 14:43:40 2010	(r205730)
 @@ -814,6 +814,8 @@ mdcreate_preload(struct md_s *sc, struct
  
  	if (mdio->md_options & ~(MD_AUTOUNIT | MD_FORCE))
  		return (EINVAL);
 +	if (mdio->md_base == 0)
 +		return (EINVAL);
  	sc->flags = mdio->md_options & MD_FORCE;
  	/* Cast to pointer size, then to pointer to avoid warning */
  	sc->pl_ptr = (u_char *)(uintptr_t)mdio->md_base;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
