From dunstan@freebsd.czest.pl  Wed Apr 13 22:03:50 2005
Return-Path: <dunstan@freebsd.czest.pl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 097F616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Apr 2005 22:03:50 +0000 (GMT)
Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9CB9243D39
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Apr 2005 22:03:48 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j3DMCUKf043433
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Apr 2005 22:12:30 GMT
	(envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j3DMCTRM043432;
	Wed, 13 Apr 2005 22:12:29 GMT
	(envelope-from dunstan)
Message-Id: <200504132212.j3DMCTRM043432@freebsd.czest.pl>
Date: Wed, 13 Apr 2005 22:12:29 GMT
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Reply-To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         79884
>Category:       kern
>Synopsis:       [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 13 22:10:14 GMT 2005
>Closed-Date:    Mon May 16 12:44:59 GMT 2005
>Last-Modified:  Mon May 16 12:44:59 GMT 2005
>Originator:     Wojciech A. Koszek
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #7: Tue Apr 12 00:11:29 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386


>Description:
NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently,
"error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of
it.
>How-To-Repeat:
cvs -d anoncvs@anoncvs.fr.freebsd.org:/home/ncvs co -p
src/sys/netgraph/ng_echo.c | cat -n | grep 106
>Fix:
Patch [diff.0.ng_echo.c] corrects this mistake.

--- diff.0.ng_echo.c begins here ---
Index: src/sys/netgraph/ng_echo.c
===================================================================
RCS file: /home/ncvs/src/sys/netgraph/ng_echo.c,v
retrieving revision 1.12
diff -r1.12 ng_echo.c
106c106
< 	return (0);
---
> 	return (error);
--- diff.0.ng_echo.c ends here ---

>Release-Note:
>Audit-Trail:

From: Ruslan Ermilov <ru@FreeBSD.org>
To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Cc: Julian Elischer <julian@FreeBSD.org>, bug-followup@FreeBSD.org
Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
Date: Fri, 15 Apr 2005 10:31:54 +0300

 On Wed, Apr 13, 2005 at 10:12:29PM +0000, Wojciech A. Koszek wrote:
 [...]
 > NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently,
 > "error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of
 > it.
 > 
 Julian changed the semantics in rev. 1.9 of ng_echo.c, without an obvious
 reason.  Let's hear what was the reason, if there were any.  Julian?
 
 
 Cheers,
 -- 
 Ruslan Ermilov
 ru@FreeBSD.org
 FreeBSD committer

From: Julian Elischer <julian@elischer.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>,
	Julian Elischer <julian@FreeBSD.org>, bug-followup@FreeBSD.org
Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
Date: Fri, 15 Apr 2005 01:27:07 -0700

 Ruslan Ermilov wrote:
 > On Wed, Apr 13, 2005 at 10:12:29PM +0000, Wojciech A. Koszek wrote:
 > [...]
 > 
 >>NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently,
 >>"error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of
 >>it.
 >>
 > 
 > Julian changed the semantics in rev. 1.9 of ng_echo.c, without an obvious
 > reason.  Let's hear what was the reason, if there were any.  Julian?
 
 probably just a "braino" during editing, though I think there is a large
 possibility that it is not possible to get an error.
 certainly it should be ok to use the error value,
 
 > 
 > 
 > Cheers,
 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Fri Apr 15 10:14:15 GMT 2005 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Fri Apr 15 10:14:15 GMT 2005 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79884 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Mon May 16 12:44:46 GMT 2005 
State-Changed-Why:  
Merged. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79884 
>Unformatted:
