From dunstan@freebsd.czest.pl  Mon Apr 11 23:41:44 2005
Return-Path: <dunstan@freebsd.czest.pl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6D91316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 11 Apr 2005 23:41:44 +0000 (GMT)
Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 46FBA43D2D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 11 Apr 2005 23:41:41 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j3BNoIKf030504
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 11 Apr 2005 23:50:18 GMT
	(envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j3BNoIQv030503;
	Mon, 11 Apr 2005 23:50:18 GMT
	(envelope-from dunstan)
Message-Id: <200504112350.j3BNoIQv030503@freebsd.czest.pl>
Date: Mon, 11 Apr 2005 23:50:18 GMT
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Reply-To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] ng_cisco(4) allocates too much memory.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         79806
>Category:       kern
>Synopsis:       [PATCH] ng_cisco(4) allocates too much memory.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 11 23:50:23 GMT 2005
>Closed-Date:    Mon May 16 12:45:41 GMT 2005
>Last-Modified:  Mon May 16 12:45:41 GMT 2005
>Originator:     Wojciech A. Koszek
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #7: Tue Apr 12 00:11:29 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386

>Description:
ng_cisco(8) allocates too much memory for message. Macro NG_MKRESPONSE(rsp,
msg, len, how) allocates memory for "struct ng_mesg" itself. "len" is number
of bytes in rsp->data.
>How-To-Repeat:
cvs -d anoncvs@anoncvs.freebsd.org:/home/ncvs co -p
src/sys/netgraph/ng_cisco.c | head -267 | tail -10
>Fix:
Simple patch [diff.0.ng_cisco.c] which corrects this.

Index: src/sys/netgraph/ng_cisco.c
===================================================================
RCS file: /home/ncvs/src/sys/netgraph/ng_cisco.c,v
retrieving revision 1.27
diff -r1.27 ng_cisco.c
264,265c264
<                       NG_MKRESPONSE(resp, msg, sizeof(struct ng_mesg)
<                           + NG_TEXTRESPONSE, M_NOWAIT);
---
>                       NG_MKRESPONSE(resp, msg, NG_TEXTRESPONSE, M_NOWAIT);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Wed Apr 13 14:03:50 GMT 2005 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Wed Apr 13 14:03:50 GMT 2005 
Responsible-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79806 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Mon May 16 12:45:28 GMT 2005 
State-Changed-Why:  
Merged. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79806 
>Unformatted:
