From j@ida.interface-business.de  Thu Sep 17 00:14:12 1998
Received: from ida.interface-business.de (ida.interface-business.de [193.101.57.203])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA08319
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Sep 1998 00:14:11 -0700 (PDT)
          (envelope-from j@ida.interface-business.de)
Received: (from j@localhost)
          by ida.interface-business.de id JAA11231;
          Thu, 17 Sep 1998 09:13:41 +0200 (MET DST)
Message-Id: <19980917091341.47067@interface-business.de>
Date: Thu, 17 Sep 1998 09:13:41 +0200
From: J Wunsch <j@ida.interface-business.de>
Reply-To: Joerg Wunsch <joerg_wunsch@interface-business.de>
To: Martin Cracauer <cracauer@cons.org>
Cc: FreeBSD-gnats-submit@freebsd.org
In-Reply-To: <19980916235538.A26928@cons.org>; from Martin Cracauer on Wed, Sep 16, 1998 at 11:55:38PM +0200
Subject: Re: Conflicting header files
References: <199605241737.TAA14629@ida.interface-business.de> <19980916235538.A26928@cons.org>

>Number:         7960
>Category:       kern
>Synopsis:       Re: Conflicting header files
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 17 00:20:00 PDT 1998
>Closed-Date:    Fri Sep 18 21:51:07 PDT 1998
>Last-Modified:  Wed Oct 26 05:47:00 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Fri Sep 18 21:51:07 PDT 1998 
State-Changed-Why:  
I don't believe this was intended to be a PR. 
>Unformatted:
As Martin Cracauer wrote:

> > The definitions of `key_t' in <sys/types.h> and <machine/console.h>
> > conflict when used in a C++ environment.
> 
> [pcvt_ioctl.h suffers from the same problem.]

(Only for compatibility reasons, since pcvt didn't want to invent yet
another interface for VT stuff, thus adopted the USL style so it is
source-code compatible in XFree86.)

> May I kindly request that you change it or otherwise keep friendly
> when I change it this weekend? Yes, I do a full make world, as the
> userland console support stuff will probably break.
> 
> Looks fairly trivial [famous last words...].

The IMHO biggest problem is that XFree86 (and Xig, FWIW) might rely on
this.  Let's have a look...

Hmm, it seems they reference the keymap (in the file
xc/programs/Xserver/hw/xfree86/common/xf86KbdBSD.c), and the elements
of the current `key_t', but don't actually rely on this name.
Recompiling the Xserver before comitting would be highly recommended
however...

-- 
J"org Wunsch					       Unix support engineer
joerg_wunsch@interface-business.de       http://www.interface-business.de/~j
