From nobody@FreeBSD.org  Sat Mar 26 23:10:55 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0D7E016A4D3
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2005 23:10:55 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DAF1543D2D
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2005 23:10:54 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2QNAsjW003606
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2005 23:10:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j2QNAsaG003605;
	Sat, 26 Mar 2005 23:10:54 GMT
	(envelope-from nobody)
Message-Id: <200503262310.j2QNAsaG003605@www.freebsd.org>
Date: Sat, 26 Mar 2005 23:10:54 GMT
From: none <freebsd-stable@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: RELENG_4 pci CONF1_ENABLE_MSK mfc depend
X-Send-Pr-Version: www-2.3

>Number:         79266
>Category:       kern
>Synopsis:       [pci] [patch] RELENG_4 pci CONF1_ENABLE_MSK depend MFCed incorrectly?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 26 23:20:01 GMT 2005
>Closed-Date:    Sat Jun 23 16:07:23 GMT 2007
>Last-Modified:  Sat Jun 23 16:07:23 GMT 2007
>Originator:     none
>Release:        RELENG_4_11_0_RELEASE and newer
>Organization:
none
>Environment:
vanilla 4.10-RELEASE #0 w/smp kernel
>Description:
note: present in both RELENG_4_11_0_RELEASE and RELENG_4 and
possibly other tags newer than RELENG_4_10_0_RELEASE.

from compile logs...
diff -r old/RELENG_4_10_0_RELEASE_GENERIC.md.err new/RELENG_4_11_0_RELEASE_GENERIC.md.err
22a23,28
> In file included from src_RELENG_4_11_0_RELEASE/sys/i386/isa/pci_cfgreg.c:47:
> machine/pci_cfgreg.h:35: warning: `CONF1_ENABLE_MSK' redefined
> src_RELENG_4_11_0_RELEASE/sys/i386/isa/pcibus.h:35: warning: this is the location of the previous definition
> In file included from src_RELENG_4_11_0_RELEASE/sys/i386/isa/pcibus.c:38:
> machine/pci_cfgreg.h:35: warning: `CONF1_ENABLE_MSK' redefined
> src_RELENG_4_11_0_RELEASE/sys/i386/isa/pcibus.h:35: warning: this is the location of the previous definition


from source diff:
note: RELENG_4_10_0_RELEASE is on the left [<].
diff -r i386/include/pci_cfgreg.h src_RELENG_4_11_0_RELEASE/sys/i386/include/pci_cfgreg.h
26c26
<  * $FreeBSD: src/sys/i386/include/pci_cfgreg.h,v 1.4.2.1 2001/07/28 05:55:07 imp Exp $
---
>  * $FreeBSD: src/sys/i386/include/pci_cfgreg.h,v 1.4.2.2 2004/09/22 20:14:46 ps Exp $
35c35
< #define CONF1_ENABLE_MSK   0x7ff00000ul
---
> #define CONF1_ENABLE_MSK   0x7f000000ul

CONF1_ENABLE_MSK is also present in...
 src_RELENG_4_11_0_RELEASE/sys/i386/isa/pcibus.h:#define CONF1_ENABLE_MSK   0x7ff00000ul
and perhaps in RELENG_5/CURRENT

and is thus redefined as above.
which definition is correct?
is the definition in two source files neeeded?
>How-To-Repeat:
- pristine checkout RELENG_4_11_0_RELEASE or RELENG_4
- make buildkernel or config, make depend
- look for the above warnings
- trace back to commit
>Fix:
if the change to the mask as defined in the mfc was correct,
perhaps update the mask in:
 sys/i386/isa/pcibus.h
as well?
>Release-Note:
>Audit-Trail:

From: "Dan Andersen" <dan_andersen@sympatico.ca>
To: <freebsd-gnats-submit@FreeBSD.org>, <freebsd-stable@FreeBSD.org>
Cc:  
Subject: Re: kern/79266: [patch] RELENG_4 pci CONF1_ENABLE_MSK depend MFCed incorrectly?
Date: Sat, 9 Apr 2005 18:10:21 -0400

 Forgive me for my ignorance.  I'm quite new to FreeBSD. I'm currently having
 a very similar problem, to what you described. But I don't quite understand
 the fix to this brief solution.
 
 Can you please provide me with a more precise answer to this problem.  I
 could really use the help.
 
 Thank you
 
 
State-Changed-From-To: open->closed 
State-Changed-By: gavin 
State-Changed-When: Sat Jun 23 16:05:52 UTC 2007 
State-Changed-Why:  

Now that 4.x has been marked End-of-Life, this PR is no longer 
relevant.  The problem discussed never existed in 5.x or later. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79266 
>Unformatted:
