From antoine@massena-4-82-67-196-50.fbx.proxad.net  Sun Feb 27 15:53:06 2005
Return-Path: <antoine@massena-4-82-67-196-50.fbx.proxad.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A67BB16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Feb 2005 15:53:06 +0000 (GMT)
Received: from barton.dreadbsd.org (massena-4-82-67-196-50.fbx.proxad.net [82.67.196.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BBEFE43D3F
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Feb 2005 15:53:05 +0000 (GMT)
	(envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net)
Received: from barton.dreadbsd.org (localhost [127.0.0.1])
	by barton.dreadbsd.org (8.13.3/8.13.1) with ESMTP id j1RFqomp093411;
	Sun, 27 Feb 2005 16:52:50 +0100 (CET)
	(envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net)
Received: (from antoine@localhost)
	by barton.dreadbsd.org (8.13.3/8.13.1/Submit) id j1RFqn2i093410;
	Sun, 27 Feb 2005 16:52:49 +0100 (CET)
	(envelope-from antoine)
Message-Id: <20050227165249.242b5c46.antoine.brodin@laposte.net>
Date: Sun, 27 Feb 2005 16:52:49 +0100
From: Antoine Brodin <antoine.brodin@laposte.net>
To: freebsd-gnats-submit@FreeBSD.org, antoine.brodin@laposte.net
Subject: Re: [patch] sk(4): plug leaks and fix acquiring duplicate lock of
 same type: "network driver"

>Number:         78149
>Category:       kern
>Synopsis:       Re: [patch] sk(4): plug leaks and fix acquiring duplicate lock of
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 27 16:00:37 GMT 2005
>Closed-Date:    Mon Feb 28 03:17:39 GMT 2005
>Last-Modified:  Mon Feb 28 03:17:39 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 I'm not happy about the following lines in the patch:
 in sk_detach():
 +		while (!SLIST_EMPTY(&sc_if->sk_jinuse_listhead)) {
 +			entry = SLIST_FIRST(&sc_if->sk_jinuse_listhead);
 +			SLIST_REMOVE_HEAD(&sc_if->sk_jinuse_listhead, jpool_entries);
 +			free(entry, M_DEVBUF);
 +		}
 
 Something like this would be probably better:
 
 KASSERT(SLIST_EMPTY(&sc_if->sk_jinuse_listhead),
     ("sk_detach: Jumbo buffers still in use"));
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Mon Feb 28 03:16:59 GMT 2005 
State-Changed-Why:  
Misfiled followup to kern/75677. 


Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Feb 28 03:16:59 GMT 2005 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=78149 
>Unformatted:
  same type: "network driver"
