From nobody@FreeBSD.org  Sun Jan 23 23:02:23 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C6A1116A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jan 2005 23:02:23 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B3ADE43D1D
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jan 2005 23:02:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j0NN2Nn1066915
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Jan 2005 23:02:23 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j0NN2NRO066914;
	Sun, 23 Jan 2005 23:02:23 GMT
	(envelope-from nobody)
Message-Id: <200501232302.j0NN2NRO066914@www.freebsd.org>
Date: Sun, 23 Jan 2005 23:02:23 GMT
From: Mauritz Sundell <mauritz.sundell@home.se>
To: freebsd-gnats-submit@FreeBSD.org
Subject: i4b itjc bad enums for PIB cycle time 
X-Send-Pr-Version: www-2.3

>Number:         76611
>Category:       kern
>Synopsis:       [i4b] [patch] i4b itjc bad enums for PIB cycle time
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-isdn
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 23 23:10:25 GMT 2005
>Closed-Date:    Sat May 13 16:40:58 CEST 2006
>Last-Modified:  Sat May 13 16:40:58 CEST 2006
>Originator:     Mauritz Sundell
>Release:        6.0-CURRENT
>Organization:
>Environment:

>Description:
I think that in src/sys/i4b/layer1/itjc/i4b_itjc_pci.c:
TIGER_PIB_5_CYCLES should be 0x10 (not 0x01)
TIGER_PIB_12_CYCLES should be 0x20 (not 0x10)

Maybe also TIGER_PIB_5_CYCLES should be named TIGER_PIB_8_CYCLES
and TIGER_PIB_12_CYCLES should be named TIGER_PIB_15_CYCLES

The later I'm not sure but atleast accordning to the Tiger320 data sheet rev. 1.2 it should be so.

>How-To-Repeat:
I haven't compiled and used the code, I was only reading it for rewriting zaptel-driver for another TigerJet-based card.   
>Fix:
See description
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-isdn 
Responsible-Changed-By: arved 
Responsible-Changed-When: Tue May 10 13:23:00 GMT 2005 
Responsible-Changed-Why:  
Over to ISDN Mailinglist 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76611 

From: Sergio de Souza Prallon <prallon@tmp.com.br>
To: bug-followup@FreeBSD.org, mauritz.sundell@home.se
Cc: freebsd-isdn@FreeBSD.org
Subject: kern/76611: i4b itjc bad enums for PIB cycle time
Date: Mon, 16 May 2005 21:19:42 -0300

 --6c2NcOVqGQ03X4Wi
 Content-Type: text/plain; charset=us-ascii
 
 Hi,
 
 Thank you for noticing the typo. While fixing it, I found another couple.
 Attached is the diff with the fixes.
 
 []'s
 
 --
 Prallon
 
 --6c2NcOVqGQ03X4Wi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="itjc.diff"
 
 --- i4b_itjc_pci.c.orig	Mon May 16 20:59:39 2005
 +++ i4b_itjc_pci.c	Mon May 16 21:05:40 2005
 @@ -211,8 +211,8 @@
  
  	TIGER_PIB_CYCLE_TIMING_MASK	= 0x30,
  		TIGER_PIB_3_CYCLES	= 0x00,
 -		TIGER_PIB_5_CYCLES	= 0x01,
 -		TIGER_PIB_12_CYCLES	= 0x10,
 +		TIGER_PIB_5_CYCLES	= 0x10,
 +		TIGER_PIB_12_CYCLES	= 0x20,
  
  	TIGER_RESET_MASK		= 0x0F,
  		TIGER_RESET_PULSE_COUNT	= 0x08,
 @@ -224,7 +224,7 @@
  /* DMA Operation */
  	TIGER_DMA_RESTART_MASK		= 0x02,
  		TIGER_HOLD_DMA		= 0x00,
 -		TIGER_RESTART_DMA	= 0x00,
 +		TIGER_RESTART_DMA	= 0x02,
  
  	TIGER_DMA_ENABLE_MASK		= 0x01,
  		TIGER_ENABLE_DMA	= 0x01,
 @@ -251,13 +251,13 @@
  		TIGER_AUX_4_IS_INPUT	= 0x00,
  		TIGER_AUX_4_IS_OUTPUT	= 0x10,
  		TIGER_AUX_3_IS_INPUT	= 0x00,
 -		TIGER_AUX_3_IS_OUTPUT	= 0x80,
 +		TIGER_AUX_3_IS_OUTPUT	= 0x08,
  		TIGER_AUX_2_IS_INPUT	= 0x00,
 -		TIGER_AUX_2_IS_OUTPUT	= 0x40,
 +		TIGER_AUX_2_IS_OUTPUT	= 0x04,
  		TIGER_AUX_1_IS_INPUT	= 0x00,
 -		TIGER_AUX_1_IS_OUTPUT	= 0x20,
 +		TIGER_AUX_1_IS_OUTPUT	= 0x02,
  		TIGER_AUX_0_IS_INPUT	= 0x00,
 -		TIGER_AUX_0_IS_OUTPUT	= 0x10,
 +		TIGER_AUX_0_IS_OUTPUT	= 0x01,
  		TIGER_AUX_NJ_DEFAULT	= 0xEF, /* All but ISAC int is output */
  
  /* Interrupt 0 Mask & Status */
 
 --6c2NcOVqGQ03X4Wi--
State-Changed-From-To: open->closed 
State-Changed-By: hm 
State-Changed-When: Sat May 13 16:40:12 CEST 2006 
State-Changed-Why:  
diff committed to current. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76611 
>Unformatted:
