From naddy@bigeye.rhein-neckar.de  Mon Aug 10 11:32:47 1998
Received: from birdland.rhein-neckar.de (birdland.rhein-neckar.de [193.197.88.3])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA14431
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Aug 1998 11:32:41 -0700 (PDT)
          (envelope-from naddy@bigeye.rhein-neckar.de)
Received: from mips.rhein-neckar.de (uucp@localhost) by birdland.rhein-neckar.de (8.8.7/8.8.3) with bsmtp id UAA27269 for FreeBSD-gnats-submit@freebsd.org; Mon, 10 Aug 1998 20:32:17 +0200 (MET DST)
Received: from bigeye.rhein-neckar.de ([193.197.88.35]) by mips.rhein-neckar.de
	 with esmtp id m0z5w4k-000WySC
	(Debian Smail-3.2.0.101 1997-Dec-17 #2); Mon, 10 Aug 1998 19:49:42 +0200 (CEST)
Received: (from naddy@localhost)
	by bigeye.rhein-neckar.de (8.8.8/8.8.8) id TAA02863;
	Mon, 10 Aug 1998 19:50:07 +0200 (CEST)
	(envelope-from naddy)
Message-Id: <199808101750.TAA02863@bigeye.rhein-neckar.de>
Date: Mon, 10 Aug 1998 19:50:07 +0200 (CEST)
From: Christian Weisgerber <naddy@bigeye.rhein-neckar.de>
Reply-To: naddy@mips.rhein-neckar.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: pcvt treats DEL as a printable character
X-Send-Pr-Version: 3.2

>Number:         7559
>Category:       kern
>Synopsis:       [PATCH] pcvt treats DEL as a printable character
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 10 11:40:00 PDT 1998
>Closed-Date:    Tue Aug 18 20:43:27 PDT 1998
>Last-Modified:  Tue Aug 18 20:44:07 PDT 1998
>Originator:     Christian Weisgerber
>Release:        FreeBSD 2.2.7-STABLE i386
>Organization:
>Environment:

pcvt VT220-compatible console driver.

>Description:

The pcvt console driver outputs a glyph for the ASCII DEL (0x7F)
character. This differs from the behavior of an actual DEC VT220
terminal which treats DEL as a non-printable no-op control character.

>How-To-Repeat:


>Fix:
	
--- /sys/i386/isa/pcvt/pcvt_out.c.orig	Fri Mar  7 09:58:26 1997
+++ /sys/i386/isa/pcvt/pcvt_out.c	Mon Aug 10 16:12:49 1998
@@ -178,10 +178,10 @@
 	if(svsp->sevenbit)
 		ch &= 0x7f;
 
-	if((ch <= 0x1f) && (svsp->transparent == 0))
+	if(((ch <= 0x1f) || (ch == 0x7f)) && (svsp->transparent == 0))
 	{
 
-	/* always process control-chars in the range 0x00..0x1f !!! */
+	/* always process control-chars in the range 0x00..0x1f, 0x7f !!! */
 
 		if(svsp->dis_fnc)
 		{
@@ -323,6 +323,7 @@
 				case 0x1d:	/* GS */
 				case 0x1e:	/* RS */
 				case 0x1f:	/* US */
+				case 0x7f:	/* DEL */
 				break;
 			}
 		}
@@ -330,7 +331,8 @@
 	else
 	{
 
-	/* char range 0x20...0xff processing depends on current state */
+	/* char range 0x20...0x7e, 0x80...0xff processing */
+	/* depends on current state */
 
 		switch(svsp->state)
 		{
@@ -1884,7 +1886,7 @@
  *	partial HP 2392 ANSI mode Emulator
  *	==================================
  *
- *	this part tooks over the emulation of some escape sequences
+ *	this part takes over the emulation of some escape sequences
  *	needed to handle the function key labels
  *
  *	They are modeled after the corresponding escape sequences
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: phk 
State-Changed-When: Thu Aug 13 23:14:07 PDT 1998 
State-Changed-Why:  
awaiting pcvt interested committer 
State-Changed-From-To: suspended->closed 
State-Changed-By: jkoshy 
State-Changed-When: Tue Aug 18 20:43:27 PDT 1998 
State-Changed-Why:  
Fixed in rev 1.16 of "src/sys/i386/isa/pcvt/pcvt_out.c", thanks! 
>Unformatted:
