From nobody@FreeBSD.org  Mon Dec 27 14:33:37 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 022FC16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Dec 2004 14:33:37 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BEA0643D45
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Dec 2004 14:33:36 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBREXakv062538
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Dec 2004 14:33:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iBREXaOR062537;
	Mon, 27 Dec 2004 14:33:36 GMT
	(envelope-from nobody)
Message-Id: <200412271433.iBREXaOR062537@www.freebsd.org>
Date: Mon, 27 Dec 2004 14:33:36 GMT
From: Sergiy Vyshnevetskiy <serg@vostok.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Forgotten tunables for sysvmsg module
X-Send-Pr-Version: www-2.3

>Number:         75541
>Category:       kern
>Synopsis:       [sysv] [patch] Forgotten tunables for sysvmsg module
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 27 14:40:20 GMT 2004
>Closed-Date:    Tue Apr 25 16:21:02 GMT 2006
>Last-Modified:  Tue Apr 25 16:21:02 GMT 2006
>Originator:     Sergiy Vyshnevetskiy
>Release:        5-stable
>Organization:
>Environment:
FreeBSD serg.vostok.net 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Dec  6 11:01:12 EET 2004     root@serg.vostok.net:/usr/5/src/sys/i386/compile/SERG  i386
>Description:
If you load sysvmsg as a module, you can't change values of msgmnb and msgtql - no such tunables.
>How-To-Repeat:
Remove options SYSVMSG from the kernel configuration file, recompile the kernel, reboot, load sysvmsg module.
>Fix:
--- sys/kern/sysv_msg.c.orig  Fri Dec  3 16:48:33 2004                          
+++ sys/kern/sysv_msg.c Fri Dec  3 17:04:58 2004                                
@@ -142,6 +142,8 @@                                                             
  TUNABLE_INT_FETCH("kern.ipc.msgssz", &msginfo.msgssz);                        
  msginfo.msgmax = msginfo.msgseg * msginfo.msgssz;                             
  TUNABLE_INT_FETCH("kern.ipc.msgmni", &msginfo.msgmni);                        
+ TUNABLE_INT_FETCH("kern.ipc.msgmnb", &msginfo.msgmnb);                        
+ TUNABLE_INT_FETCH("kern.ipc.msgtql", &msginfo.msgtql);                        
                                                                                
  msgpool = malloc(msginfo.msgmax, M_MSG, M_WAITOK);                            
  if (msgpool == NULL)                                                          
@@ -1144,8 +1146,8 @@                                                           
 SYSCTL_DECL(_kern_ipc);                                                        
 SYSCTL_INT(_kern_ipc, OID_AUTO, msgmax, CTLFLAG_RD, &msginfo.msgmax, 0, "");   
 SYSCTL_INT(_kern_ipc, OID_AUTO, msgmni, CTLFLAG_RDTUN, &msginfo.msgmni, 0, "");
-SYSCTL_INT(_kern_ipc, OID_AUTO, msgmnb, CTLFLAG_RD, &msginfo.msgmnb, 0, "");   
-SYSCTL_INT(_kern_ipc, OID_AUTO, msgtql, CTLFLAG_RD, &msginfo.msgtql, 0, "");   
+SYSCTL_INT(_kern_ipc, OID_AUTO, msgmnb, CTLFLAG_RDTUN, &msginfo.msgmnb, 0, "");
+SYSCTL_INT(_kern_ipc, OID_AUTO, msgtql, CTLFLAG_RDTUN, &msginfo.msgtql, 0, "");
 SYSCTL_INT(_kern_ipc, OID_AUTO, msgssz, CTLFLAG_RDTUN, &msginfo.msgssz, 0, "");
 SYSCTL_INT(_kern_ipc, OID_AUTO, msgseg, CTLFLAG_RDTUN, &msginfo.msgseg, 0, "");
 SYSCTL_PROC(_kern_ipc, OID_AUTO, msqids, CTLFLAG_RD,                           

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mr 
State-Changed-When: Tue Apr 25 16:19:34 UTC 2006 
State-Changed-Why:  
the patch was commited with rev 1.55 of sysv_msg.c 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75541 
>Unformatted:
