From nobody@FreeBSD.org  Sun Dec 19 05:36:30 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2351816A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2004 05:36:30 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 18B1943D31
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2004 05:36:30 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBJ5aT6L095896
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2004 05:36:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iBJ5aT7j095880;
	Sun, 19 Dec 2004 05:36:29 GMT
	(envelope-from nobody)
Message-Id: <200412190536.iBJ5aT7j095880@www.freebsd.org>
Date: Sun, 19 Dec 2004 05:36:29 GMT
From: Ken Westerback <krw@openbsd.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: timedout_scbs is not initialized with LIST_INIT()
X-Send-Pr-Version: www-2.3

>Number:         75250
>Category:       kern
>Synopsis:       [aic7xxx] [patch] timedout_scbs is not initialized with LIST_INIT()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gibbs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 19 05:40:27 GMT 2004
>Closed-Date:    Tue Nov 29 18:51:04 GMT 2005
>Last-Modified:  Tue Nov 29 18:51:04 GMT 2005
>Originator:     Ken Westerback
>Release:        n/a
>Organization:
OpenBSD
>Environment:
n/a (OpenBSD)
>Description:
The list timedout_scbs in ahd_softc is not initialized anywhere I can
find. The diff below adds a LIST_INIT(&ahd->timedout_scbs) to ahd_alloc(),
which is where the similar list pending_scbs is initialized.

Found while trying to upgrade the OpenBSD ahd driver with the latest
FreeBSD goodies.

I note that a similar problem may exist on ahc, but I haven't started
sync'ing ahc yet.


>How-To-Repeat:
      
>Fix:
Index: aic79xx.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/aic7xxx/aic79xx.c,v
retrieving revision 1.33
diff -u -r1.33 aic79xx.c
--- aic79xx.c	18 Nov 2004 20:22:30 -0000	1.33
+++ aic79xx.c	19 Dec 2004 05:23:19 -0000
@@ -5246,6 +5246,7 @@
 		return (NULL);
 	}
 	LIST_INIT(&ahd->pending_scbs);
+	LIST_INIT(&ahd->timedout_scbs);
 	/* We don't know our unit number until the OSM sets it */
 	ahd->name = name;
 	ahd->unit = -1;
  
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->gibbs 
Responsible-Changed-By: rwatson 
Responsible-Changed-When: Mon Jan 3 19:15:53 GMT 2005 
Responsible-Changed-Why:  
Assign to Justin as he's the last person to get their hands dirty with 
aic79xx.c. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=75250 
State-Changed-From-To: open->suspended 
State-Changed-By: linimon 
State-Changed-When: Tue Nov 29 06:02:19 GMT 2005 
State-Changed-Why:  
Mark this aging PR as suspended. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75250 
State-Changed-From-To: suspended->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Nov 29 18:50:42 GMT 2005 
State-Changed-Why:  
Submitter says that this has been resolved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75250 
>Unformatted:
