From nobody@FreeBSD.org  Fri Nov 12 05:09:20 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8674A16A4D1
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Nov 2004 05:09:20 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7A5B743D31
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Nov 2004 05:09:20 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id iAC59KPN051295
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Nov 2004 05:09:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id iAC59J9k051292;
	Fri, 12 Nov 2004 05:09:19 GMT
	(envelope-from nobody)
Message-Id: <200411120509.iAC59J9k051292@www.freebsd.org>
Date: Fri, 12 Nov 2004 05:09:19 GMT
From: KIYOHARA Takashi <kiyohara@kk.iij4u.or.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Not htonl() but ntohl()
X-Send-Pr-Version: www-2.3

>Number:         73852
>Category:       kern
>Synopsis:       [patch] [firewire] Not htonl() but ntohl() in if_fwsubr.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-firewire
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 12 05:10:27 GMT 2004
>Closed-Date:    Wed Oct 12 13:13:29 MDT 2005
>Last-Modified:  Wed Oct 12 13:13:29 MDT 2005
>Originator:     KIYOHARA Takashi
>Release:        
>Organization:
>Environment:
>Description:
see sys/net/if_fwsubr.c::firewire_input().
Why does it perform htonl() at the time of input of a packet?
An input packet is a network-byte-order. We should use ntohl().
>How-To-Repeat:
      
>Fix:
sys/net/if_fwsubr.c::firewire_input()
-------------------------------------
void
firewire_input(struct ifnet *ifp, struct mbuf *m, uint16_t src)
{

      ... snip ...

	/*
	 * Byte swap the encapsulation header manually.
	 */
-	enc->ul[0] = htonl(enc->ul[0]);
+	enc->ul[0] = ntohl(enc->ul[0]);

	if (enc->unfrag.lf != 0) {
		m = m_pullup(m, 2*sizeof(uint32_t));
		if (!m)
			return;
		enc = mtod(m, union fw_encap *);
-		enc->ul[1] = htonl(enc->ul[1]);
+		enc->ul[1] = ntohl(enc->ul[1]);
		m = firewire_input_fragment(fc, m, src);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-firewire 
Responsible-Changed-By: arved 
Responsible-Changed-When: Mon Jun 6 17:27:02 GMT 2005 
Responsible-Changed-Why:  
over to the firewire Mailinglist 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73852 
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Wed Oct 12 13:13:06 MDT 2005 
State-Changed-Why:  
Looks good, applied!  No need to merge this specifically, so closed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=73852 
>Unformatted:
