From avg@oddity.topspin.kiev.ua  Wed Nov 10 16:46:30 2004
Return-Path: <avg@oddity.topspin.kiev.ua>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8DA3116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 16:46:30 +0000 (GMT)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F2EF43D6E
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 16:46:29 +0000 (GMT)
	(envelope-from avg@oddity.topspin.kiev.ua)
Received: from oddity.topspin.kiev.ua (oddity.topspin.kiev.ua [212.40.38.87])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA07546
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 18:46:27 +0200 (EET)
	(envelope-from avg@oddity.topspin.kiev.ua)
Received: from oddity.topspin.kiev.ua (localhost [127.0.0.1])
	by oddity.topspin.kiev.ua (8.12.10/8.12.10) with ESMTP id iAAGkLpb018367
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 18:46:27 +0200 (EET)
	(envelope-from avg@oddity.topspin.kiev.ua)
Received: (from avg@localhost)
	by oddity.topspin.kiev.ua (8.12.10/8.12.10/Submit) id iAAGi8Mf018363;
	Wed, 10 Nov 2004 18:44:08 +0200 (EET)
	(envelope-from avg)
Message-Id: <200411101644.iAAGi8Mf018363@oddity.topspin.kiev.ua>
Date: Wed, 10 Nov 2004 18:44:08 +0200 (EET)
From: Andriy Gapon <avg@icyb.net.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: linux emulation: semctl(IPC_STAT) has broken return value
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         73778
>Category:       kern
>Synopsis:       [patch] linux emulation: semctl(IPC_STAT) has broken return value
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    emulation
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 10 16:50:28 GMT 2004
>Closed-Date:    Fri Feb 11 13:47:50 GMT 2005
>Last-Modified:  Fri Feb 11 13:47:50 GMT 2005
>Originator:     Andriy Gapon
>Release:        FreeBSD 5.2.1-RELEASE-p11 i386
>Organization:
>Environment:
System:
FreeBSD 4.X, 5.X
	
>Description:
semctl with IPC_STAT command should return zero in case of success, see:
semctl(2)
http://www.opengroup.org/onlinepubs/009695399/functions/semctl.html

because of a bug in linux_semctl() a positive value is returned:
td_retval is assigned a value for both LINUX_IPC_STAT and LINUX_SEM_STAT

this breaks some linux applications with error check "semctl() != 0",
while applications with error check "semctl() < 0" remain happy.
among affected applications is IBM MQ / WEMPS.
	
>How-To-Repeat:
write a small test program or just look at the code
	
>Fix:
apply the following patch
	

--- ipc.patch begins here ---
--- /usr/src/sys/compat/linux/linux_ipc.c.orig	Mon Nov  8 19:10:48 2004
+++ /usr/src/sys/compat/linux/linux_ipc.c	Tue Nov  9 20:00:56 2004
@@ -532,8 +532,11 @@
 		error = __semctl(td, &bsd_args);
 		if (error)
 			return error;
-		td->td_retval[0] = IXSEQ_TO_IPCID(bsd_args.semid,
+		if(bsd_args.cmd == SEM_STAT)
+			td->td_retval[0] = IXSEQ_TO_IPCID(bsd_args.semid,
 							unptr->buf->sem_perm);
+		else
+			td->td_retval[0] = 0;
 		bsd_to_linux_semid_ds(unptr->buf, &linux_semid);
 		return (linux_semid_pushdown(args->cmd & LINUX_IPC_64,
 		    &linux_semid, (caddr_t)args->arg.buf));
--- ipc.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->emulation 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Nov 29 09:18:21 GMT 2004 
Responsible-Changed-Why:  
Reassign to appropriate mailing list. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73778 
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Fri Feb 11 13:47:30 GMT 2005 
State-Changed-Why:  
Fix comitted, thank you for reporting! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73778 
>Unformatted:
