From phil@tripadvisor.com  Fri Sep  3 14:27:15 2004
Return-Path: <phil@tripadvisor.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5C01C16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Sep 2004 14:27:15 +0000 (GMT)
Received: from mx.tripadvisor.com (mx.tripadvisors.com [151.203.96.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D244C43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Sep 2004 14:27:14 +0000 (GMT)
	(envelope-from phil@tripadvisor.com)
Received: from tenzing.tripadvisor.com (tenzing.tripadvisor.com [192.168.33.18])
	by mx.tripadvisor.com (8.12.10/8.12.10) with ESMTP id i83ERDWJ035480
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 3 Sep 2004 10:27:13 -0400 (EDT)
	(envelope-from phil@tripadvisor.com)
Received: from tenzing.tripadvisor.com (localhost.tripadvisor.com [127.0.0.1])
	by tenzing.tripadvisor.com (8.12.9/8.12.9) with ESMTP id i82IPNON010056;
	Thu, 2 Sep 2004 14:25:23 -0400 (EDT)
	(envelope-from phil@tripadvisor.com)
Received: (from root@localhost)
	by tenzing.tripadvisor.com (8.12.9/8.12.9/Submit) id i82IPNBJ010055;
	Thu, 2 Sep 2004 14:25:23 -0400 (EDT)
	(envelope-from phil)
Message-Id: <200409021825.i82IPNBJ010055@tenzing.tripadvisor.com>
Date: Thu, 2 Sep 2004 14:25:23 -0400 (EDT)
From: Phil Budne <phil@tripadvisor.com>
Reply-To: Phil Budne <phil@tripadvisor.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: phil@tripadvisor.com
Subject: Cannot build 5.3 sparc64 kernel with vinum support
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71341
>Category:       kern
>Synopsis:       [patch] Cannot build 5.3 sparc64 kernel with vinum support
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-sparc64
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 03 14:30:18 GMT 2004
>Closed-Date:    Fri Sep 24 22:43:00 GMT 2004
>Last-Modified:  Fri Sep 24 22:43:00 GMT 2004
>Originator:     Phil Budne
>Release:        FreeBSD 5.3-BETA2 sparc64
>Organization:
TripAdvisor
>Environment:
System: FreeBSD tenzing.tripadvisor.com 5.1-CURRENT FreeBSD 5.1-CURRENT #2: Wed Nov 5 12:56:03 EST 2003 root@tenzing.tripadvisor.com:/usr/src/sys/sparc64/compile/TENZING sparc64


>Description:
CVSuped 5.3-BETA2 sources 9/1/2004, cannot build kernel on sparc64
with vinum support; compilation fails

NOTE: this was while building the initial 32btt system, but the problem
is unrelated to sizeof(time_t)

>How-To-Repeat:
kernel config:

include GENERIC
device vinum

>Fix:

The following changes allows kernel to build
(similar patches used to build&run 5.1-CURRENT kernel last November)


*** vinumext.h.orig	Wed Jun 16 05:47:01 2004
--- vinumext.h	Thu Sep  2 13:21:34 2004
***************
*** 247,253 ****
  #define LOCKDRIVE(d) lockdrive (d, __FILE__, __LINE__)
  #else
  #define Malloc(x)  malloc((x), M_DEVBUF, \
! 	curthread->td_proc->p_intr_nesting_level == 0? M_WAITOK: M_NOWAIT)
  #define Free(x)    free((x), M_DEVBUF)
  #define LOCKDRIVE(d) lockdrive (d)
  #endif
--- 247,253 ----
  #define LOCKDRIVE(d) lockdrive (d, __FILE__, __LINE__)
  #else
  #define Malloc(x)  malloc((x), M_DEVBUF, \
! 	curthread->td_intr_nesting_level == 0? M_WAITOK: M_NOWAIT)
  #define Free(x)    free((x), M_DEVBUF)
  #define LOCKDRIVE(d) lockdrive (d)
  #endif
*** vinummemory.c.orig	Sat Jul 10 17:17:04 2004
--- vinummemory.c	Thu Sep  2 13:21:34 2004
***************
*** 92,98 ****
  #else /* not i386 */
  #define LongJmp longjmp					    /* just use the kernel function */
  #endif /* i386 */
- #endif /* VINUMDEBUG */
  
  /* find the base name of a path name */
  char *
--- 92,97 ----
***************
*** 106,112 ****
  	return ++f;					    /* skip the / */
  }
  
- #ifdef VINUMDEBUG
  void
  expand_table(void **table, int oldsize, int newsize, char *file, int line)
  #else
--- 105,110 ----
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-sparc64 
Responsible-Changed-By: arved 
Responsible-Changed-When: Mon Sep 6 14:46:39 GMT 2004 
Responsible-Changed-Why:  
Over to sparc64-mailinglist for review. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71341 
State-Changed-From-To: open->patched 
State-Changed-By: marius 
State-Changed-When: Mon Sep 20 00:15:28 GMT 2004 
State-Changed-Why:  

Committed to HEAD, will try to get it into 5.3. 
Thanks for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71341 
State-Changed-From-To: patched->closed 
State-Changed-By: marius 
State-Changed-When: Fri Sep 24 22:41:24 GMT 2004 
State-Changed-Why:  

MFC'ed to RELENG_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71341 
>Unformatted:
 
