From robert@fledge.watson.org  Sun Jun 28 19:40:22 1998
Received: from fledge.watson.org (robert@COPLAND.CODA.CS.CMU.EDU [128.2.222.48])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20438
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 28 Jun 1998 19:40:22 -0700 (PDT)
          (envelope-from robert@fledge.watson.org)
Received: (from robert@localhost)
	by fledge.watson.org (8.8.8/8.8.8) id WAA06756;
	Sun, 28 Jun 1998 22:40:18 -0400 (EDT)
Message-Id: <199806290240.WAA06756@fledge.watson.org>
Date: Sun, 28 Jun 1998 22:40:18 -0400 (EDT)
From: robert@cyrus.watson.org
Reply-To: robert+freebsd@cyrus.watson.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: current: src/sys/libkern/qsort.c includes stdio.h
X-Send-Pr-Version: 3.2

>Number:         7105
>Category:       kern
>Synopsis:       libkern source includes stdio.h (inappropriate include)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 28 19:40:00 PDT 1998
>Closed-Date:    Tue Jun 30 04:05:24 PDT 1998
>Last-Modified:  Tue Jun 30 04:05:50 PDT 1998
>Originator:     Robert Watson
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:
IBM notebook

	

>Description:

qsort.c includes stdio.h.  This seems inappropriate as it doesn't
(apparently) use anything from it.  Also, shouldn't it be including
sys/libkern.h if it needs access to things like printf?

>How-To-Repeat:

n/a

Discovered the problem when a source tree was out of sync with the 
/usr/include tree.  As a result, one of the typedefs failed in something
included from stdio.  Leading me to question why it was included.

>Fix:
	
Delete the line #include <stdio.h>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: phk 
State-Changed-When: Tue Jun 30 04:05:24 PDT 1998 
State-Changed-Why:  
#included sys/libkern.h instead of stdlib.h 
>Unformatted:
