From ah@abaton.Haakh.de  Sun Aug 22 08:24:54 2004
Return-Path: <ah@abaton.Haakh.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BC33516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Aug 2004 08:24:54 +0000 (GMT)
Received: from natsmtp00.rzone.de (natsmtp00.rzone.de [81.169.145.165])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2CAE943D31
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Aug 2004 08:24:54 +0000 (GMT)
	(envelope-from ah@abaton.Haakh.de)
Received: from abaton.Haakh.de (p5487A594.dip.t-dialin.net [84.135.165.148])
	by post.webmailer.de (8.12.10/8.12.10) with ESMTP id i7M8Oqvd015876
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Aug 2004 10:24:52 +0200 (MEST)
Received: from abaton.Haakh.de (localhost [127.0.0.1])
	by abaton.Haakh.de (8.13.1/8.13.1) with ESMTP id i7M8OpVn012137
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Aug 2004 10:24:51 +0200 (CEST)
	(envelope-from ah@abaton.Haakh.de)
Received: (from root@localhost)
	by abaton.Haakh.de (8.13.1/8.13.1/Submit) id i7M8Op4u012136;
	Sun, 22 Aug 2004 10:24:51 +0200 (CEST)
	(envelope-from ah)
Message-Id: <200408220824.i7M8Op4u012136@abaton.Haakh.de>
Date: Sun, 22 Aug 2004 10:24:51 +0200 (CEST)
From: Charlie & <root@abaton.Haakh.de>
Reply-To: Charlie & <root@abaton.Haakh.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bug in currently unused function
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70815
>Category:       kern
>Synopsis:       bug in currently unused function
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rwatson
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 22 08:30:27 GMT 2004
>Closed-Date:    Sun Aug 22 08:57:56 GMT 2004
>Last-Modified:  Sun Jan 30 12:12:37 GMT 2005
>Originator:     info [at] haakh.de
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
Ingenieurbro Haakh
>Environment:
System: FreeBSD abaton.Haakh.de 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Wed Aug 18 15:53:28 CEST 2004 root@abaton.Haakh.de:/usr/src/sys/i386/compile/ABATON i386


>Description:
	Read-error not handeled due to checking the wrong variable
>How-To-Repeat:
	currently unused function
>Fix:
--- src/sys/boot/common/load.c.orig	Fri Dec 19 15:05:54 2003
+++ src/sys/boot/common/load.c	Sun Aug 22 10:15:24 2004
@@ -73,7 +73,7 @@
     /* Read everything until we know how big it is */
     for (;;) {
 	result = read(fd, buf, LOAD_TINYBUF);
-	if (size == -1) {
+	if (result == -1) {
 	    free(buf, LOAD_TINYBUF);
 	    close(fd);
 	    return(NULL);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Sun Aug 22 08:57:41 GMT 2004 
State-Changed-Why:  
Fixed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70815 
Responsible-Changed-From-To: freebsd-bugs->rwatson 
Responsible-Changed-By: rwatson 
Responsible-Changed-When: Sun Jan 30 12:11:58 GMT 2005 
Responsible-Changed-Why:  
Chown as I've gone ahead and merged this fix to RELENG_5 for 5.4.  Leave 
closed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70815 
>Unformatted:
