From nobody@FreeBSD.org  Sat Jul 24 14:30:25 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 78A7816A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Jul 2004 14:30:25 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7324043D3F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Jul 2004 14:30:25 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i6OEUOj7070540
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Jul 2004 14:30:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i6OEUOp4070539;
	Sat, 24 Jul 2004 14:30:24 GMT
	(envelope-from nobody)
Message-Id: <200407241430.i6OEUOp4070539@www.freebsd.org>
Date: Sat, 24 Jul 2004 14:30:24 GMT
From: Jochen Gensch <incmc@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: PPTP subsystem / ng_pptpgre wrecked!?
X-Send-Pr-Version: www-2.3

>Number:         69536
>Category:       kern
>Synopsis:       [pptp] PPTP subsystem / ng_pptpgre wrecked!? [4.10]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    archie
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 24 14:40:25 GMT 2004
>Closed-Date:    Mon Sep 06 20:40:12 GMT 2004
>Last-Modified:  Mon Sep 06 20:40:12 GMT 2004
>Originator:     Jochen Gensch
>Release:        4.10
>Organization:
>Environment:
Deleted in the meantime. But was 4.10-RELEASE and latest 4-STABLE, both
with GENERIC kernel.
>Description:
I've been using 4.9 with mpd to establish my pptp connection. However
since upgrading to 4.10-RELEASE and also 4-STABLE I'm having serious
problems to establish a connection by mpd. It is mostly impossible to
get the link up. It seems like FreeBSD isn't aware of the GRE packets
coming back from my dial up gateway. When reading up on that on the
internet I found, that something might have been changed on ng_pptpgre
in 4.10-RELEASE an beyond. After donwgrading to 4.9 anything works fine again.
>How-To-Repeat:
Just use 4.10-RELEASE or newer in combination with mpd and try to
establish a pptp connection.
>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->archie 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Sun Sep 5 10:10:28 GMT 2004 
Responsible-Changed-Why:  
Archie, could you please look at this PR? 

Seems like lowering timeout to one second causes problems for 
people who are doing PPTP over slow dialup. What about making 
this parameter configurable or change it to smth like say 3 
seconds? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=69536 

From: Gleb Smirnoff <glebius@freebsd.org>
To: Jochen Gensch <incmc@gmx.de>
Cc: Archie Cobbs <archie@dellroad.org>,
	freebsd-gnats-submit@freebsd.org
Subject: Re: kern/69536: [pptp] PPTP subsystem / ng_pptpgre wrecked!? [4.10]
Date: Sun, 5 Sep 2004 23:45:59 +0400

   Jochen,
 
 can you try out this on 4.10 system: apply this patch to
 ng_pptpgre.c, rebuild ng_pptpgre.ko, load it and check whether
 problem is fixed.
 
 --- ng_pptpgre.c        22 Nov 2003 15:28:16 -0000      1.2.2.14
 +++ ng_pptpgre.c        5 Sep 2004 19:44:06 -0000
 @@ -120,7 +120,7 @@
  #define PPTP_XMIT_WIN          16                      /* max xmit window */
  #define PPTP_MIN_RTT           (PPTP_TIME_SCALE / 10)  /* 100 milliseconds */
  #define PPTP_MIN_TIMEOUT       (PPTP_TIME_SCALE / 83)  /* 12 milliseconds */
 -#define PPTP_MAX_TIMEOUT       (1 * PPTP_TIME_SCALE)   /* 1 second */
 +#define PPTP_MAX_TIMEOUT       (3 * PPTP_TIME_SCALE)   /* 3 seconds */
  
  /* When we recieve a packet, we wait to see if there's an outgoing packet
     we can piggy-back the ACK off of. These parameters determine the mimimum
 
 On Sun, Sep 05, 2004 at 02:04:53PM -0500, Archie Cobbs wrote:
 A> > Seems like lowering timeout to one second causes problems for
 A> > people who are doing PPTP over slow dialup. What about making
 A> > this parameter configurable or change it to smth like say 3
 A> > seconds?
 A> 
 A> Yes, guess that's what we need to do... the timeout is the only
 A> change from 4.9 -> 4.10.. Gleb go ahead and change it to 3 seconds
 A> if you want.
 A> 
 A> As a workaround in the mean time, you might try "set pptp disable windowing".
 
  Archie,
 
 isn't this feature commited after 4.10-RELEASE, or I mistake?
 
 ----------------------------
 revision 1.2.2.15
 date: 2004/05/16 19:26:46;  author: archie;  state: Exp;  lines: +49 -35
 MFC: Add 'enableWindowing' configuration knob to the ng_pptpgre(4) node.
 
 
 -- 
 Totus tuus, Glebius.
 GLEBIUS-RIPN GLEB-RIPE

From: "Jochen Gensch" <incmc@gmx.de>
To: freebsd-gnats-submit@freebsd.org
Cc: glebius@freebsd.org
Subject: Re: kern/69536: [pptp] PPTP subsystem / ng_pptpgre wrecked!? [4.10]
Date: Mon, 6 Sep 2004 15:10:34 +0200 (MEST)

 >   Jochen,
 > 
 > can you try out this on 4.10 system: apply this patch to
 > ng_pptpgre.c, rebuild ng_pptpgre.ko, load it and check whether
 > problem is fixed.
 
 No I can't. This was a production system and I had to get it working again
 very soon. So after a few days I switched back to 4.9, where this problem
 does not occur. It is even worse, we had to change our dsl provider in the
 meantime due to other issues. So I do not have a PPTP dial in possibility
 any more because the new provider uses another technique... anyways let me
 know, if can help someway else.
 
 Jochen
 
 -- 
 NEU: Bis zu 10 GB Speicher fr e-mails & Dateien!
 1 GB bereits bei GMX FreeMail http://www.gmx.net/de/go/mail
 
State-Changed-From-To: open->closed 
State-Changed-By: glebius 
State-Changed-When: Mon Sep 6 20:39:35 GMT 2004 
State-Changed-Why:  
We have increased timeout value to 3 seconds. This should help. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69536 
>Unformatted:
