From nobody@FreeBSD.org  Tue Jun 29 11:28:16 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 38F9D16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Jun 2004 11:28:16 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1D5AF43D31
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Jun 2004 11:28:16 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i5TBSFtC043601
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Jun 2004 11:28:15 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i5TBSFLr043586;
	Tue, 29 Jun 2004 11:28:15 GMT
	(envelope-from nobody)
Message-Id: <200406291128.i5TBSFLr043586@www.freebsd.org>
Date: Tue, 29 Jun 2004 11:28:15 GMT
From: Hirohisa Yamaguchi <umq@ueo.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: building ixgb fails with DEVICE_POLLING
X-Send-Pr-Version: www-2.3

>Number:         68474
>Category:       kern
>Synopsis:       building ixgb fails with DEVICE_POLLING
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tackerman
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 29 11:30:24 GMT 2004
>Closed-Date:    Thu Jul 01 23:46:31 GMT 2004
>Last-Modified:  Thu Jul 01 23:46:31 GMT 2004
>Originator:     Hirohisa Yamaguchi
>Release:        5.2-CURRENT
>Organization:
>Environment:
FreeBSD calliope.local 5.2-CURRENT FreeBSD 5.2-CURRENT #6: Fri Mar 19 18:28:45 JST 2004     root@calliope.loccal:/usr/obj/usr/src/sys/CALLIOPE  i386
>Description:
when compiling kernel with DEVICE_POLLING support from latest cvsup
I get error when compiling if_ixgb.c saying:

cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -std=c99 -g -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000  -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror  /usr/src/sys/dev/ixgb/if_ixgb.c
/usr/src/sys/dev/ixgb/if_ixgb.c: In function `ixgb_init':
/usr/src/sys/dev/ixgb/if_ixgb.c:702: error: structure has no member named `if_ipending'
/usr/src/sys/dev/ixgb/if_ixgb.c: In function `ixgb_intr':
/usr/src/sys/dev/ixgb/if_ixgb.c:762: error: structure has no member named `if_ipending'
*** Error code 1

>How-To-Repeat:
1. make kernel config has ixgb and polling(4) at the same time.
2. run buildkernel
>Fix:
apply patch follwing:

--- sys/dev/ixgb/if_ixgb.c.orig Tue May 28 09:22:58 2004
+++ sys/dev/ixgb/if_ixgb.c      Tue Jun 29 19:27:05 2004
@@ -699,7 +699,7 @@ ixgb_init(void *arg)
         * Only disable interrupts if we are polling, make sure they are on
         * otherwise.
         */
-       if (ifp->if_ipending & IFF_POLLING)
+       if (ifp->if_flags & IFF_POLLING)
                ixgb_disable_intr(adapter);
        else
 #endif                         /* DEVICE_POLLING */
@@ -759,7 +759,7 @@ ixgb_intr(void *arg)
        ifp = &adapter->interface_data.ac_if;

 #ifdef DEVICE_POLLING
-       if (ifp->if_ipending & IFF_POLLING)
+       if (ifp->if_flags & IFF_POLLING)
                return;

        if (ether_poll_register(ixgb_poll, ifp)) {


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->tackerman 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue Jun 29 17:02:30 GMT 2004 
Responsible-Changed-Why:  
Over to ixgb(4) maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68474 
State-Changed-From-To: open->closed 
State-Changed-By: tackerman 
State-Changed-When: Thu Jul 1 23:40:53 GMT 2004 
State-Changed-Why:  
Fix closes issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68474 
>Unformatted:
Suggested patch applied to accomodate structure change.
