From nakaji@tutrp.tut.ac.jp  Tue Jun 22 23:54:15 2004
Return-Path: <nakaji@tutrp.tut.ac.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EEF6A16A4CF; Tue, 22 Jun 2004 23:54:15 +0000 (GMT)
Received: from pcat.heimat.gr.jp (catv-118-241.tees.ne.jp [203.141.118.241])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 30C0C43D1D; Tue, 22 Jun 2004 23:54:15 +0000 (GMT)
	(envelope-from nakaji@tutrp.tut.ac.jp)
Received: from xa12.heimat.gr.jp (xa12.heimat.gr.jp [202.216.136.35])
	by pcat.heimat.gr.jp (8.12.11/8.12.11) with ESMTP id i5MNs39d060960;
	Wed, 23 Jun 2004 08:54:03 +0900 (JST)
	(envelope-from nakaji@tutrp.tut.ac.jp)
Message-Id: <86wu1z409w.fsf@xa12.heimat.gr.jp>
Date: Wed, 23 Jun 2004 08:54:03 +0900
From: NAKAJI Hiroyuki <nakaji@jp.freebsd.org>
Sender: nakaji@tutrp.tut.ac.jp
To: =?ISO-8859-1?Q?S=F8ren?= Schmidt <sos@DeepCore.dk>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG, sos@FreeBSD.ORG
In-Reply-To: <40D7472C.1060507@DeepCore.dk> (=?ISO-8859-1?Q?S=F8ren?=
 Schmidt's message of "Mon, 21 Jun 2004 22:38:04 +0200")
Subject: Re: recent kernel cannot boot on pc98 with ata disks
References: <200406180131.i5I1VA0D021169@xa12.heimat.gr.jp>
 <40D7472C.1060507@DeepCore.dk>

>Number:         68216
>Category:       kern
>Synopsis:       Re: recent kernel cannot boot on pc98 with ata disks
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 23 00:00:49 GMT 2004
>Closed-Date:    Sat Jun 26 08:04:18 GMT 2004
>Last-Modified:  Sat Jun 26 08:04:18 GMT 2004
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 >>>>> In <40D7472C.1060507@DeepCore.dk>=20
 >>>>>	S=F8ren Schmidt <sos@DeepCore.dk> wrote:
 
 > Urhm recent ? jan 4'th isn't recent to me, please try something really=20
 > reacent like 21 jun 2004.
 
 OK. I tried Jun 22nd kernel with one line change:
 
 Index: ata-queue.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /net/pcat/home/ncvs/src/sys/dev/ata/ata-queue.c,v
 retrieving revision 1.29
 diff -u -u -r1.29 ata-queue.c
 --- ata-queue.c	1 Jun 2004 12:26:08 -0000	1.29
 +++ ata-queue.c	22 Jun 2004 23:38:57 -0000
 @@ -219,7 +219,7 @@
  	    bio_taskqueue(request->bio, (bio_task_t *)ata_completed, request);
  	else {
  	    TASK_INIT(&request->task, 0, ata_completed, request);
 -	    taskqueue_enqueue(taskqueue_thread, &request->task);
 +	    taskqueue_enqueue(taskqueue_swi, &request->task);
  	}
      }
  }
 
 This kernel CAN BOOT so I think taskqueue_thread() causes the
 problem at least on pc98.
 
 $ uname -a
 FreeBSD xa12.heimat.gr.jp 5.2-CURRENT FreeBSD 5.2-CURRENT #3: Tue Jun 22 23=
 :20:42 JST 2004     root@xa12.heimat.gr.jp:/usr/obj/home/nakaji/FreeBSD-PC9=
 8/src/sys/NAKAJI  i386
 
 You committed on 2004.02.17.19.24.11 two line change,
 
   revision 1.21
   date: 2004/02/17 19:24:11;  author: sos;  state: Exp;  lines: +2 -2
   Dont use the bio_taskqueue if we are in timeout.
   Use taskqueue_thread rather than taskqueue_swi (maybe we should have
   a taskqueue_ata).
 
 and the latter seems bad for pc98.
 
 Thanks.
 --=20
 NAKAJI Hiroyuki
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jun 26 08:03:47 GMT 2004 
State-Changed-Why:  
Misfiled followup to kern/68066.  Content transferred. 


Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jun 26 08:03:47 GMT 2004 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=68216 
>Unformatted:
