From nobody@FreeBSD.org  Thu Jun  3 13:35:44 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1394C16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Jun 2004 13:35:44 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E4BDB43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Jun 2004 13:35:43 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i53KZh0G090872
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 3 Jun 2004 13:35:43 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i53KZhQV090871;
	Thu, 3 Jun 2004 13:35:43 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200406032035.i53KZhQV090871@www.freebsd.org>
Date: Thu, 3 Jun 2004 13:35:43 -0700 (PDT)
From: Willem Jan Withagen <wjw@withagen.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Coredumps > 2Gb do not work (on 64bits platforms)
X-Send-Pr-Version: www-2.3

>Number:         67546
>Category:       kern
>Synopsis:       [2TB] Coredumps > 2Gb do not work (on 64bits platforms)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 03 13:40:22 PDT 2004
>Closed-Date:    Sun Mar 11 14:29:06 GMT 2007
>Last-Modified:  Sun Mar 11 14:29:06 GMT 2007
>Originator:     Willem Jan Withagen
>Release:        5.2.-CURRENT
>Organization:
Digiware
>Environment:
FreeBSD opteron.digiware.nl 5.2-CURRENT FreeBSD 5.2-CURRENT #12: Mon May 31 22:11:43 CEST 2004  wjw@opteron.digiware.nl:/usr/obj/home2/src/sys/OPTERON.amd64  amd64
      
>Description:
When allocating memoryblocks > 2Gb and the program crashes, then it is not able to write a coredump. This is due to faulty parameter specification since int <> long on 64bits platforms. Correct (proto)typing of the lenght corrects the problem.
>How-To-Repeat:
cd /usr/ports/devel/cocktail; make patch
cd work/cocktail-9309/reuse/m2c; make test
./rMemoryDrv
>Fix:
--- sys/kern/vfs_vnops.c.org    Mon May 31 22:42:48 2004
+++ sys/kern/vfs_vnops.c        Mon May 31 23:27:46 2004
@@ -370,7 +370,7 @@
        enum uio_rw rw;
        struct vnode *vp;
        caddr_t base;
-       int len;
+       size_t len;
        off_t offset;
        enum uio_seg segflg;
        int ioflg;
@@ -460,7 +460,7 @@
        enum uio_rw rw;
        struct vnode *vp;
        caddr_t base;
-       int len;
+       size_t len;
        off_t offset;
        enum uio_seg segflg;
        int ioflg;
--- sys/sys/vnode.h.org Mon May 31 21:57:28 2004
+++ sys/sys/vnode.h     Mon May 31 21:58:38 2004
@@ -658,11 +658,11 @@
 void   vn_pollgone(struct vnode *vp);
 int    vn_pollrecord(struct vnode *vp, struct thread *p, int events);
 int    vn_rdwr(enum uio_rw rw, struct vnode *vp, caddr_t base,
-           int len, off_t offset, enum uio_seg segflg, int ioflg,
+           u_int64_t len, off_t offset, enum uio_seg segflg, int ioflg,
            struct ucred *active_cred, struct ucred *file_cred, int *aresid,
            struct thread *td);
 int    vn_rdwr_inchunks(enum uio_rw rw, struct vnode *vp, caddr_t base,
-           int len, off_t offset, enum uio_seg segflg, int ioflg,
+           u_int64_t len, off_t offset, enum uio_seg segflg, int ioflg,
            struct ucred *active_cred, struct ucred *file_cred, int *aresid,
            struct thread *td);
 int    vn_stat(struct vnode *vp, struct stat *sb, struct ucred *active_cred,
      
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->tjr 
Responsible-Changed-By: tjr 
Responsible-Changed-When: Thu Jun 3 22:16:05 PDT 2004 
Responsible-Changed-Why:  
I have a better patch for this that I will commit soon. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67546 
State-Changed-From-To: open->patched 
State-Changed-By: tjr 
State-Changed-When: Thu Jun 3 23:32:00 PDT 2004 
State-Changed-Why:  
Fixed in -current. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67546 
Responsible-Changed-From-To: tjr->freebsd-bugs 
Responsible-Changed-By: tjr 
Responsible-Changed-When: Thu Jun 3 23:32:31 PDT 2004 
Responsible-Changed-Why:  
I won't be MFCing this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67546 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sun Mar 11 14:29:04 UTC 2007 
State-Changed-Why:  
This is in recent versions of FreeBSD now (after almost three years in 
HEAD this means it is in 6.X) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67546 
>Unformatted:
