From nobody@FreeBSD.org  Fri May 21 14:47:09 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E266C16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 May 2004 14:47:09 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB81E43D2F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 May 2004 14:47:09 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i4LLl9PB074269
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 May 2004 14:47:09 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i4LLl9SV074268;
	Fri, 21 May 2004 14:47:09 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200405212147.i4LLl9SV074268@www.freebsd.org>
Date: Fri, 21 May 2004 14:47:09 -0700 (PDT)
From: Zhenmin <zli4@cs.uiuc.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: A potential bug detected in /sys/netatm/uni/unisig_subr.c
X-Send-Pr-Version: www-2.3

>Number:         67012
>Category:       kern
>Synopsis:       A potential bug detected in /sys/netatm/uni/unisig_subr.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    harti
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 21 14:50:21 PDT 2004
>Closed-Date:    Mon Jul 19 12:54:28 GMT 2004
>Last-Modified:  Mon Jul 19 12:54:28 GMT 2004
>Originator:     Zhenmin
>Release:        5.2.1
>Organization:
OPERA Research Group, UIUC
>Environment:
>Description:
The potential bug is detected by our analysis tool in file 
/sys/netatm/uni/unisig_subr.c:1210

1207                 bcopy(&ie_cgad_absent,
1208                                 &msg->msg_ie_cgad->ie_u.ie_cgad,
1209                                 sizeof(ie_cgad_absent));
1210                 msg->msg_ie_cgsa->ie_ident = UNI_IE_CGSA;
1211                 ATM_ADDR_COPY(&ap->calling.addr,
1212                                 &msg->msg_ie_cgad->ie_cgad_addr);

>How-To-Repeat:
The potential bug is detected by our analysis tool.
>Fix:
--- unisig_subr.c       2003-07-23 09:28:57.000000000 -0500
+++ unisig_subr.c.fixed       2004-05-21 16:27:46.000000000 -0500
@@ -1207,7 +1207,7 @@
                bcopy(&ie_cgad_absent,
                                &msg->msg_ie_cgad->ie_u.ie_cgad,
                                sizeof(ie_cgad_absent));
-               msg->msg_ie_cgsa->ie_ident = UNI_IE_CGSA;
+               msg->msg_ie_cgad->ie_ident = UNI_IE_CGAD;
                ATM_ADDR_COPY(&ap->calling.addr,
                                &msg->msg_ie_cgad->ie_cgad_addr);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->harti 
Responsible-Changed-By: harti 
Responsible-Changed-When: Thu Jul 15 11:12:04 GMT 2004 
Responsible-Changed-Why:  
I take a look at this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67012 
State-Changed-From-To: open->closed 
State-Changed-By: harti 
State-Changed-When: Mon Jul 19 12:54:09 GMT 2004 
State-Changed-Why:  
Patch committed. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67012 
>Unformatted:
