From delphij@frontfree.net  Mon Apr 26 00:07:59 2004
Return-Path: <delphij@frontfree.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E13BC16A4CE; Mon, 26 Apr 2004 00:07:59 -0700 (PDT)
Received: from avgw.bjut.edu.cn (avgw.bjut.edu.cn [202.112.78.85])
	by mx1.FreeBSD.org (Postfix) with SMTP
	id 9B83B43D5C; Mon, 26 Apr 2004 00:07:58 -0700 (PDT)
	(envelope-from delphij@frontfree.net)
Received: from beastie.frontfree.net ([218.107.145.7])
 by avgw.bjut.edu.cn (SAVSMTP 3.1.5.43) with SMTP id M2004042615074923423
 ; Mon, 26 Apr 2004 15:07:49 +0800
Received: from localhost (localhost [127.0.0.1])
	by beastie.frontfree.net (Postfix) with ESMTP
	id 402D2115A0; Mon, 26 Apr 2004 15:07:41 +0800 (CST)
Received: from beastie.frontfree.net ([127.0.0.1])
 by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 00838-10; Mon, 26 Apr 2004 15:07:40 +0800 (CST)
Received: by beastie.frontfree.net (Postfix, from userid 1001)
	id C752E11565; Mon, 26 Apr 2004 15:07:40 +0800 (CST)
Message-Id: <20040426070740.C752E11565@beastie.frontfree.net>
Date: Mon, 26 Apr 2004 15:07:40 +0800 (CST)
From: Xin LI <delphij@frontfree.net>
Reply-To: Xin LI <delphij@frontfree.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: njl@FreeBSD.org
Subject: [PATCH] Fix kernel build error introduced by sys/dev/acpica/acpi.c,v 1.142
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65979
>Category:       kern
>Synopsis:       [PATCH] Fix kernel build error introduced by sys/dev/acpica/acpi.c,v 1.142
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    njl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 26 00:10:23 PDT 2004
>Closed-Date:    Mon Apr 26 01:57:27 PDT 2004
>Last-Modified:  Tue Jun 15 05:50:23 GMT 2004
>Originator:     Xin LI
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
The FreeBSD Simplified Chinese Project
>Environment:
System: FreeBSD beastie.frontfree.net 5.2-CURRENT FreeBSD 5.2-CURRENT #22: Wed Apr 14 17:57:37 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386


>Description:
	Move defination of status with what has been done with v. 1.142.	
>How-To-Repeat:
	make kernel
>Fix:

	Apply the attached patch

--- patch-acpi begins here ---
Index: sys/dev/acpica/acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v
retrieving revision 1.142
diff -u -r1.142 acpi.c
--- sys/dev/acpica/acpi.c	26 Apr 2004 05:25:06 -0000	1.142
+++ sys/dev/acpica/acpi.c	26 Apr 2004 07:01:03 -0000
@@ -1159,6 +1159,7 @@
 static void
 acpi_shutdown_final(void *arg, int howto)
 {
+    ACPI_STATUS	status;
 
     ACPI_ASSERTLOCK;
 
--- patch-acpi ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->njl 
Responsible-Changed-By: nork 
Responsible-Changed-When: Mon Apr 26 00:59:15 PDT 2004 
Responsible-Changed-Why:  
Over to ACPI maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65979 
State-Changed-From-To: open->closed  
State-Changed-By: takawata 
State-Changed-When: Mon Apr 26 01:54:25 PDT 2004 
State-Changed-Why:  
Commmitted Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=65979 

From: Nate Lawson <nate@root.org>
To: Xin LI <delphij@frontfree.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/65979
Date: Mon, 26 Apr 2004 08:08:33 -0700 (PDT)

 Thanks for the submission.  However, please email patches directly to the
 acpi list (acpi@freebsd.org) instead of sending them as a PR.  If the
 problem you report is big enough to require investigation, we'll ask that
 you file a PR after you report it to the list.  A small problem like this
 does not require a PR.
 
 Thanks,
 Nate

From: Xin LI <delphij@frontfree.net>
To: Nate Lawson <nate@root.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/65979
Date: Tue, 27 Apr 2004 00:52:20 +0800

 --J2SCkAp4GZ/dPZZf
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Ok. I am not very interested in ACPI so I did not noticed the presence of
 the new list. I'll subscribe it and submit this type of patches there.
 Thank you for pointing that out :-)
 
 BTW. I'm not sure if my problem is ACPI related. It was discussed in
 current@, I thought your today's commit should fixed it but unfortunatelly
 it did not.
 
 http://lists.freebsd.org/pipermail/freebsd-current/2004-April/024979.html
 
 This is very strange and I am still trying to figure out what was happening.
 In fact, on a HTT enabled Pentium 4 2.6C box there's not the exact problem.
 Given the following mail said that setting hw.acpi.disable_on_poweroff to
 0 works around the issue, I think it might be useful to take a more deeper
 look at it:
 
 http://lists.freebsd.org/pipermail/freebsd-hackers/2004-April/006500.html
 
 Still investigating this... Do you think it's suitable for acpi@? IMHO I
 am not sure whether this is ACPI related so I heisistate to do that.
 
 While I personally interest in file systems and virtual memory and related
 subsystems much more than ACPI, I want to say "thank you" for your hard work
 maintaining ACPI on FreeBSD, because it made the management of servers
 easier, especially when there is some power failures and I can just tell
 the hosting room operators to "just hit the power button" rather than tell
 them my root password :-)
 
 On Mon, Apr 26, 2004 at 08:08:33AM -0700, Nate Lawson wrote:
 > Thanks for the submission.  However, please email patches directly to the
 > acpi list (acpi@freebsd.org) instead of sending them as a PR.  If the
 > problem you report is big enough to require investigation, we'll ask that
 > you file a PR after you report it to the list.  A small problem like this
 > does not require a PR.
 
 Cheers,
 --=20
 Xin LI <delphij frontfree net>	http://www.delphij.net/
 See complete headers for GPG key and other information.
 
 
 --J2SCkAp4GZ/dPZZf
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAjT5EOfuToMruuMARAp02AJsE12+oi0XsSB5AQZ3t2IcBrlrHMwCggiS4
 ydPxXfgAHKAQwzrqecTaWSY=
 =F7AY
 -----END PGP SIGNATURE-----
 
 --J2SCkAp4GZ/dPZZf--

From: Nate Lawson <nate@root.org>
To: Xin LI <delphij@frontfree.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/65979
Date: Mon, 14 Jun 2004 22:28:53 -0700 (PDT)

 On Tue, 27 Apr 2004, Xin LI wrote:
 > Ok. I am not very interested in ACPI so I did not noticed the presence of
 > the new list. I'll subscribe it and submit this type of patches there.
 > Thank you for pointing that out :-)
 >
 > BTW. I'm not sure if my problem is ACPI related. It was discussed in
 > current@, I thought your today's commit should fixed it but unfortunatelly
 > it did not.
 >
 > http://lists.freebsd.org/pipermail/freebsd-current/2004-April/024979.html
 >
 > This is very strange and I am still trying to figure out what was happening.
 > In fact, on a HTT enabled Pentium 4 2.6C box there's not the exact problem.
 > Given the following mail said that setting hw.acpi.disable_on_poweroff to
 > 0 works around the issue, I think it might be useful to take a more deeper
 > look at it:
 >
 > http://lists.freebsd.org/pipermail/freebsd-hackers/2004-April/006500.html
 
 This should be fixed now.  Let me know if it's not.
 
 -Nate

From: Xin LI <delphij@frontfree.net>
To: Nate Lawson <nate@root.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/65979
Date: Tue, 15 Jun 2004 13:42:54 +0800

 --M9NhX3UHpAaciwkO
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, Jun 14, 2004 at 10:28:53PM -0700, Nate Lawson wrote:
 [My mail contents snipped]
 > > http://lists.freebsd.org/pipermail/freebsd-hackers/2004-April/006500.ht=
 ml
 >=20
 > This should be fixed now.  Let me know if it's not.
 
 Yes, I saw your commit and it _DOES_ fixed the problem, thank you for fixin=
 g it.
 I think this PR could be closed.
 
 I have posted a new problem in current@ and acpi@. I'm not sure whether it =
 is
 or not ACPI-related. The crash is really annoying however fortunatelly it d=
 oes not
 cause any data corruption (panic happens right after "shutting down with AC=
 PI").
 
 Cheers,
 --=20
 Xin LI <delphij frontfree net>	http://www.delphij.net/
 See complete headers for GPG key and other information.
 
 
 --M9NhX3UHpAaciwkO
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAzoxeOfuToMruuMARAnbKAJ4jU+aNi+nv+MNQcMk/XKxxx7VIQQCfeBrh
 +dZfuqFLCNtbsXmarOZJchQ=
 =WHyq
 -----END PGP SIGNATURE-----
 
 --M9NhX3UHpAaciwkO--
>Unformatted:
