From daved@wolf.tamu.edu  Tue Apr  6 14:15:29 2004
Return-Path: <daved@wolf.tamu.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C35716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Apr 2004 14:15:29 -0700 (PDT)
Received: from wolf.tamu.edu (wolf.tamu.edu [165.91.250.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 04D4043D49
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Apr 2004 14:15:28 -0700 (PDT)
	(envelope-from daved@wolf.tamu.edu)
Received: from wolf.tamu.edu (localhost [127.0.0.1])
	by wolf.tamu.edu (8.12.10/8.12.10) with ESMTP id i36LEqkV001083
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 6 Apr 2004 16:14:52 -0500 (CDT)
	(envelope-from daved@wolf.tamu.edu)
Received: (from daved@localhost)
	by wolf.tamu.edu (8.12.10/8.12.10/Submit) id i36LEpaW001082;
	Tue, 6 Apr 2004 16:14:51 -0500 (CDT)
	(envelope-from daved)
Message-Id: <200404062114.i36LEpaW001082@wolf.tamu.edu>
Date: Tue, 6 Apr 2004 16:14:51 -0500 (CDT)
From: David J Duchscher <daved@tamu.edu>
Reply-To: David J Duchscher <daved@tamu.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Outgoing broadcast packets are not being counted iin if_data structure.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65273
>Category:       kern
>Synopsis:       Outgoing broadcast packets are not being counted iin if_data structure.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 06 14:20:12 PDT 2004
>Closed-Date:    Mon Apr 12 08:02:29 PDT 2004
>Last-Modified:  Mon Apr 12 08:02:29 PDT 2004
>Originator:     David J Duchscher
>Release:        FreeBSD 5.2.1-RELEASE-p3 i386
>Organization:
Texas A&M University
>Environment:
System: FreeBSD wolf.tamu.edu 5.2.1-RELEASE-p3 FreeBSD 5.2.1-RELEASE-p3 #2: Tue Apr 6 14:07:51 CDT 2004 root@wolf.tamu.edu:/data/obj/data/src/sys/GENERIC i386

>Description:

Outgoing broadcast packets are not being counted and reflected in the
if_data structure (ifi_omcasts).  Incoming broadcast packets are being
counted.

>How-To-Repeat:

>Fix:

--- sys/net/if_var.h.orig       Tue Apr  6 16:07:24 2004
+++ sys/net/if_var.h    Tue Apr  6 16:07:45 2004
@@ -324,7 +324,7 @@
        }
        if (ifp != NULL) {
                ifp->if_obytes += m->m_pkthdr.len + adjust;
-               if (m->m_flags & M_MCAST)
+               if (m->m_flags & (M_BCAST|M_MCAST))
                        ifp->if_omcasts++;
                active = ifp->if_flags & IFF_OACTIVE;
        }



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Mon Apr 12 08:01:45 PDT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65273 
>Unformatted:
