From nobody@FreeBSD.org  Sun Mar 28 06:37:50 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E5CAB16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2004 06:37:50 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DF5AE43D1D
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2004 06:37:50 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i2SEbo72036869
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2004 06:37:50 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i2SEboJo036868;
	Sun, 28 Mar 2004 06:37:50 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200403281437.i2SEboJo036868@www.freebsd.org>
Date: Sun, 28 Mar 2004 06:37:50 -0800 (PST)
From: Samy Al Bahra <samy@kerneled.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Patch] Add additional AGP registers to src/sys/pci/agpreg.h
X-Send-Pr-Version: www-2.3

>Number:         64846
>Category:       kern
>Synopsis:       [Patch] Add additional AGP registers to src/sys/pci/agpreg.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 28 06:40:21 PST 2004
>Closed-Date:    Sun Apr 04 20:33:12 MDT 2004
>Last-Modified:  Sun Apr 04 20:33:12 MDT 2004
>Originator:     Samy Al Bahra
>Release:        FreeBSD -CURRENT
>Organization:
Kerneled
>Environment:
>Description:
src/sys/pci/agpreg.h is missing some important AGP register values and offsets. The following patch defines these values. These values are quite important for userspace utilities who depend on these values.
>How-To-Repeat:
Port a mainstream application dependant on PCI bus AGP access routines.
>Fix:
http://samy.kerneled.com/agpreg.h.patch

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Sun Apr 4 20:32:56 MDT 2004 
State-Changed-Why:  
Committed fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64846 
>Unformatted:
 >>----------
 --- agpreg.h	Tue Aug 26 15:28:31 2003
 +++ /home/samy/development/freebsd/patches/agpreg.h	Thu Oct  9 00:54:24 2003
 @@ -46,6 +46,28 @@
  
  #define AGP_STATUS		0x4
  #define AGP_COMMAND		0x8
 +#define AGP_STATUS_AGP3		0x0008
 +#define AGP_STATUS_RQ_MASK	0xff000000
 +#define AGP_COMMAND_RQ_MASK	0xff000000
 +#define AGP_STATUS_ARQSZ_MASK	0xe000
 +#define AGP_COMMAND_ARQSZ_MASK	0xe000
 +#define AGP_STATUS_CAL_MASK	0x1c00
 +#define AGP_COMMAND_CAL_MASK	0x1c00
 +#define AGP_STATUS_ISOCH	0x10000
 +#define AGP_STATUS_SBA		0x0200
 +#define AGP_STATUS_ITA_COH	0x0100
 +#define AGP_STATUS_GART64	0x0080
 +#define AGP_STATUS_HTRANS	0x0040
 +#define AGP_STATUS_64BIT	0x0020
 +#define AGP_STATUS_FW		0x0010
 +#define AGP_COMMAND_RQ_MASK 	0xff000000
 +#define AGP_COMMAND_ARQSZ_MASK	0xe000
 +#define AGP_COMMAND_CAL_MASK	0x1c00
 +#define AGP_COMMAND_SBA		0x0200
 +#define AGP_COMMAND_AGP		0x0100
 +#define AGP_COMMAND_GART64	0x0080
 +#define AGP_COMMAND_64BIT	0x0020
 +#define AGP_COMMAND_FW		0x0010
  
  /*
   * Config offsets for Intel AGP chipsets.
 >>----------
 
