From glebius@cell.sick.ru  Thu Mar 11 00:14:13 2004
Return-Path: <glebius@cell.sick.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 02B9316A4CF
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 00:14:13 -0800 (PST)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 18C2A43D2D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 00:14:12 -0800 (PST)
	(envelope-from glebius@cell.sick.ru)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.12.9/8.12.8) with ESMTP id i2B8E9QE085190
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 11:14:09 +0300 (MSK)
	(envelope-from glebius@cell.sick.ru)
Received: (from glebius@localhost)
	by cell.sick.ru (8.12.9/8.12.6/Submit) id i2B8E8HP085189;
	Thu, 11 Mar 2004 11:14:09 +0300 (MSK)
Message-Id: <200403110814.i2B8E8HP085189@cell.sick.ru>
Date: Thu, 11 Mar 2004 11:14:09 +0300 (MSK)
From: Gleb Smirnoff <glebius@cell.sick.ru>
Reply-To: Gleb Smirnoff <glebius@cell.sick.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: remove confusing EDQUOT from routing API
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64090
>Category:       kern
>Synopsis:       remove confusing EDQUOT from routing API
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 11 00:20:14 PST 2004
>Closed-Date:    Thu Nov 03 12:05:32 GMT 2005
>Last-Modified:  Thu Nov 03 12:05:32 GMT 2005
>Originator:     Gleb Smirnoff
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD think.oilspace.com 5.2-CURRENT FreeBSD 5.2-CURRENT #12: Tue Mar  9 11:40:30 MSK 2004     glebius@think.oilspace.com:/usr/obj/usr/src/sys/THINKPAD_T20  i386

>Description:

	When an attempt to create a route with gateway reached by the same
	route is made, kernel returns confusing EDQUOT error.

How-To-Repeat:

	route change default 1.1.1.1

>How-To-Repeat:
>Fix:

	Change returning error in route.c (line 1102 in rev. 1.94) to
	something more clear. Change this constant in src/sbin/route/route.c
	(line 775 in rev. 1.70) as well.

	Instead of EDQUOT you can use ELOOP, or at least EINVAL. Or a new errno
	called ERECUR /* recursion detected */ can be created.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: bms 
State-Changed-When: Fri Jun 18 01:43:41 GMT 2004 
State-Changed-Why:  
I see it, and it will probably go away after the ARP rewrite. 


Responsible-Changed-From-To: freebsd-bugs->bms 
Responsible-Changed-By: bms 
Responsible-Changed-When: Fri Jun 18 01:43:41 GMT 2004 
Responsible-Changed-Why:  
I'll take this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64090 

From: Bruce M Simpson <bms@spc.org>
To: glebius@cell.sick.ru, freebsd-bugs@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/64090: remove confusing EDQUOT from routing API
Date: Fri, 18 Jun 2004 02:46:18 +0100

 On Fri, Jun 18, 2004 at 01:44:13AM +0000, Bruce M Simpson wrote:
 > State-Changed-Why: 
 > I see it, and it will probably go away after the ARP rewrite.
 
 Would EADDRINUSE be acceptable in the meantime? None of the network
 code *relies* on seeing EDQUOT, and EADDRINUSE has the most useful
 human-readable error message here for the case mentioned in the PR.
 
 BMS
State-Changed-From-To: analyzed->patched 
State-Changed-By: bms 
State-Changed-When: Fri Jun 18 12:28:40 GMT 2004 
State-Changed-Why:  
This was actually fixed by ru@ in src/sbin/route/route.c rev 1.47. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64090 

From: Gleb Smirnoff <glebius@cell.sick.ru>
To: Bruce M Simpson <bms@spc.org>
Cc: freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/64090: remove confusing EDQUOT from routing API
Date: Sat, 19 Jun 2004 01:43:01 +0400

 On Fri, Jun 18, 2004 at 02:46:18AM +0100, Bruce M Simpson wrote:
 B> On Fri, Jun 18, 2004 at 01:44:13AM +0000, Bruce M Simpson wrote:
 B> > State-Changed-Why: 
 B> > I see it, and it will probably go away after the ARP rewrite.
 B> 
 B> Would EADDRINUSE be acceptable in the meantime? None of the network
 B> code *relies* on seeing EDQUOT, and EADDRINUSE has the most useful
 B> human-readable error message here for the case mentioned in the PR.
 
 Fine from my viewpoint. Much better than what we have now.
 Thanks!
 
 -- 
 Totus tuus, Glebius.
 GLEBIUS-RIPN GLEB-RIPE
State-Changed-From-To: patched->closed 
State-Changed-By: bms 
State-Changed-When: Tue Nov 2 07:04:22 GMT 2004 
State-Changed-Why:  
RELENG_5 has now been branched as -STABLE 


http://www.freebsd.org/cgi/query-pr.cgi?pr=64090 
State-Changed-From-To: closed->open 
State-Changed-By: glebius 
State-Changed-When: Mon Sep 19 22:12:28 GMT 2005 
State-Changed-Why:  
Although the route(8) was changed, the kernel still returns this 
confusing EDQUOT. 


Responsible-Changed-From-To: bms->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Mon Sep 19 22:12:28 GMT 2005 
Responsible-Changed-Why:  
I am going to work in this area. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64090 
State-Changed-From-To: open->closed 
State-Changed-By: glebius 
State-Changed-When: Thu Nov 3 12:05:14 GMT 2005 
State-Changed-Why:  
Fixed in RELENG_6 and RELENG_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64090 
>Unformatted:
