From cperon@staff.seccuris.com  Tue Mar  9 10:36:27 2004
Return-Path: <cperon@staff.seccuris.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5823E16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Mar 2004 10:36:27 -0800 (PST)
Received: from staff.seccuris.com (staff.seccuris.com [204.112.0.40])
	by mx1.FreeBSD.org (Postfix) with SMTP id B8A3843D41
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Mar 2004 10:36:26 -0800 (PST)
	(envelope-from cperon@staff.seccuris.com)
Received: (qmail 36431 invoked by uid 1006); 9 Mar 2004 18:36:25 -0000
Message-Id: <20040309183625.36430.qmail@staff.seccuris.com>
Date: 9 Mar 2004 18:36:25 -0000
From: Christian S.J.Peron <maneo@bsdpro.com>
Reply-To: Christian S.J.Peron <maneo@bsdpro.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] ENSONIQ interrupt handler contains if eval with no effect
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64001
>Category:       kern
>Synopsis:       [patch] ENSONIQ interrupt handler contains if eval with no effect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 09 10:40:18 PST 2004
>Closed-Date:    Wed May 05 10:01:31 PDT 2004
>Last-Modified:  Wed May 05 10:01:31 PDT 2004
>Originator:     Christian S.J. Peron
>Release:        FreeBSD 4.8-RELEASE-p13 i386
>Organization:
>Environment:
System: FreeBSD movl 4.8-RELEASE-p13 FreeBSD 4.8-RELEASE-p13 #1: Sat Oct 25 16:45:55 UTC 2003 i@movl:/usr/src/sys/compile/STAFF i386


	
>Description:
	Although it is not that big of a deal, there is an if evaluation
	with no effect in the interrupt handler of the ENSONIQ driver.

	The semi-colon terminates the if construct.

	I have commented it out, but you may just want to delete it all together.

	
>How-To-Repeat:
	N/A
	
>Fix:


--- sys/dev/sound/pci/es137x.c.bak	Tue Mar  9 18:27:18 2004
+++ sys/dev/sound/pci/es137x.c	Tue Mar  9 18:29:22 2004
@@ -465,7 +465,7 @@
 	bus_space_write_4(es->st, es->sh, ES1370_REG_SERIAL_CONTROL, es->sctrl);
 
 	if (intsrc & STAT_ADC) chn_intr(es->rch.channel);
-	if (intsrc & STAT_DAC1);
+	/* if (intsrc & STAT_DAC1); */
 	if (intsrc & STAT_DAC2)	chn_intr(es->pch.channel);
 }
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->		 closed 
State-Changed-By: csjp 
State-Changed-When: Wed May 5 09:49:51 PDT 2004 
State-Changed-Why:  
This condition evaluation was left in the code as a reminder. 
It gets optimized out by the compiler so there is no real 
reason to remove it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64001 
>Unformatted:
