From nobody@FreeBSD.org  Tue Jan 13 23:08:26 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B8BEE16A4D0
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 23:08:26 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9C04D43D5E
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 23:08:22 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i0E78MdL098111
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 23:08:22 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i0E78MU5098110;
	Tue, 13 Jan 2004 23:08:22 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200401140708.i0E78MU5098110@www.freebsd.org>
Date: Tue, 13 Jan 2004 23:08:22 -0800 (PST)
From: Greg Juilfs <xcas@cox.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] 
X-Send-Pr-Version: www-2.0

>Number:         61349
>Category:       kern
>Synopsis:       [PATCH] Correctly identify new VIA VT8237 revid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 13 23:10:19 PST 2004
>Closed-Date:    Mon Jan 19 11:53:46 PST 2004
>Last-Modified:  Mon Jan 19 11:53:46 PST 2004
>Originator:     Greg Juilfs
>Release:        5.2-RELEASE
>Organization:
>Environment:
FreeBSD localhost.bsd-unix.org 5.2-RELEASE FreeBSD 5.2-RELEASE #0: Tue Jan 13 10:31:29 MST 2004     cas@localhost.bsd-unix.org:/usr/obj/usr/src/sys/CASX64  amd64

>Description:
I have an Athlon64 MSI K8T Neo-FISR2 motherboard that uses the VIA K8T800 & VT8237 chipsets. The problem is that this motherboard has a different revision number for it's VT8237 chipset. Which causes FreeBSD to identify it as:

atapci0: <GENERIC ATA controller> port 0xfc00-0xfc0f at device 15.0 on pci0
ata0: at 0x1f0 irq 14 on atapci0
ata1: at 0x170 irq 15 on atapci0
ad0: 114440MB <WDC WD1200JB-75CRA0> [232514/16/63] at ata0-master UDMA33
ad1: 76351MB <SAMSUNG SV8004H> [155127/16/63] at ata0-slave UDMA33
acd0: CDRW <SAMSUNG CD-R/RW SW-232B> at ata1-master PIO4
acd1: DVDROM <HL-DT-STDVD-ROM GDR8160B> at ata1-slave PIO4

After applying the patch.. it is correctly identified as:

atapci0: <VIA 8237 UDMA133 controller> port 0xfc00-0xfc0f at device 15.0 on pci0
ata0: at 0x1f0 irq 14 on atapci0
ata1: at 0x170 irq 15 on atapci0
ad0: 114440MB <WDC WD1200JB-75CRA0> [232514/16/63] at ata0-master UDMA100
ad1: 76351MB <SAMSUNG SV8004H> [155127/16/63] at ata0-slave UDMA100
acd0: CDRW <SAMSUNG CD-R/RW SW-232B> at ata1-master WDMA2
acd1: DVDROM <HL-DT-STDVD-ROM GDR8160B> at ata1-slave UDMA33

>How-To-Repeat:
      
>Fix:
Apply the following patch..

--- sys/dev/ata/ata-chipset.c.orig      Tue Jan 13 08:59:52 2004
+++ sys/dev/ata/ata-chipset.c   Tue Jan 13 08:52:19 2004
@@ -2122,6 +2122,7 @@
      { ATA_VIA8233A,  0x00, VIA133, 0x00,   ATA_UDMA6, "VIA 8233A" },
      { ATA_VIA8235,   0x00, VIA133, 0x00,   ATA_UDMA6, "VIA 8235" },
      { ATA_VIA8237,   0x00, VIA133, 0x00,   ATA_UDMA6, "VIA 8237" },
+     { ATA_VIA82C571, 0x06, VIA133, 0x00,   ATA_UDMA6, "VIA 8237" },
      { 0, 0, 0, 0, 0, 0 }};
     static struct ata_chip_id new_ids[] =
     {{ ATA_VIA8237,   0x00, 0x00,   0x00,   ATA_SA150, "VIA 8237" },

>Release-Note:
>Audit-Trail:

From: "Greg J." <xcas@cox.net>
To: freebsd-gnats-submit@FreeBSD.org, xcas@cox.net
Cc:  
Subject: Re: kern/61349: [PATCH] Correctly identify new VIA VT8237 revid
Date: Wed, 14 Jan 2004 06:12:35 -0700

 Fixed subject. My apologies.
 
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: simon 
Responsible-Changed-When: Wed Jan 14 12:15:58 PST 2004 
Responsible-Changed-Why:  
Over to ATA maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61349 
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Mon Jan 19 11:51:36 PST 2004 
State-Changed-Why:  
No, that patch is not correct, evenmy oldish VIA 686 southbridge says 
its rev6. Real patch to emerge in -current very soon. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61349 
>Unformatted:
