From leeym@utopia.leeym.com  Mon Dec 15 12:38:47 2003
Return-Path: <leeym@utopia.leeym.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1487B16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 15 Dec 2003 12:38:47 -0800 (PST)
Received: from utopia.leeym.com (utopia.leeym.com [61.218.64.93])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 82A4F43D48
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 15 Dec 2003 12:38:45 -0800 (PST)
	(envelope-from leeym@utopia.leeym.com)
Received: from localhost (localhost [127.0.0.1])
	by utopia.leeym.com (Postfix) with ESMTP id 68E643EA1B3
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Dec 2003 04:38:44 +0800 (CST)
Received: from utopia.leeym.com ([127.0.0.1])
 by localhost (utopia.leeym.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 00689-02 for <FreeBSD-gnats-submit@freebsd.org>;
 Tue, 16 Dec 2003 04:38:39 +0800 (CST)
Received: by utopia.leeym.com (Postfix, from userid 1000)
	id 153C43EA1B2; Tue, 16 Dec 2003 04:38:38 +0800 (CST)
Message-Id: <20031215203838.153C43EA1B2@utopia.leeym.com>
Date: Tue, 16 Dec 2003 04:38:38 +0800 (CST)
From: Yen-Ming Lee <leeym@utopia.leeym.com>
Reply-To: Yen-Ming Lee <leeym@utopia.leeym.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: add support for Sis 96x
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         60278
>Category:       kern
>Synopsis:       add support for Sis 96x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 15 12:40:13 PST 2003
>Closed-Date:    Fri Dec 19 21:53:18 PST 2003
>Last-Modified:  Fri Dec 19 21:53:18 PST 2003
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 5.2-RC i386
>Organization:
>Environment:
System: FreeBSD utopia.leeym.com 5.2-RC FreeBSD 5.2-RC #3: Tue Dec 16 04:18:02 CST 2003 leeym@utopia.leeym.com:/mnt3/obj/usr/src/sys/UTOPIA i386


>Description:

Sis 963L returns 0x55131039 as its PCI ID.

# pciconf -l|grep atapci
atapci0@pci0:2:5:       class=0x01018a card=0x55131039 chip=0x55131039 rev=0x00 hdr=0x00


>How-To-Repeat:

Install FreeBSD on the box with SiS 963L controller on the motherboard,
says "MSI 661FM-L" or "Asrock K7S8X"

>Fix:

	

--- ata-chipset.c.diff begins here ---
Index: ata-chipset.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v
retrieving revision 1.50
diff -u -r1.50 ata-chipset.c
--- ata-chipset.c	8 Dec 2003 09:22:20 -0000	1.50
+++ ata-chipset.c	15 Dec 2003 20:28:05 -0000
@@ -1957,10 +1957,11 @@
     if (!(idx = ata_find_chip(dev, ids, -pci_get_slot(dev)))) 
 	return ENXIO;
 
-    if (idx->cfg1 == SIS_SOUTH) {
+    if (idx->cfg1 == SIS_SOUTH || idx->cfg1 == SIS33) {
 	pci_write_config(dev, 0x57, pci_read_config(dev, 0x57, 1) & 0x7f, 1);
 	if (pci_read_config(dev, 0x00, 4) == ATA_SIS5518) {
 	    idx->cfg1 = SIS133NEW;
+	    idx->max_dma = ATA_UDMA6;
 	    sprintf(buffer, "SiS 96X %s controller",ata_mode2str(idx->max_dma));
 	}
 	else {
--- ata-chipset.c.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: leeym 
Responsible-Changed-When: Tue Dec 16 09:52:10 PST 2003 
Responsible-Changed-Why:  
Over to ATA maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60278 
State-Changed-From-To: open->feedback 
State-Changed-By: sos 
State-Changed-When: Tue Dec 16 13:01:53 PST 2003 
State-Changed-Why:  
That patch is *not* correct. 
Please mail me the output of pciconf -l from that system together 
with info on what chips is physically present (evt board vendor & type). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=60278 

From: Yen-Ming Lee <leeym@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/60278: add support for Sis 96x
Date: Wed, 17 Dec 2003 10:10:30 +0800

 --FCuugMFkClbJLl1L
 Content-Type: text/plain; charset=utf8
 Content-Disposition: inline
 Content-Transfer-Encoding: 8bit
 
 Okay..
 
 The all-in-one mainboard, MSI 661FM-L, with built-in video/audio/LAN support:
 http://www.msi.com.tw/program/products/mainboard/mbd/pro_mbd_detail.php?UID=501
 
 Northbridge: SiS 661FX
 Southbridge: SiS 963L
 
 This box is my NAT box, so I added a Intel 82559 LAN card (fxp0).
 
 The output of "pciconf -l":
 # pciconf -l
 agp0@pci0:0:0:  class=0x060000 card=0x06611039 chip=0x06611039 rev=0x11 hdr=0x00
 pcib1@pci0:1:0: class=0x060400 card=0x00000000 chip=0x00031039 rev=0x00 hdr=0x01
 isab0@pci0:2:0: class=0x060100 card=0x00000000 chip=0x00081039 rev=0x25 hdr=0x00
 atapci0@pci0:2:5:       class=0x01018a card=0x55131039 chip=0x55131039 rev=0x00 hdr=0x00
 pcm0@pci0:2:7:  class=0x040100 card=0x54011462 chip=0x70121039 rev=0xa0 hdr=0x00
 ohci0@pci0:3:0: class=0x0c0310 card=0x70011039 chip=0x70011039 rev=0x0f hdr=0x00
 ohci1@pci0:3:1: class=0x0c0310 card=0x70011039 chip=0x70011039 rev=0x0f hdr=0x00
 none0@pci0:3:3: class=0x0c0320 card=0x53321462 chip=0x70021039 rev=0x00 hdr=0x00
 sis0@pci0:4:0:  class=0x020000 card=0x540c1462 chip=0x09001039 rev=0x91 hdr=0x00
 fxp0@pci0:7:0:  class=0x020000 card=0x00098086 chip=0x12298086 rev=0x05 hdr=0x00
 none1@pci1:0:0: class=0x030000 card=0x54081462 chip=0x63301039 rev=0x00 hdr=0x00
 
 thanks and regards,
 -- 
 Yen-Ming Lee [۩] KeyID: 0x5EB52E51 : www.leeym.com : Taipei, Taiwan
 
 --FCuugMFkClbJLl1L
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.3 (FreeBSD)
 
 iQCVAwUBP9+7FsnMx0NetS5RAQFXhwQA1R9Af+dfknIxy/XL2xYNMMHNey7HoJ/o
 BZSy/qO/7gYATGgc4BFJ7lc+ETVf/8xMfkpCubu9lDFeVGXHj54nMWjWu/feiAIv
 ZJm371Ky09IQDD+nBP0tZVnQV3nRvu2AGGOD4drWTFQtWEQr1tqs07jwvfcoLjIW
 d2kT0S/TEyo=
 =csSa
 -----END PGP SIGNATURE-----
 
 --FCuugMFkClbJLl1L--
State-Changed-From-To: feedback->closed 
State-Changed-By: leeym 
State-Changed-When: Fri Dec 19 21:53:17 PST 2003 
State-Changed-Why:  
Corrented and committed by sos. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60278 
>Unformatted:
