From a.nomm@wap3.net  Thu Dec 11 07:54:53 2003
Return-Path: <a.nomm@wap3.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BED216A4CF
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Dec 2003 07:54:53 -0800 (PST)
Received: from admin2.wap3.net (admin2.wap3.net [217.110.118.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 04C8E43D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Dec 2003 07:54:50 -0800 (PST)
	(envelope-from a.nomm@wap3.net)
Received: from andrus (localhost [127.0.0.1])
	by admin2.wap3.net (8.12.5/8.12.5) with SMTP id hBBFsqOv024009
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Dec 2003 16:54:53 +0100
Message-Id: <008101c3bfff$14f43420$0100a8c0@andrus>
Date: Thu, 11 Dec 2003 17:54:37 +0200
From: "Andrus Nomm" <a.nomm@wap3.net>
To: <FreeBSD-gnats-submit@freebsd.org>
Subject: ipfw core (crash)

>Number:         60154
>Category:       kern
>Synopsis:       [ipfw] ipfw core (crash)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 11 08:00:35 PST 2003
>Closed-Date:    Sun Mar 11 12:28:15 GMT 2007
>Last-Modified:  Sun Mar 11 12:28:15 GMT 2007
>Originator:     Andrus
>Release:        FreeBSD 4.8-RELEASE-p14 i386
>Organization:
none
>Environment:
System: FreeBSD members.ee 4.8-RELEASE-p14 FreeBSD 4.8-RELEASE-p14 #17: Wed
Dec 10 19:51:46 EET 2003 root@members.ee:/usr/obj/usr/src/sys/MEMBERS-KERNEL
i386


>Description:
ipfw crash on long line
>How-To-Repeat:
ipfw add pass all from { ips } to any
if i putted there 100 ips (string length was ~2500 bytes total) ipfw crashed
and made core file
tested on 4.9, 5.0 and 5.1, samne result
>Fix:
write in manual that example 50 ips are max allowed, or give error in ipfw
"too many ips" or similar instead of crashing


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->ipfw 
Responsible-Changed-By: vs 
Responsible-Changed-When: Wed Jul 21 14:47:02 GMT 2004 
Responsible-Changed-Why:  
Assign to ipfw mailing-list 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60154 

From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: bug-followup@FreeBSD.org
Cc: a.nomm@wap3.net
Subject: Re: kern/60154: [ipfw] ipfw core (crash)
Date: Thu, 08 Dec 2005 08:58:02 +0300

 This is a multi-part message in MIME format.
 --------------080701000609020709080702
 Content-Type: text/plain; charset=KOI8-R; format=flowed
 Content-Transfer-Encoding: 7bit
 
 The following patch can fix this error for CURRENT.
 
 -- 
 WBR, Andrey V. Elsukov
 
 --------------080701000609020709080702
 Content-Type: text/plain;
  name="pr-60154.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="pr-60154.diff"
 
 --- ipfw2.c.orig	Thu Dec  8 01:51:14 2005
 +++ ipfw2.c	Thu Dec  8 01:54:59 2005
 @@ -2641,6 +2641,14 @@
  	int masklen;
  	char md;
  
 +	if (len > 30) {
 +		/* 
 +		 * O_IP_SRC_MASK and O_IP_DST_MASK can't have length
 +		 * greater than 31 
 +		 */
 +		errx(EX_DATAERR, "too many addresses");
 +	}
 +	
  	if (p) {
  		md = *p;
  		*p++ = '\0';
 
 --------------080701000609020709080702--
 
Responsible-Changed-From-To: freebsd-ipfw->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Thu Dec 8 06:26:32 GMT 2005 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=60154 

From: Maxim Konovalov <maxim@macomnet.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: kern/60154
Date: Thu, 8 Dec 2005 09:29:13 +0300 (MSK)

 GNANTS still scares me.
 
 I promised to Andrey I commit the fix if it suits me so assign the PR
 to me.
 
 -- 
 Maxim Konovalov
Responsible-Changed-From-To: maxim->freebsd-bugs 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Fri Jul 28 16:35:08 UTC 2006 
Responsible-Changed-Why:  
Return to the pool since neither me or submitter have an interest 
to finish the work. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60154 
State-Changed-From-To: open->closed 
State-Changed-By: remko 
State-Changed-When: Sun Mar 11 12:28:13 UTC 2007 
State-Changed-Why:  
if nobody has an interest in resolving this, then dont pretend / act 
like we will. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60154 
>Unformatted:
