From root@Vitsch.net  Fri Nov 14 07:08:26 2003
Return-Path: <root@Vitsch.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2AED216A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Nov 2003 07:08:26 -0800 (PST)
Received: from Vitsch.net (b74143.upc-b.chello.nl [212.83.74.143])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3B15143FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Nov 2003 07:08:24 -0800 (PST)
	(envelope-from root@Vitsch.net)
Received: (from root@localhost)
	by Danovitsch.dnsq.org (8.12.3p2/8.11.3) id hADF2x3a089396;
	Thu, 13 Nov 2003 16:02:59 +0100 (CET)
	(envelope-from root)
Message-Id: <200311131502.hADF2x3a089396@Danovitsch.dnsq.org>
Date: Thu, 13 Nov 2003 16:02:59 +0100 (CET)
From: "Daan Vreeken [PA4DAN]" <Danovitsch@Vitsch.net>
Reply-To: "Daan Vreeken [PA4DAN]" <Danovitsch@Vitsch.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATH] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59289
>Category:       kern
>Synopsis:       [bktr] [patch] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 14 07:10:12 PST 2003
>Closed-Date:    
>Last-Modified:  Thu Nov 04 08:22:29 GMT 2004
>Originator:     Daan Vreeken [PA4DAN]
>Release:        FreeBSD 5.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD RaceBeest.Danovitsch.LAN 5.1-RELEASE FreeBSD 5.1-RELEASE #20: Mon Sep 1 16:39:56 CEST 2003 root@RaceBeest.Danovitsch.LAN:/home/src/sys/i386/compile/RaceBeest i386

>Description:
In bktr_core.c the ioctl METEORSBRIG substracts 128 from the given value
before storing it in the right brightness register, but METEORGBRIG doesn't
add 128 to the value it gets out of the register.

>How-To-Repeat:
wantedvalue=129;
ioctl(bktr,METEORSBRIG,&wantedvalue);
ioctl(bktr,METEORGBRIG,&returnedvalue);

if (returnedvalue!=wantedvalue)
        printf("EEK!\n");

>Fix:
The following patch is agains -CURRENT and simply adds +128 to the value
that's read from the register.

--- diff begins here ---
diff -ur sys-org/dev/bktr/bktr_core.c sys/dev/bktr/bktr_core.c
--- sys-org/dev/bktr/bktr_core.c	Sun Nov  9 10:17:21 2003
+++ sys/dev/bktr/bktr_core.c	Thu Nov 13 15:38:57 2003
@@ -1511,7 +1511,7 @@
 		break;
 
 	case METEORGBRIG:	/* get brightness */
-		*(u_char *)arg = INB(bktr, BKTR_BRIGHT);
+		*(u_char *)arg = INB(bktr, BKTR_BRIGHT) + 128;
 		break;
 
 	case METEORSCSAT:	/* set chroma saturation */
--- diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->roger 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Aug 31 00:09:35 GMT 2004 
Responsible-Changed-Why:  
Over to bktr maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59289 
Responsible-Changed-From-To: roger->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Nov 4 08:22:19 GMT 2004 
Responsible-Changed-Why:  
Assignee is currently away from doing FreeBSD work at the moment, so 
at his request, return this one to the pool. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59289 
>Unformatted:
