From root@monger.x256.com  Tue Nov 11 22:52:30 2003
Return-Path: <root@monger.x256.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E7C4416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 22:52:30 -0800 (PST)
Received: from monger.x256.com (d64-180-80-190.bchsia.telus.net [64.180.80.190])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F2B0243FD7
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 22:52:29 -0800 (PST)
	(envelope-from root@monger.x256.com)
Received: from monger.x256.com (localhost.x256.com [127.0.0.1])
	by monger.x256.com (8.12.9/8.12.9) with ESMTP id hABN2VDS000800
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 15:02:31 -0800 (PST)
	(envelope-from root@monger.x256.com)
Received: (from root@localhost)
	by monger.x256.com (8.12.9/8.12.9/Submit) id hABN2VO1000799;
	Tue, 11 Nov 2003 15:02:31 -0800 (PST)
Message-Id: <200311112302.hABN2VO1000799@monger.x256.com>
Date: Tue, 11 Nov 2003 15:02:31 -0800 (PST)
From: "hb@freebsd.x256.org &" <root@monger.x256.com>
Reply-To: "hb@freebsd.x256.org &" <root@monger.x256.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: vinum doesn't check whether strip size is non-0 for raid5
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59205
>Category:       kern
>Synopsis:       vinum doesn't check whether strip size is non-0 for raid5
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    le
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 11 23:00:37 PST 2003
>Closed-Date:    Mon May 17 11:06:13 PDT 2004
>Last-Modified:  Mon May 17 11:06:13 PDT 2004
>Originator:     Nicholas Vinen &
>Release:        FreeBSD 5.1-RELEASE i386
>Organization:
None
>Environment:
System: FreeBSD monger.x256.com 5.1-RELEASE FreeBSD 5.1-RELEASE #2: Tue Nov 11 08:53:36 PST 2003 root@monger.x256.com:/usr/src/sys/i386/compile/MONGER i386


	
>Description:
	If no stripe size is specified for a raid5 plex in vinum, the default seems to be set at 0. This causes the machine to crash/reboot when any data is written to the volume which contains the plex.
	
>How-To-Repeat:


drive d1 device /dev/ad4s1a
drive d2 device /dev/ad6s1a
drive d3 device /dev/ad8s1a
drive d4 device /dev/ad10s1a
drive d5 device /dev/ad12s1a
drive d6 device /dev/ad14s1a
drive d7 device /dev/ad16s1a
drive d8 device /dev/ad18s1a

volume raid setupstate
 plex org raid5
   sd length 1000m drive d1
   sd length 1000m drive d2
   sd length 1000m drive d3
   sd length 1000m drive d4
   sd length 1000m drive d5
   sd length 1000m drive d6
   sd length 1000m drive d7
   sd length 1000m drive d8

 or something like that....
 then "vinum create foo" and "newfs /dev/vinum/raid"
>Fix:
	vinum probably shouldn't let one create a plex using raid5 without a sensible stripe size (positive, and greater than or equal to 1k say). Also the kernel should check, not just the user space program.
	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->grog 
Responsible-Changed-By: kris 
Responsible-Changed-When: Wed Nov 12 00:52:06 PST 2003 
Responsible-Changed-Why:  
Assign to vinum author 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59205 
State-Changed-From-To: open->feedback 
State-Changed-By: le 
State-Changed-When: Sun Feb 8 07:33:12 PST 2004 
State-Changed-Why:  
Steal this PR from grog@, since I have probably committed a fix 
for this problem. 


Responsible-Changed-From-To: grog->le 
Responsible-Changed-By: le 
Responsible-Changed-When: Sun Feb 8 07:33:12 PST 2004 
Responsible-Changed-Why:  
Steal this PR from grog@, since I have probably committed a fix 
for this problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59205 

From: Lukas Ertl <l.ertl@univie.ac.at>
To: freebsd-gnats-submit@FreeBSD.org, root@monger.x256.com
Cc:  
Subject: Re: kern/59205: vinum doesn't check whether strip size is non-0 for
 raid5
Date: Sun, 8 Feb 2004 16:32:36 +0100 (CET)

 > If no stripe size is specified for a raid5 plex in vinum, the default
 > seems to be set at 0. This causes the machine to crash/reboot when any
 > data is written to the volume which contains the plex.
 
 I have committed a few fixes just recently that should address this
 problem, could you please try to cvsup to -CURRENT and try again?
 
 regards,
 le
 
 -- 
 Lukas Ertl                             eMail: l.ertl@univie.ac.at
 UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
 Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
 University of Vienna                   http://mailbox.univie.ac.at/~le/
State-Changed-From-To: feedback->closed 
State-Changed-By: le 
State-Changed-When: Mon May 17 11:05:52 PDT 2004 
State-Changed-Why:  
Assume that this bug is fixed with my commit. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59205 
>Unformatted:
