From mlaier@vampire.homelinux.org  Sat Oct 25 12:58:10 2003
Return-Path: <mlaier@vampire.homelinux.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B935216A4B3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 25 Oct 2003 12:58:10 -0700 (PDT)
Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.184])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6380643FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 25 Oct 2003 12:58:09 -0700 (PDT)
	(envelope-from mlaier@vampire.homelinux.org)
Received: from [212.227.126.161] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1ADUY4-0006MA-00
	for FreeBSD-gnats-submit@freebsd.org; Sat, 25 Oct 2003 21:58:08 +0200
Received: from [217.227.144.164] (helo=vampire.homelinux.org)
	by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1)
	id 1ADUY4-0001Cs-00
	for FreeBSD-gnats-submit@freebsd.org; Sat, 25 Oct 2003 21:58:08 +0200
Received: (qmail 85337 invoked by uid 1001); 25 Oct 2003 20:01:10 -0000
Message-Id: <20031025200110.85336.qmail@vampire.homelinux.org>
Date: 25 Oct 2003 20:01:10 -0000
From: Max Laier <max@love2party.net>
Reply-To: Max Laier <max@love2party.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: netinet/if_ethersubr.c rev. 1.117+
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         58537
>Category:       kern
>Synopsis:       netinet/if_ethersubr.c rev. 1.117+
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 25 13:00:32 PDT 2003
>Closed-Date:    Thu Oct 30 09:52:30 PST 2003
>Last-Modified:  Thu Oct 30 09:52:30 PST 2003
>Originator:     Max Laier
>Release:        FreeBSD 5.1-RELEASE-p10 i386
>Organization:
>Environment:
System: FreeBSD router.laiers.local 5.1-RELEASE-p10 FreeBSD 5.1-RELEASE-p10 #1: Sun Oct 5 17:38:55 CEST 2003 root@router.laiers.local:/usr/obj/usr/src/sys/ALTQ i386


	
>Description:
	The check if an ethernet packet is for the device it was recieved on
	was made disfunctional with rev. 1.117:
	if ((exp) != 0 && ... && (exp) == 0) is always FALSE!
	where exp here is: (ifp->if_flags & IFF_PROMISC)
>How-To-Repeat:
	Not sure, seems to work okay without that extra sanity check.
>Fix:
	Patch (remove unwanted part):

--- if_ethersubr.c.diff begins here ---
--- if_ethersubr.c.orig	Sat Oct 25 21:52:36 2003
+++ if_ethersubr.c	Sat Oct 25 21:54:15 2003
@@ -638,8 +638,7 @@
 		if ((ifp->if_flags & IFF_PROMISC) != 0
 		    && (eh->ether_dhost[0] & 1) == 0
 		    && bcmp(eh->ether_dhost,
-		      IFP2AC(ifp)->ac_enaddr, ETHER_ADDR_LEN) != 0
-		    && (ifp->if_flags & IFF_PPROMISC) == 0) {
+		      IFP2AC(ifp)->ac_enaddr, ETHER_ADDR_LEN) != 0) {
 			    m_freem(m);
 			    return;
 		}
--- if_ethersubr.c.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Max Laier <max@love2party.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/58537: netinet/if_ethersubr.c rev. 1.117+
Date: Sat, 25 Oct 2003 22:08:43 +0200

 Ooops! There is a second "P" ... please forget what I just claimed,
 it's wrong! Sorry, for the confusion! (IFF_PROMISC != IFF_PPROMISC)
 
 Max(*hides*)
 
State-Changed-From-To: open->closed 
State-Changed-By: kris 
State-Changed-When: Thu Oct 30 09:52:18 PST 2003 
State-Changed-Why:  
Closed at submitter request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58537 
>Unformatted:
