From andy@fud.org.nz  Sat Sep 20 17:33:04 2003
Return-Path: <andy@fud.org.nz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8BA5A16A4B3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 20 Sep 2003 17:33:04 -0700 (PDT)
Received: from smtp.fud.org.nz (203-79-110-29.cable.paradise.net.nz [203.79.110.29])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A9B3743FE3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 20 Sep 2003 17:33:01 -0700 (PDT)
	(envelope-from andy@fud.org.nz)
Received: from localhost (localhost [127.0.0.1])
	by smtp.fud.org.nz (Postfix) with ESMTP id 7662D5C72
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 21 Sep 2003 12:33:00 +1200 (NZST)
Received: from smtp.fud.org.nz ([127.0.0.1])
 by localhost (grace.fud.org.nz [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 35250-10 for <FreeBSD-gnats-submit@freebsd.org>;
 Sun, 21 Sep 2003 12:33:00 +1200 (NZST)
Received: by smtp.fud.org.nz (Postfix, from userid 1001)
	id 1776A5C6E; Sun, 21 Sep 2003 12:33:00 +1200 (NZST)
Message-Id: <20030921003300.1776A5C6E@smtp.fud.org.nz>
Date: Sun, 21 Sep 2003 12:33:00 +1200 (NZST)
From: Andrew Thompson <andy@fud.org.nz>
Reply-To: Andrew Thompson <andy@fud.org.nz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Add usb quirk for Sigmatel USB Flash MP3 Player
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         57046
>Category:       kern
>Synopsis:       Add usb quirk for Sigmatel USB Flash MP3 Player
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    njl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 20 17:40:18 PDT 2003
>Closed-Date:    Sun Apr 18 21:16:21 PDT 2004
>Last-Modified:  Sun Apr 18 21:16:21 PDT 2004
>Originator:     Andrew Thompson
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD grace.fud.org.nz 5.1-CURRENT FreeBSD 5.1-CURRENT #1: Fri Sep 19 10:42:47 NZST 2003 andy@grace.fud.org.nz:/usr/obj/usr/src/sys/GRACE i386


	
>Description:
	Add the usb quirk for the Sigmatel USB Flash MP3 Player as discussed with Nate on -current	
>How-To-Repeat:
	Without the patch the unit will not work and get umass errors.

	umass0: SigmaTel, Inc. USBMSC Audio Player, rev 1.10/0.01, addr 3
	umass0: Get Max Lun not supported (IOERROR)
	da0 at umass-sim0 bus 0 target 0 lun 0
	da0: <SigmaTel MSCN 0001> Removable Direct Access SCSI-4 device
	da0: 1.000MB/s transfers
	da0: 125MB (256001 512 byte sectors: 64H 32S/T 125C)
	umass0: BBB reset failed, IOERROR
	umass0: BBB bulk-in clear stall failed, IOERROR
	umass0: BBB bulk-out clear stall failed, IOERROR
	umass0: BBB reset failed, IOERROR
	umass0: BBB bulk-in clear stall failed, IOERROR
	umass0: BBB bulk-out clear stall failed, IOERROR

>Fix:

	Please apply quirk:


--- sys/cam/scsi/scsi_da.c.orig Sun Sep 21 12:26:38 2003
+++ sys/cam/scsi/scsi_da.c      Sun Sep 21 12:28:23 2003
@@ -375,6 +375,13 @@
                {T_DIRECT, SIP_MEDIA_REMOVABLE, "CREATIVE", "NOMAD_MUVO", "*"},
                /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
        },
+       {
+               /*
+                * Sigmatel USB Flash MP3 Player
+                */
+               {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel", "MSCN", "*"},
+               /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
+       }, 
 };
 
 static disk_strategy_t dastrategy;



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->joe 
Responsible-Changed-By: kris 
Responsible-Changed-When: Wed Oct 8 15:10:52 PDT 2003 
Responsible-Changed-Why:  
Assign to USB maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57046 
Responsible-Changed-From-To: joe->njl 
Responsible-Changed-By: njl 
Responsible-Changed-When: Wed Oct 29 12:38:12 PST 2003 
Responsible-Changed-Why:  
I'm handling umass quirks atm. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57046 

From: Andrew Thompson <andy@fud.org.nz>
To: freebsd-gnats-submit@FreeBSD.org, andy@fud.org.nz
Cc:  
Subject: Re: kern/57046: Add usb quirk for Sigmatel USB Flash MP3 Player
Date: Tue, 3 Feb 2004 08:02:23 +1300

 I no longer own this item. The PR can be closed.
State-Changed-From-To: open->closed 
State-Changed-By: njl 
State-Changed-When: Sun Apr 18 21:16:11 PDT 2004 
State-Changed-Why:  
Committed and will hopefully make it into 4.10.  Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=57046 
>Unformatted:
