From roth@secure.socket.ch  Wed Aug 13 02:43:00 2003
Return-Path: <roth@secure.socket.ch>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0BBCD37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Aug 2003 02:43:00 -0700 (PDT)
Received: from secure.socket.ch (secure.socket.ch [212.254.206.213])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B65DC43FD7
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Aug 2003 02:42:58 -0700 (PDT)
	(envelope-from roth@secure.socket.ch)
Received: from secure.socket.ch (localhost [127.0.0.1])
	by secure.socket.ch (8.12.9/8.12.5) with ESMTP id h7D9dVa2028012
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Aug 2003 11:39:31 +0200 (CEST)
	(envelope-from roth@secure.socket.ch)
Received: (from roth@localhost)
	by secure.socket.ch (8.12.9/8.12.5/Submit) id h7D9dPsu028011;
	Wed, 13 Aug 2003 11:39:25 +0200 (CEST)
Message-Id: <200308130939.h7D9dPsu028011@secure.socket.ch>
Date: Wed, 13 Aug 2003 11:39:25 +0200 (CEST)
From: Tobias Roth <ports@fsck.ch>
Reply-To: Tobias Roth <ports@fsck.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] include missing in dev/usb/usbdivar.h (current)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         55535
>Category:       kern
>Synopsis:       [patch] include missing in dev/usb/usbdivar.h (current)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jmg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 13 02:50:18 PDT 2003
>Closed-Date:    Mon Aug 18 01:21:01 PDT 2003
>Last-Modified:  Mon Aug 18 01:21:01 PDT 2003
>Originator:     Tobias Roth <ports@fsck.ch>
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD angel-one.fsck.ch 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Tue Aug 12 15:02:35 CEST 2003 roth@angel-one.fsck.ch:/usr/obj/usr/src/sys/ANGEL-ONE i386

>Description:
	With the last cvs commit of usbdivar.h (1.39 to 1.40), bus_dma
        awareness was added. But an #include seems to have been forgotten,
        resulting in a syntax error when including usbdivar.h.
>How-To-Repeat:
        Compile anything that includes dev/usb/usbdivar.h, for example
        Maksim Evmenkins Bluetooth stack.
>Fix:
        The patch below fixes things for me, however I have no idea
        if this is the correct way to fix thing or if it breaks something
        else. Someone with more insight please review it and take
        appropriate measures.


        --- /usr/src/sys/dev/usb/usbdivar.h     Wed Aug 13 11:25:50 2003
        +++ sys/dev/usb/usbdivar.h      Wed Aug 13 11:07:38 2003
        @@ -42,6 +42,8 @@
         #include <sys/callout.h>
         #endif
         
        +#include <machine/bus.h>
        +
         /* From usb_mem.h */
          DECLARE_USB_DMA_T;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jmg 
Responsible-Changed-By: joe 
Responsible-Changed-When: Fri Aug 15 05:25:50 PDT 2003 
Responsible-Changed-Why:  
Hand this PR over to John-Mark.  Would you mind committing this if it makes 
sense?  Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55535 
State-Changed-From-To: open->feedback 
State-Changed-By: jmg 
State-Changed-When: Sat Aug 16 10:48:44 PDT 2003 
State-Changed-Why:  
why can't the broken software simply include the file itself.  We 
are suppose to try to eliminate header files from including other 
header files.. 

Also, as far as I know, all code in the FreeBSD source tree builds 
fine, what software doesn't? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55535 

From: Tobias Roth <roth@fsck.ch>
To: John-Mark Gurney <jmg@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/55535: [patch] include missing in dev/usb/usbdivar.h (current)
Date: Mon, 18 Aug 2003 10:10:31 +0200

 On Sat, Aug 16, 2003 at 10:50:59AM -0700, John-Mark Gurney wrote:
 > Synopsis: [patch] include missing in dev/usb/usbdivar.h (current)
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: jmg
 > State-Changed-When: Sat Aug 16 10:48:44 PDT 2003
 > State-Changed-Why: 
 > why can't the broken software simply include the file itself.  We
 > are suppose to try to eliminate header files from including other
 > header files..
 > 
 > Also, as far as I know, all code in the FreeBSD source tree builds
 > fine, what software doesn't?
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=55535
 
 my mistake. the problem was not in the FreeBSD source (it was but has
 already been fixed some time ago), but with some additional softeware.
 Author has been notified, pr can be closed.
 
 thx
State-Changed-From-To: feedback->closed 
State-Changed-By: jmg 
State-Changed-When: Mon Aug 18 01:20:31 PDT 2003 
State-Changed-Why:  
submitter says it can be closed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55535 
>Unformatted:
