From mitya@mitya.mitya.static.dol.ru  Sat Jul 26 05:27:43 2003
Return-Path: <mitya@mitya.mitya.static.dol.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A4E2337B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2003 05:27:43 -0700 (PDT)
Received: from mitya.mitya.static.dol.ru (mitya.mitya.static.dol.ru [194.87.5.172])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7C04E43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2003 05:27:40 -0700 (PDT)
	(envelope-from mitya@mitya.mitya.static.dol.ru)
Received: from mitya.mitya.static.dol.ru (localhost [127.0.0.1])
	by mitya.mitya.static.dol.ru (8.12.9/8.12.9) with ESMTP id h6QCReS5000643
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2003 16:27:41 +0400 (MSD)
	(envelope-from mitya@mitya.mitya.static.dol.ru)
Received: (from mitya@localhost)
	by mitya.mitya.static.dol.ru (8.12.9/8.12.9/Submit) id h6QCRd2a000642;
	Sat, 26 Jul 2003 16:27:39 +0400 (MSD)
Message-Id: <200307261227.h6QCRd2a000642@mitya.mitya.static.dol.ru>
Date: Sat, 26 Jul 2003 16:27:39 +0400 (MSD)
From: Dmitry Sivachenko <mitya@demos.su>
Reply-To: Dmitry Sivachenko <mitya@demos.su>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: New device/vendor ID and quirks for iRiver iFP MP3 player
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         54881
>Category:       kern
>Synopsis:       QUIRK: New device/vendor ID and quirks for iRiver iFP MP3 player
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    njl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 26 05:30:17 PDT 2003
>Closed-Date:    Wed Aug 11 16:46:22 GMT 2004
>Last-Modified:  Wed Aug 11 16:46:22 GMT 2004
>Originator:     Dmitry Sivachenko
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD mitya.mitya.static.dol.ru 5.1-CURRENT FreeBSD 5.1-CURRENT #2: Sat Jul 26 16:14:38 MSD 2003 mitya@mitya.mitya.static.dol.ru:/usr/src/sys/i386/compile/CAVIA i386


	
>Description:

Vendor/device IDs for iRiver iFP USB MP3 player are not present in usbdevs file.
Also this device needs quirks to work properly.

>How-To-Repeat:

Plug in iRiver iFP MP3 player and boot the machine.

During boot you'll see:

da1 at umass-sim1 bus 1 target 0 lun 0
da1: <iRiver iFP Mass Driver 1.00> Removable Direct Access SCSI-0 device 
da1: 1.000MB/s transfers
da1: 250MB (512000 512 byte sectors: 64H 32S/T 250C)
(da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE. CDB: 35 0 0 0 0 0 0 0 0 0 
(da1:umass-sim1:1:0:0): UNIT ATTENTION asc:29,0
(da1:umass-sim1:1:0:0): Power on, reset, or bus device reset occurred
(da1:umass-sim1:1:0:0): SYNCHRONIZE CACHE. CDB: 35 0 0 0 0 0 0 0 0 0 
(da1:umass-sim1:1:0:0): UNIT ATTENTION asc:29,0
(da1:umass-sim1:1:0:0): Power on, reset, or bus device reset occurred


Relevant information:

# camcontrol inquiry da0
pass0: <iRiver iFP Mass Driver 1.00> Removable Direct Access SCSI-0 device
pass0: Serial Number u
pass0: 1.000MB/s transfers

# usbdevs -v
<snip>
Controller /dev/usb2:
addr 1: full speed, self powered, config 1, UHCI root hub(0x0000), VIA(0x0000),
rev 1.00
 port 1 addr 2: full speed, self powered, config 1, iFP Mass Driver(0x1103), iRi
ver(0x4102), rev 1.00
 port 2 powered

After the following patch applied, during boot you'll see:

umass0: iRiver iFP Mass Driver, rev 1.10/1.00, addr 2
umass0: Get Max Lun not supported (STALLED)
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <iRiver iFP Mass Driver 1.00> Removable Direct Access SCSI-0 device
da0: 1.000MB/s transfers
da0: 250MB (512000 512 byte sectors: 64H 32S/T 250C)

and device appears to work correctly.

>Fix:


--- usbdevs.old	Sat Jul 19 14:28:24 2003
+++ usbdevs	Sat Jul 26 15:38:08 2003
@@ -359,6 +359,7 @@
 vendor ACTIONTEC	0x1668	Actiontec Electronics
 vendor DLINK		0x2001	D-Link
 vendor DAISY		0x3579	Daisy Technology
+vendor IRIVER		0x4102	iRiver
 vendor INTEL		0x8086	Intel
 vendor HP2		0xf003	Hewlett Packard
 
@@ -736,6 +737,9 @@
 /* Iomega products */
 product IOMEGA ZIP100		0x0001	Zip 100
 product IOMEGA ZIP250		0x0030	Zip 250
+
+/* iRiver products */
+product	IRIVER IFP		0x1103	iFP Mass Driver
 
 /* JVC products */
 product	JVC GR_DX95		0x000a	GR-DX95




--- scsi_da.c.orig	Sat Jul 26 16:01:23 2003
+++ scsi_da.c	Sat Jul 26 16:14:22 2003
@@ -516,6 +516,13 @@
 		 */
 		{T_DIRECT, SIP_MEDIA_REMOVABLE, "OTi", "Flash Disk", "*"},
 		/*quirks*/ DA_Q_NO_6_BYTE
+	},
+	{
+		/*
+		 * iRiver iFP MP3 player (with UMS Firmware)
+		 */
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "iRiver", "iFP*", "*"},
+		/*quirks*/ DA_Q_NO_SYNC_CACHE
 	}
 };
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->njl 
Responsible-Changed-By: njl 
Responsible-Changed-When: Thu Aug 21 21:54:53 PDT 2003 
Responsible-Changed-Why:  
Is there a problem or is it just the error messages?  I dont' see any 
errors here (say when you try to mount the camera's partition). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54881 
State-Changed-From-To: open->patched 
State-Changed-By: sanpei 
State-Changed-When: Sun Aug 8 09:08:55 GMT 2004 
State-Changed-Why:  
Committed scsi_da.c rev. 1.170 
Thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54881 
State-Changed-From-To: patched->closed 
State-Changed-By: njl 
State-Changed-When: Wed Aug 11 16:46:05 GMT 2004 
State-Changed-Why:  
Patch committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54881 
>Unformatted:
