From richard@mail.unixguru.nl  Sun Jun  8 14:28:41 2003
Return-Path: <richard@mail.unixguru.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2424F37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jun 2003 14:28:41 -0700 (PDT)
Received: from mail.unixguru.nl (mosibi.demon.nl [212.238.240.209])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 022F643FCB
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jun 2003 14:28:40 -0700 (PDT)
	(envelope-from richard@mail.unixguru.nl)
Received: from mail.unixguru.nl (localhost [127.0.0.1])
	by mail.unixguru.nl (8.12.9/8.12.9) with ESMTP id h58LRvpV062560
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 8 Jun 2003 23:27:59 +0200 (CEST)
	(envelope-from richard@mail.unixguru.nl)
Received: (from richard@localhost)
	by mail.unixguru.nl (8.12.9/8.12.9/Submit) id h58LRvuf062559;
	Sun, 8 Jun 2003 23:27:57 +0200 (CEST)
	(envelope-from richard)
Message-Id: <200306082127.h58LRvuf062559@mail.unixguru.nl>
Date: Sun, 8 Jun 2003 23:27:57 +0200 (CEST)
From: Richard Arends <richard@unixguru.nl>
Reply-To: Richard Arends <richard@unixguru.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Add support for the PQI USB Flash Disk
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         53067
>Category:       kern
>Synopsis:       Add support for the PQI USB Flash Disk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    njl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 08 14:30:17 PDT 2003
>Closed-Date:    Sun Apr 18 21:15:33 PDT 2004
>Last-Modified:  Sun Apr 18 21:15:33 PDT 2004
>Originator:     Richard Arends
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Unixguru.nl
>Environment:
System: FreeBSD snowlap.unixguru.nl 5.1-CURRENT FreeBSD 5.1-CURRENT #24: Sun Jun  8 22:44:02 CEST 2003  root@snowlap.unixguru.nl:/usr/obj/usr/src/sys/SNOWLAP  i386


	
>Description:
	The PQI USB Flash Disk needs DA_Q_NO_6_BYTE and DA_Q_NO_SYNC_CACHE quirks
>How-To-Repeat:
	
>Fix:

	--- scsi_da.c.orig	Sun Jun  8 22:28:15 2003
	+++ scsi_da.c		Sun Jun  8 22:26:37 2003
	@@ -507,6 +507,14 @@
	 		 */
	 		{T_DIRECT, SIP_MEDIA_REMOVABLE, "OTi", "Flash Disk", "*"},
	 		/*quirks*/ DA_Q_NO_6_BYTE
	+	},
	+	{
	+		/*
	+		 * Power Quotient International, Inc. (PQI) USB Traveling Disk USB1.1
	+		 * Drive does not like cache sync or 6 byte commands.
	+		 */
	+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic*", "USB Flash Disk*", "*"},
	+		/*quirks*/ DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE
	 	}
	 };
 

>Release-Note:
>Audit-Trail:

From: Nate Lawson <nate@root.org>
To: Richard Arends <richard@unixguru.nl>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/53067: Add support for the PQI USB Flash Disk
Date: Tue, 1 Jul 2003 13:27:52 -0700 (PDT)

 On Sun, 29 Jun 2003, Richard Arends wrote:
 > Sorry for sending you mail directly. 3 weeks ago I send in a patch for the
 > device mentioned in the subject. If I look in the CVS tree, I see that you
 > commit the most of this quirks.
 
 Thanks for pointing this out to me.  Please have a look at
 http://root.org/~nate/freebsd/quirks.html and submit the information there
 for the record.  (To do that, just hit reply-all to this message).  I'll
 look into this shortly although I'm working on some pressing ACPI issues
 right now and haven't had as much time for quirks.
 
 -Nate

From: Richard Arends <richard@unixguru.nl>
To: Nate Lawson <nate@root.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/53067: Add support for the PQI USB Flash Disk
Date: Wed, 9 Jul 2003 13:44:43 +0200 (CEST)

 On Tue, 1 Jul 2003, Nate Lawson wrote:
 
 > Thanks for pointing this out to me.  Please have a look at
 > http://root.org/~nate/freebsd/quirks.html and submit the information there
 > for the record.  (To do that, just hit reply-all to this message).  I'll
 > look into this shortly although I'm working on some pressing ACPI issues
 > right now and haven't had as much time for quirks.
 
 Sorry for the late answer (very busy), but here's the info:
 
 camcontrol inquiry da0:
 pass0: <Generic USB Flash Disk 1.00> Removable Direct Access SCSI-0 device
 pass0: Serial Number
 pass0: 1.000MB/s transfers
 
 Manufacturer name: Power Quotient International, Inc. (PQI)
 
 Model number: USB Traveling Disk USB1.1
 
 Transport type: USB
 
 Output from dmesg for failed attach attempts:
 Copyright (c) 1992-2003 The FreeBSD Project.
 Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
 	The Regents of the University of California. All rights reserved.
 FreeBSD 5.1-CURRENT #29: Mon Jun 30 00:05:36 CEST 2003
     root@snowlap.unixguru.nl:/usr/obj/usr/src/sys/SNOWLAP
 Preloaded elf kernel "/boot/kernel/kernel" at 0xc0562000.
 Preloaded elf module "/boot/kernel/acpi.ko" at 0xc05622e4.
 Timecounter "i8254"  frequency 1193182 Hz
 Timecounter "TSC"  frequency 797578840 Hz
 CPU: Intel Pentium III (797.58-MHz 686-class CPU)
   Origin = "GenuineIntel"  Id = 0x686  Stepping = 6
   Features=0x383f9ff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,SSE>
 real memory  = 401997824 (383 MB)
 avail memory = 384561152 (366 MB)
 Pentium Pro MTRR support enabled
 npx0: <math processor> on motherboard
 npx0: INT 16 interface
 acpi0: <TOSHIB 750     > on motherboard
 pcibios: BIOS version 2.10
 Using $PIR table, 7 entries at 0xc00f01c0
 acpi0: power button is handled as a fixed feature programming model.
 Timecounter "ACPI-safe"  frequency 3579545 Hz
 acpi_timer0: <24-bit timer at 3.579545MHz> port 0xee08-0xee0b on acpi0
 acpi_cpu0: <CPU> port 0x530-0x537 on acpi0
 acpi_tz0: <thermal zone> port 0x530-0x537 on acpi0
 pcib0: <ACPI Host-PCI bridge> port 0xcf8-0xcff on acpi0
 pci0: <ACPI PCI bus> on pcib0
 pcib0: slot 31 INTD is routed to irq 11
 pcib0: slot 31 INTC is routed to irq 11
 pcib0: slot 31 INTB is routed to irq 11
 pcib0: slot 31 INTB is routed to irq 11
 agp0: <Intel 82815 (i815 GMCH) host to PCI bridge> mem 0xf0000000-0xf3ffffff at device 0.0 on pci0
 pcib1: <ACPI PCI-PCI bridge> at device 1.0 on pci0
 pci1: <ACPI PCI bus> on pcib1
 pcib1: slot 0 INTA is routed to irq 11
 pci1: <display, VGA> at device 0.0 (no driver attached)
 pcib2: <ACPI PCI-PCI bridge> at device 30.0 on pci0
 pci2: <ACPI PCI bus> on pcib2
 pcib2: slot 8 INTA is routed to irq 11
 fxp0: <Intel 82801BA/CAM (ICH2/3) Pro/100 Ethernet> port 0xdf40-0xdf7f mem 0xf7dff000-0xf7dfffff irq 11 at device 8.0 on pci2
 fxp0: Ethernet address 00:00:39:be:6a:32
 miibus0: <MII bus> on fxp0
 inphy0: <i82562ET 10/100 media interface> on miibus0
 inphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
 cbb0: <TI1410 PCI-CardBus Bridge> at device 12.0 on pci2
 cardbus0: <CardBus bus> on cbb0
 pccard0: <16-bit PCCard bus> on cbb0
 pcib2: slot 12 INTA is routed to irq 11
 cbb1: <ToPIC100 PCI-CardBus Bridge> at device 13.0 on pci2
 cardbus1: <CardBus bus> on cbb1
 pccard1: <16-bit PCCard bus> on cbb1
 pcib2: slot 13 INTA is routed to irq 11
 cbb2: <ToPIC100 PCI-CardBus Bridge> at device 13.1 on pci2
 cardbus2: <CardBus bus> on cbb2
 pccard2: <16-bit PCCard bus> on cbb2
 pcib2: slot 13 INTB is routed to irq 11
 isab0: <PCI-ISA bridge> at device 31.0 on pci0
 isa0: <ISA bus> on isab0
 atapci0: <Intel ICH2 UDMA100 controller> port 0xcff0-0xcfff at device 31.1 on pci0
 ata0: at 0x1f0 irq 14 on atapci0
 ata1: at 0x170 irq 15 on atapci0
 uhci0: <Intel 82801BA/BAM (ICH2) USB controller USB-A> port 0xcf80-0xcf9f irq 11 at device 31.2 on pci0
 usb0: <Intel 82801BA/BAM (ICH2) USB controller USB-A> on uhci0
 usb0: USB revision 1.0
 uhub0: Intel UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
 uhub0: 2 ports with 2 removable, self powered
 uhci1: <Intel 82801BA/BAM (ICH2) USB controller USB-B> port 0xcf60-0xcf7f irq 11 at device 31.4 on pci0
 usb1: <Intel 82801BA/BAM (ICH2) USB controller USB-B> on uhci1
 usb1: USB revision 1.0
 uhub1: Intel UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
 uhub1: 2 ports with 2 removable, self powered
 pcm0: <Intel 82801BA (ICH2)> port 0xcdc0-0xcdff,0xce00-0xceff irq 11 at device 31.5 on pci0
 pcm0: <Yamaha YMF743 AC97 Codec>
 pci0: <simple comms> at device 31.6 (no driver attached)
 acpi_lid0: <Control Method Lid Switch> on acpi0
 acpi_cmbat0: <Control method Battery> on acpi0
 acpi_acad0: <AC adapter> on acpi0
 speaker0 port 0x61 on acpi0
 atkbdc0: <Keyboard controller (i8042)> port 0x64,0x60 irq 1 on acpi0
 atkbd0: <AT Keyboard> flags 0x1 irq 1 on atkbdc0
 kbd0 at atkbd0
 psm0: <PS/2 Mouse> irq 12 on atkbdc0
 psm0: model IntelliMouse, device ID 3
 fdc0: <Enhanced floppy controller (i82077, NE72065 or clone)> port 0x3f7,0x3f0-0x3f5 irq 6 drq 2 on acpi0
 fdc0: FIFO enabled, 8 bytes threshold
 fd0: <1440-KB 3.5" drive> on fdc0 drive 0
 sio0 port 0x3f8-0x3ff irq 4 on acpi0
 sio0: type 16550A
 ppc0 port 0x778-0x77a,0x378-0x37f irq 7 drq 3 on acpi0
 ppc0: SMC-like chipset (ECP/EPP/PS2/NIBBLE) in COMPATIBLE mode
 ppc0: FIFO with 16/16/15 bytes threshold
 ppbus0: <Parallel port bus> on ppc0
 plip0: <PLIP network interface> on ppbus0
 lpt0: <Printer> on ppbus0
 lpt0: Interrupt-driven port
 orm0: <Option ROMs> at iomem 0xe0000-0xeffff,0xc0000-0xcbfff on isa0
 pmtimer0 on isa0
 sc0: <System console> at flags 0x100 on isa0
 sc0: VGA <16 virtual consoles, flags=0x300>
 sio1: configured irq 3 not in bitmap of probed irqs 0
 sio1: port may not be enabled
 vga0: <Generic ISA VGA> at port 0x3c0-0x3df iomem 0xa0000-0xbffff on isa0
 Timecounters tick every 10.000 msec
 system power profile changed to 'economy'
 wi0: <TOSHIBA Wireless LAN Card> at port 0x100-0x13f irq 11 function 0 config 1 on pccard0
 wi0: 802.11 address: 00:02:2d:12:a7:92
 wi0: using Lucent Embedded WaveLAN/IEEE
 wi0: Lucent Firmware: Station (6.14.1)
 wi0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
 ad0: 19077MB <TOSHIBA MK2016GAP> [38760/16/63] at ata0-master UDMA66
 acd0: CD-RW <TOSHIBA DVD-ROM SD-R2002> at ata1-master WDMA2
 Mounting root from ufs:/dev/ad0s1a
 in6_ifattach: pflog0 is not multicast capable, IPv6 not enabled
 in6_ifattach: pfsync0 is not multicast capable, IPv6 not enabled
 system power profile changed to 'performance'
 umass0: Generic USB Flash Disk, rev 1.10/1.00, addr 2
 da0 at umass-sim0 bus 0 target 0 lun 0
 da0: <Generic USB Flash Disk 1.00> Removable Direct Access SCSI-0 device
 da0: 1.000MB/s transfers
 da0: 127MB (260480 512 byte sectors: 64H 32S/T 127C)
 umass0: Phase Error, residue = 0
 (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0
 Opened disk da0 -> 5
 Opened disk da0 -> 5
 Opened disk da0 -> 5
 Opened disk da0 -> 5
 umass0: at uhub0 port 2 (addr 2) disconnected
 (da0:umass-sim0:0:0:0): lost device
 (da0:umass-sim0:0:0:0): removing device entry
 umass0: detached
 
 Output from dmesg for successful attach attempts (after quirk added):
 Copyright (c) 1992-2003 The FreeBSD Project.
 Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
 	The Regents of the University of California. All rights reserved.
 FreeBSD 5.1-CURRENT #30: Wed Jul  9 12:45:34 CEST 2003
     root@snowlap.unixguru.nl:/usr/obj/usr/src/sys/SNOWLAP
 Preloaded elf kernel "/boot/kernel/kernel" at 0xc0565000.
 Preloaded elf module "/boot/kernel/acpi.ko" at 0xc05652e4.
 Timecounter "i8254"  frequency 1193182 Hz
 Timecounter "TSC"  frequency 797580320 Hz
 CPU: Intel Pentium III (797.58-MHz 686-class CPU)
   Origin = "GenuineIntel"  Id = 0x686  Stepping = 6
   Features=0x383f9ff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,SSE>
 real memory  = 401997824 (383 MB)
 avail memory = 384548864 (366 MB)
 Pentium Pro MTRR support enabled
 npx0: <math processor> on motherboard
 npx0: INT 16 interface
 acpi0: <TOSHIB 750     > on motherboard
 pcibios: BIOS version 2.10
 Using $PIR table, 7 entries at 0xc00f01c0
 acpi0: power button is handled as a fixed feature programming model.
 Timecounter "ACPI-safe"  frequency 3579545 Hz
 acpi_timer0: <24-bit timer at 3.579545MHz> port 0xee08-0xee0b on acpi0
 acpi_cpu0: <CPU> port 0x530-0x537 on acpi0
 acpi_tz0: <thermal zone> port 0x530-0x537 on acpi0
 pcib0: <ACPI Host-PCI bridge> port 0xcf8-0xcff on acpi0
 pci0: <ACPI PCI bus> on pcib0
 pcib0: slot 31 INTD is routed to irq 11
 pcib0: slot 31 INTC is routed to irq 11
 pcib0: slot 31 INTB is routed to irq 11
 pcib0: slot 31 INTB is routed to irq 11
 agp0: <Intel 82815 (i815 GMCH) host to PCI bridge> mem 0xf0000000-0xf3ffffff at device 0.0 on pci0
 pcib1: <ACPI PCI-PCI bridge> at device 1.0 on pci0
 pci1: <ACPI PCI bus> on pcib1
 pcib1: slot 0 INTA is routed to irq 11
 pci1: <display, VGA> at device 0.0 (no driver attached)
 pcib2: <ACPI PCI-PCI bridge> at device 30.0 on pci0
 pci2: <ACPI PCI bus> on pcib2
 pcib2: slot 8 INTA is routed to irq 11
 fxp0: <Intel 82801BA/CAM (ICH2/3) Pro/100 Ethernet> port 0xdf40-0xdf7f mem 0xf7dff000-0xf7dfffff irq 11 at device 8.0 on pci2
 fxp0: Ethernet address 00:00:39:be:6a:32
 miibus0: <MII bus> on fxp0
 inphy0: <i82562ET 10/100 media interface> on miibus0
 inphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
 cbb0: <TI1410 PCI-CardBus Bridge> at device 12.0 on pci2
 cardbus0: <CardBus bus> on cbb0
 pccard0: <16-bit PCCard bus> on cbb0
 pcib2: slot 12 INTA is routed to irq 11
 cbb1: <ToPIC100 PCI-CardBus Bridge> at device 13.0 on pci2
 cardbus1: <CardBus bus> on cbb1
 pccard1: <16-bit PCCard bus> on cbb1
 pcib2: slot 13 INTA is routed to irq 11
 cbb2: <ToPIC100 PCI-CardBus Bridge> at device 13.1 on pci2
 cardbus2: <CardBus bus> on cbb2
 pccard2: <16-bit PCCard bus> on cbb2
 pcib2: slot 13 INTB is routed to irq 11
 isab0: <PCI-ISA bridge> at device 31.0 on pci0
 isa0: <ISA bus> on isab0
 atapci0: <Intel ICH2 UDMA100 controller> port 0xcff0-0xcfff at device 31.1 on pci0
 ata0: at 0x1f0 irq 14 on atapci0
 ata1: at 0x170 irq 15 on atapci0
 uhci0: <Intel 82801BA/BAM (ICH2) USB controller USB-A> port 0xcf80-0xcf9f irq 11 at device 31.2 on pci0
 usb0: <Intel 82801BA/BAM (ICH2) USB controller USB-A> on uhci0
 usb0: USB revision 1.0
 uhub0: Intel UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
 uhub0: 2 ports with 2 removable, self powered
 uhci1: <Intel 82801BA/BAM (ICH2) USB controller USB-B> port 0xcf60-0xcf7f irq 11 at device 31.4 on pci0
 usb1: <Intel 82801BA/BAM (ICH2) USB controller USB-B> on uhci1
 usb1: USB revision 1.0
 uhub1: Intel UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
 uhub1: 2 ports with 2 removable, self powered
 pcm0: <Intel ICH2 (82801BA)> port 0xcdc0-0xcdff,0xce00-0xceff irq 11 at device 31.5 on pci0
 pcm0: <Yamaha YMF743 AC97 Codec>
 pci0: <simple comms> at device 31.6 (no driver attached)
 acpi_lid0: <Control Method Lid Switch> on acpi0
 acpi_cmbat0: <Control method Battery> on acpi0
 acpi_acad0: <AC adapter> on acpi0
 speaker0 port 0x61 on acpi0
 atkbdc0: <Keyboard controller (i8042)> port 0x64,0x60 irq 1 on acpi0
 atkbd0: <AT Keyboard> flags 0x1 irq 1 on atkbdc0
 kbd0 at atkbd0
 psm0: <PS/2 Mouse> irq 12 on atkbdc0
 psm0: model IntelliMouse, device ID 3
 fdc0: <Enhanced floppy controller (i82077, NE72065 or clone)> port 0x3f7,0x3f0-0x3f5 irq 6 drq 2 on acpi0
 fdc0: FIFO enabled, 8 bytes threshold
 fd0: <1440-KB 3.5" drive> on fdc0 drive 0
 sio0 port 0x3f8-0x3ff irq 4 on acpi0
 sio0: type 16550A
 ppc0 port 0x778-0x77a,0x378-0x37f irq 7 drq 3 on acpi0
 ppc0: SMC-like chipset (ECP/EPP/PS2/NIBBLE) in COMPATIBLE mode
 ppc0: FIFO with 16/16/15 bytes threshold
 ppbus0: <Parallel port bus> on ppc0
 plip0: <PLIP network interface> on ppbus0
 lpt0: <Printer> on ppbus0
 lpt0: Interrupt-driven port
 orm0: <Option ROMs> at iomem 0xe0000-0xeffff,0xc0000-0xcbfff on isa0
 pmtimer0 on isa0
 sc0: <System console> at flags 0x100 on isa0
 sc0: VGA <16 virtual consoles, flags=0x300>
 sio1: configured irq 3 not in bitmap of probed irqs 0
 sio1: port may not be enabled
 vga0: <Generic ISA VGA> at port 0x3c0-0x3df iomem 0xa0000-0xbffff on isa0
 Timecounters tick every 10.000 msec
 wi0: <TOSHIBA Wireless LAN Card> at port 0x100-0x13f irq 11 function 0 config 1 on pccard0
 wi0: 802.11 address: 00:02:2d:12:a7:92
 wi0: using Lucent Embedded WaveLAN/IEEE
 wi0: Lucent Firmware: Station (6.14.1)
 wi0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
 ad0: 19077MB <TOSHIBA MK2016GAP> [38760/16/63] at ata0-master UDMA66
 acd0: CD-RW <TOSHIBA DVD-ROM SD-R2002> at ata1-master WDMA2
 Mounting root from ufs:/dev/ad0s1a
 in6_ifattach: pflog0 is not multicast capable, IPv6 not enabled
 in6_ifattach: pfsync0 is not multicast capable, IPv6 not enabled
 umass0: Generic USB Flash Disk, rev 1.10/1.00, addr 2
 da0 at umass-sim0 bus 0 target 0 lun 0
 da0: <Generic USB Flash Disk 1.00> Removable Direct Access SCSI-0 device
 da0: 1.000MB/s transfers
 da0: 127MB (260480 512 byte sectors: 64H 32S/T 127C)
 umass0: at uhub0 port 2 (addr 2) disconnected
 (da0:umass-sim0:0:0:0): lost device
 (da0:umass-sim0:0:0:0): removing device entry
 umass0: detached
 umass0: Generic USB Flash Disk, rev 1.10/1.00, addr 2
 da0 at umass-sim0 bus 0 target 0 lun 0
 da0: <Generic USB Flash Disk 1.00> Removable Direct Access SCSI-0 device
 da0: 1.000MB/s transfers
 da0: 127MB (260480 512 byte sectors: 64H 32S/T 127C)
 
 Output of "usbdevs -v" with device attached:
 Controller /dev/usb0:
 addr 1: full speed, self powered, config 1, UHCI root hub(0x0000),
 Intel(0x0000), rev 1.00
  port 1 powered
  port 2 addr 2: full speed, power 100 mA, config 1, USB Flash
 Disk(0x8001), Generic(0x09a6), rev 1.00
 Controller /dev/usb1:
 addr 1: full speed, self powered, config 1, UHCI root hub(0x0000),
 Intel(0x0000), rev 1.00
  port 1 powered
  port 2 powered
 
 
 Regards,
 
 Richard.
 
 ----
 Paul Vixie in an interview with Sendmail.net:
 
 Now that the Internet has the full spectrum of humanity as users,
 the technology is showing its weakness: it was designed to be
 used by friendly, smart people. Spammers, as an example of a class,
 are neither friendly nor smart.
Responsible-Changed-From-To: freebsd-bugs->joe 
Responsible-Changed-By: kris 
Responsible-Changed-When: Thu Jul 17 17:38:35 PDT 2003 
Responsible-Changed-Why:  
Assign to USB maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53067 

From: Richard Arends <richard@unixguru.nl>
To: Nate Lawson <nate@root.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/53067: Add support for the PQI USB Flash Disk
Date: Sat, 9 Aug 2003 12:09:36 +0200 (CEST)

 On Wed, 9 Jul 2003, Richard Arends wrote:
 
 Nate,
 
 With this device I still need the quirks (and now thus options
 DA_OLD_QUIRKS in my kernel config).
 
 Regards,
 
 Richard.
 
 ----
 Paul Vixie in an interview with Sendmail.net:
 
 Now that the Internet has the full spectrum of humanity as users,
 the technology is showing its weakness: it was designed to be
 used by friendly, smart people. Spammers, as an example of a class,
 are neither friendly nor smart.
Responsible-Changed-From-To: joe->njl 
Responsible-Changed-By: njl 
Responsible-Changed-When: Thu Aug 21 21:47:01 PDT 2003 
Responsible-Changed-Why:  
I'll look into fixing this before 4.9 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53067 
State-Changed-From-To: open->feedback 
State-Changed-By: njl 
State-Changed-When: Fri Aug 22 00:09:11 PDT 2003 
State-Changed-Why:  
If you can verify that this quirk works for you and that you still get 
failures without it, please let me know ASAP. 

Index: scsi_da.c 
=================================================================== 
RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v 
retrieving revision 1.153 
diff -u -r1.153 scsi_da.c 
--- scsi_da.c	22 Aug 2003 05:58:23 -0000	1.153 
+++ scsi_da.c	22 Aug 2003 07:05:37 -0000 
@@ -381,6 +381,15 @@ 
{T_DIRECT, SIP_MEDIA_REMOVABLE, "JUNGSOFT", "NEXDISK*", "*"}, 
/*quirks*/ DA_Q_NO_SYNC_CACHE 
}, 
+	{ 
+		/* 
+		 * Power Quotient Int. (PQI) USB flash key 
+		 * PR: kern/53067 
+		 */ 
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic", "USB Flash Disk", 
+		 "*"}, 
+		/*quirks*/ DA_Q_NO_SYNC_CACHE 
+	}, 
}; 

static	disk_strategy_t	dastrategy; 


http://www.freebsd.org/cgi/query-pr.cgi?pr=53067 

From: Nate Lawson <nate@root.org>
To: Richard Arends <richard@unixguru.nl>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/53067: Add support for the PQI USB Flash Disk
Date: Sat, 23 Aug 2003 21:27:24 -0700 (PDT)

 On Sat, 23 Aug 2003, Richard Arends wrote:
 > > If you can verify that this quirk works for you and that you still get
 > > failures without it, please let me know ASAP.
 >
 > Youre patch didn't work. The following patch (with the *'s after the
 > device identifiers), does work!
 >
 > --- scsi_da.c.orig	Fri Aug 22 09:44:10 2003
 > +++ scsi_da.c	Sat Aug 23 21:07:13 2003
 > @@ -381,6 +381,14 @@
 >  		{T_DIRECT, SIP_MEDIA_REMOVABLE, "JUNGSOFT", "NEXDISK*", "*"},
 >  		/*quirks*/ DA_Q_NO_SYNC_CACHE
 >  	},
 > +	{
 > +		/*
 > +		 * Power Quotient Int. (PQI) USB flash key
 > +		 * PR: kern/53067
 > +		 */
 > +		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic*", "USB Flash Disk*", "*"},
 > +		/*quirks*/ DA_Q_NO_SYNC_CACHE
 > +	}
 >  };
 >
 >  static	disk_strategy_t	dastrategy;
 
 Please remove one * and then the other and see if both are really needed.
 Quirks need to be as specific as possible.
 
 -Nate

From: Richard Arends <richard@unixguru.nl>
To: Nate Lawson <nate@root.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/53067: Add support for the PQI USB Flash Disk
Date: Sun, 24 Aug 2003 12:37:15 +0200 (CEST)

 On Sat, 23 Aug 2003, Nate Lawson wrote:
 
 Nate,
 
 > Please remove one * and then the other and see if both are really needed.
 > Quirks need to be as specific as possible.
 
 I placed the following code (not mine) in scsi_da.c:
 
 printf("scsi quirks: %s - type %d med %s "
   "vend \"%s\" prod \"%s\" ver \"%s\"\n",
   match ? "match" : "none",
   SID_TYPE((&cgd->inq_data)),
   SID_IS_REMOVABLE((&cgd->inq_data)) ? "remov" : "fixed",
   cgd->inq_data.vendor, cgd->inq_data.product,
   cgd->inq_data.revision);
 
 That gives me the following:
 scsi quirks: none - type 0 med remov vend "Generic" prod "USB Flash Disk" ver "1.00"
 
 'quirks: none' is 'quirks: match' if I use the *
 
 Looking at that you should realy think this device does not have anything
 after the Vendor and Product ident, but I realy need both *'s :(
 
 Regards,
 
 Richard.
 
 ----
 Paul Vixie in an interview with Sendmail.net:
 
 Now that the Internet has the full spectrum of humanity as users,
 the technology is showing its weakness: it was designed to be
 used by friendly, smart people. Spammers, as an example of a class,
 are neither friendly nor smart.

From: Jean-Sebastien Roy <js@jeannot.org>
To: freebsd-gnats-submit@FreeBSD.org, richard@unixguru.nl,
	njl@FreeBSD.org
Cc:  
Subject: Re: kern/53067: Add support for the PQI USB FlashDisk
Date: Sat, 8 Nov 2003 02:10:32 +0100

 For what it is worth, I had no success with the last patch on FreeBSD
 4.9 with my PQI key (note the different device version):
 uname -a:
 FreeBSD durandal.root 4.9-STABLE FreeBSD 4.9-STABLE #1: Sat Nov  8
 00:52:16 CET 2003     js@durandal.root:/mnt/backup/obj/opt/src/sys/JS 
 i386
 
 dmesg output when inserting the device and trying to mount it :
 
 umass0: Generic USB Flash Disk, rev 1.10/1.00, addr 3
 da0 at umass-sim0 bus 0 target 0 lun 0
 da0: <Generic USB Flash Disk 2.23> Removable Direct Access SCSI-2 device
 da0: 650KB/s transfers
 da0: 254MB (521408 512 byte sectors: 64H 32S/T 254C)
 umass0: BBB reset failed, TIMEOUT
 umass0: BBB bulk-in clear stall failed, TIMEOUT
 umass0: BBB bulk-out clear stall failed, TIMEOUT
 ...
 (last 3 lines repeat)
 
 Regards,
 
 js
State-Changed-From-To: feedback->closed 
State-Changed-By: njl 
State-Changed-When: Sun Apr 18 21:15:11 PDT 2004 
State-Changed-Why:  
Committed and will hopefully make it into 4.10.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53067 
>Unformatted:
