From thz@Lennartz-electronic.de  Tue May 27 08:44:08 2003
Return-Path: <thz@Lennartz-electronic.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 92A2437B404
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 27 May 2003 08:44:08 -0700 (PDT)
Received: from mail08a.verio.de (mail08a.verio.de [213.198.55.86])
	by mx1.FreeBSD.org (Postfix) with SMTP id C949843F85
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 27 May 2003 08:44:06 -0700 (PDT)
	(envelope-from thz@Lennartz-electronic.de)
Received: from www.lennartz-electronic.de (213.198.47.155)
	by mail08a.verio.de (RS ver 1.0.80vs) with SMTP id 039982237
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 27 May 2003 17:43:58 +0200 (CEST)
Received: from mezcal.tue.le (mezcal.tue.le [192.168.201.20])
	by swd2.tue.le (8.12.6/8.12.6) with ESMTP id h4RFhW9B070992
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 27 May 2003 17:43:32 +0200 (CEST)
	(envelope-from thz@mezcal.tue.le)
Received: from mezcal.tue.le (localhost [127.0.0.1])
	by mezcal.tue.le (8.12.8p1/8.12.8) with ESMTP id h4RFhW9T066035
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 27 May 2003 17:43:32 +0200 (CEST)
	(envelope-from thz@mezcal.tue.le)
Received: (from thz@localhost)
	by mezcal.tue.le (8.12.8p1/8.12.8/Submit) id h4RFhWFR066034
	for FreeBSD-gnats-submit@FreeBSD.org; Tue, 27 May 2003 17:43:32 +0200 (CEST)
	(envelope-from thz)
Message-Id: <20030527174332.A66018@mezcal.tue.le>
Date: Tue, 27 May 2003 17:43:32 +0200
From: Thomas Zenker <thz@Lennartz-electronic.de>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: [PATCH] installincludes for kmods

>Number:         52725
>Category:       kern
>Synopsis:       [patch] installincludes for kmods
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 27 08:50:16 PDT 2003
>Closed-Date:    
>Last-Modified:  Mon Dec 29 17:38:00 UTC 2008
>Originator:     Thomas Zenker
>Release:        FreeBSD 4.8-RC i386
>Organization:
Lennartz electronic
>Environment:
System: FreeBSD mezcal.tue.le 4.8-RC FreeBSD 4.8-RC #31: Tue Mar 11 11:26:15 CET 2003 thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL i386

	stable, current

>Description:
	For kernel modules the ability in the make system to install
	include files via the INCS variable (and brothers) and
	installincludes target is not implemented, as it is for
	prog and lib subdirectories.  The problem is actually, that
	<bsd.incs.mk> is not included in sys/conf/kmod.mk

>How-To-Repeat:
	KMOD = abc
	SRCS = abc.c
	INCS = abc.h
	"make installincludes" does nothing.
	"make install" installs kmod abc.ko, but not include file abc.h.

>Fix:

cvs server: Diffing sys/conf
Index: sys/conf/kmod.mk
===================================================================
RCS file: /usr/cvs/FreeBSD/src/sys/conf/kmod.mk,v
retrieving revision 1.82.2.15
diff -u -r1.82.2.15 kmod.mk
--- sys/conf/kmod.mk	10 Feb 2003 13:11:50 -0000	1.82.2.15
+++ sys/conf/kmod.mk	8 Apr 2003 10:07:27 -0000
@@ -187,6 +187,7 @@
 	    ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}
 .endif !target(realinstall)
 
+.include <bsd.incs.mk>
 .include <bsd.links.mk>
 
 .if !defined(NOMAN)



-- Thomas Zenker
   c/o Lennartz electronic GmbH
   Bismarckstrasse 136, D-72072 Tuebingen, Germany
   Phone:  +49-(0)7071-93550
   Email:  thz@lennartz-electronic.de
>Release-Note:
>Audit-Trail:
>Unformatted:
