From aida-s@jcom.home.ne.jp  Sat Apr  5 05:28:50 2003
Return-Path: <aida-s@jcom.home.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAD6637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  5 Apr 2003 05:28:50 -0800 (PST)
Received: from mx.j10n.org (203.141.155.228.user.ca.il24.net [203.141.155.228])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0056243F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  5 Apr 2003 05:28:49 -0800 (PST)
	(envelope-from aida-s@jcom.home.ne.jp)
Received: from e-note.j10n.org (e-note.j10n.org [10.0.10.1])
	by mx.j10n.org (8.12.6p2/8.12.6) with ESMTP id h35DSlVf053351
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 Apr 2003 22:28:47 +0900 (JST)
	(envelope-from aida-s@jcom.home.ne.jp)
Received: from e-note.j10n.org (localhost [127.0.0.1])
	by e-note.j10n.org (8.12.9/8.12.9) with ESMTP id h35DSkCW000966
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 Apr 2003 22:28:47 +0900 (JST)
	(envelope-from aida-s@jcom.home.ne.jp)
Received: (from shinra@localhost)
	by e-note.j10n.org (8.12.9/8.12.9/Submit) id h35DSkuK000965;
	Sat, 5 Apr 2003 22:28:46 +0900 (JST)
	(envelope-from aida-s@jcom.home.ne.jp)
Message-Id: <200304051328.h35DSkuK000965@e-note.j10n.org>
Date: Sat, 5 Apr 2003 22:28:46 +0900 (JST)
From: AIDA Shinra <shinra@j10n.org>
Reply-To: AIDA Shinra <shinra@j10n.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: <panic while TCP6 bind()>
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50621
>Category:       kern
>Synopsis:       panic while TCP6 bind()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ume
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 05 05:30:15 PST 2003
>Closed-Date:    Thu Feb 19 01:37:54 PST 2004
>Last-Modified:  Thu Feb 19 01:37:54 PST 2004
>Originator:     AIDA Shinra
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD e-note 5.0-CURRENT FreeBSD 5.0-CURRENT #8: Sat Apr 5 21:33:27 JST 2003 shinra@e-note:/usr/obj/usr/freebsd/src/sys/LOCAL i386


>Description:
When I repeat starting and stopping some IPv6 server applications rapidly,
my kernel frequently panics. At first the point of crash was random but
today's kernel always crashed at:

at in6_pcbbind() in netinet6/in6_pcb.c:
if (so->so_cred->cr_uid != 0 &&
    !IN6_IS_ADDR_MULTICAST(&sin6->sin6_addr)) {
	t = in6_pcblookup_local(pcbinfo,
	    &sin6->sin6_addr, lport,
	    INPLOOKUP_WILDCARD);
	if (t &&
	    (!IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr) ||
	     !IN6_IS_ADDR_UNSPECIFIED(&t->in6p_laddr) ||
	     (t->inp_socket->so_options &
	      SO_REUSEPORT) == 0) &&
	    (so->so_cred->cr_uid !=
	     t->inp_socket->so_cred->cr_uid)) /* t->inp_socket == NULL!! */
		return (EADDRINUSE);
	if ((inp->inp_flags & IN6P_IPV6_V6ONLY) == 0 &&
	    IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr)) {
		struct sockaddr_in sin;

>How-To-Repeat:
Described above.

>Fix:
I'm NO a kernel hacker but following patch seems to stop panic (but
possibly another side effect.) I believe the problem is TCP_TIMEWAIT
if any.

Index: in6_pcb.c
===================================================================
RCS file: /home/shinra/cvsroot/freebsd/src/sys/netinet6/in6_pcb.c,v
retrieving revision 1.4
diff -u -r1.4 in6_pcb.c
--- in6_pcb.c	2 Mar 2003 18:09:59 -0000	1.4
+++ in6_pcb.c	5 Apr 2003 12:33:22 -0000
@@ -198,6 +198,13 @@
 				t = in6_pcblookup_local(pcbinfo,
 				    &sin6->sin6_addr, lport,
 				    INPLOOKUP_WILDCARD);
+				if (t && (t->inp_vflag & INP_TIMEWAIT)) {
+					if ((!IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr) ||
+					     !IN6_IS_ADDR_UNSPECIFIED(&t->in6p_laddr) ||
+					    (intotw(t)->tw_so_options & SO_REUSEPORT) == 0) &&
+					    (so->so_cred->cr_uid != intotw(t)->tw_cred->cr_uid))
+						return (EADDRINUSE);
+				} else
 				if (t &&
 				    (!IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr) ||
 				     !IN6_IS_ADDR_UNSPECIFIED(&t->in6p_laddr) ||
@@ -206,6 +213,7 @@
 				    (so->so_cred->cr_uid !=
 				     t->inp_socket->so_cred->cr_uid))
 					return (EADDRINUSE);
+				else
 				if ((inp->inp_flags & IN6P_IPV6_V6ONLY) == 0 &&
 				    IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr)) {
 					struct sockaddr_in sin;
@@ -226,8 +234,13 @@
 			}
 			t = in6_pcblookup_local(pcbinfo, &sin6->sin6_addr,
 						lport, wild);
+			if (t && (t->inp_vflag & INP_TIMEWAIT)) {
+				if ((reuseport & intotw(t)->tw_so_options) == 0)
+					return (EADDRINUSE);
+			} else
 			if (t && (reuseport & t->inp_socket->so_options) == 0)
 				return(EADDRINUSE);
+			else
 			if ((inp->inp_flags & IN6P_IPV6_V6ONLY) == 0 &&
 			    IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr)) {
 				struct sockaddr_in sin;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Sat Apr 5 08:59:50 PST 2003 
Responsible-Changed-Why:  
Reassign misfiled PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50621 
Responsible-Changed-From-To: freebsd-bugs->ume 
Responsible-Changed-By: andre 
Responsible-Changed-When: Sat Dec 27 08:42:53 PST 2003 
Responsible-Changed-Why:  
Assign this to ume-san.  He is the IPv6 maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50621 
State-Changed-From-To: open->closed 
State-Changed-By: ume 
State-Changed-When: Thu Feb 19 01:35:45 PST 2004 
State-Changed-Why:  
Thank you for your report.  Yes, it was TCP_TIMEWAIT related problem, 
and was fixed. 

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_pcb.c.diff?r1=1.36&r2=1.37 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50621 
>Unformatted:
