From ob@gruft.de  Tue Mar 25 01:51:24 2003
Return-Path: <ob@gruft.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E7E0B37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Mar 2003 01:51:24 -0800 (PST)
Received: from obh.snafu.de (obh.snafu.de [213.73.92.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6088E43F85
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Mar 2003 01:51:24 -0800 (PST)
	(envelope-from ob@gruft.de)
Received: from ob by obh.snafu.de with local (Exim 3.36 #1)
	id 18xl5X-000KPV-00
	for FreeBSD-gnats-submit@freebsd.org; Tue, 25 Mar 2003 10:51:23 +0100
Message-Id: <E18xl5X-000KPV-00@obh.snafu.de>
Date: Tue, 25 Mar 2003 10:51:23 +0100
From: Oliver Brandmueller <obi@gruft.de>
Sender: Oliver Brandmueller <ob@gruft.de>
Reply-To: Oliver Brandmueller <obgruft.de@gruft.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Add USB ID/quirks for Optio 230GS Digital Camera
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50271
>Category:       kern
>Synopsis:       Add USB ID/quirks for Optio 230GS Digital Camera
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    njl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 25 02:00:26 PST 2003
>Closed-Date:    Sat May 17 15:00:12 PDT 2003
>Last-Modified:  Sat May 17 15:00:12 PDT 2003
>Originator:     Oliver Brandmueller
>Release:        FreeBSD 4.8-PRERELEASE i386
>Organization:
obh private network
>Environment:
System: FreeBSD gruft.de 4.8-PRERELEASE FreeBSD 4.8-PRERELEASE #27: Sat Feb 22 18:24:39 CET 2003 root@gruft.de:/usr/obj/usr/src/sys/EXPRESS i386

>Description:

I've successfully connected a Pentax Optio 230GS camera with the same 
options/quirks as the Optio 230 camera which is already mentioned in the 
sources.

>How-To-Repeat:
connect Optio 230GS camera to USB port

>Fix:

In /usr/src/sys/dev/usb/usbdevs add:

product ASAHIOPTICAL OPTIO230GS	0x0006  Digital camera


In /usr/src/sys/dev/usb/umass.c add:

        if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL
            && UGETW(dd->idProduct) == USB_PRODUCT_ASAHIOPTICAL_OPTIO230GS) {
                sc->quirks |= RS_NO_CLEAR_UA;
        }


After rebuilding usbdevs.h and building/installing the new kernel the 
camera works just fine as a umass device.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->njl 
Responsible-Changed-By: johan 
Responsible-Changed-When: Tue Mar 25 10:43:29 PST 2003 
Responsible-Changed-Why:  
Over to quirks maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50271 
State-Changed-From-To: open->feedback 
State-Changed-By: njl 
State-Changed-When: Sun Apr 27 12:54:57 PDT 2003 
State-Changed-Why:  
Submitter will test patch and report back. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50271 

From: Nate Lawson <nate@root.org>
To: Oliver Brandmueller <obgruft.de@gruft.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/50271 Optio 230GS
Date: Sun, 27 Apr 2003 12:54:50 -0700 (PDT)

 I need some more information from you.  Please send the results of
 camcontrol inquiry <your device> after it has successfully attached as
 well as output of "usbdevs -v".
 
 Instead of your patch, please try the following:
 
 --- src/sys/dev/usb/umass.c     14 Mar 2003 13:23:05 -0000      1.11.2.18
 +++ src/sys/dev/usb/umass.c     27 Apr 2003 19:52:14 -0000
 @@ -616,10 +616,8 @@
          * The Pentax Optio 230 requires RS_NO_CLEAR_UA
          * PR: kern/46369
          */
 -       if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL
 -           && UGETW(dd->idProduct) == USB_PRODUCT_ASAHIOPTICAL_OPTIO230) {
 +       if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL)
                 sc->quirks |= RS_NO_CLEAR_UA;
 -       }
  
         if (UGETW(dd->idVendor) == USB_VENDOR_FUJIPHOTO
             && UGETW(dd->idProduct) == USB_PRODUCT_FUJIPHOTO_MASS0100) {
 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: njl 
State-Changed-When: Sat May 17 14:59:29 PDT 2003 
State-Changed-Why:  

Generalized quirk (all of Asahi Optical devices) has been committed and 
MFCd.  It will be in 5.1R and subsequent 4.x releases. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50271 
>Unformatted:
