From Ilya.Starkov@cpcpipe.ru  Mon Mar 24 23:29:52 2003
Return-Path: <Ilya.Starkov@cpcpipe.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CF25F37B408
	for <bug-followup@freebsd.org>; Mon, 24 Mar 2003 23:29:51 -0800 (PST)
Received: from mail.cpcpipe.ru (mail.cpcpipe.ru [194.186.52.161])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0E96544017
	for <bug-followup@freebsd.org>; Mon, 24 Mar 2003 22:54:25 -0800 (PST)
	(envelope-from Ilya.Starkov@cpcpipe.ru)
Received: from mail.cpcpipe.ru ([10.4.1.15] RDNS failed) by mail.cpcpipe.ru with Microsoft SMTPSVC(5.0.2195.5329);
	 Mon, 24 Mar 2003 20:45:00 +0300
Message-Id: <60589E0AE962564BB7EA5CC5F553112B074F14@m42mxs00.cpcpipe.ru>
Date: Mon, 24 Mar 2003 20:44:59 +0300
From: "Starkov, Ilya" <Ilya.Starkov@cpcpipe.ru>
To: "Maxim Konovalov" <maxim@macomnet.ru>,
	"Ilia Starkov" <star0413@ns4.cpcpipe.ru>
Cc: <bug-followup@freebsd.org>
Subject: HA: kern/50163: debug screen appear when dial-in user try to login

>Number:         50266
>Category:       kern
>Synopsis:       HA: kern/50163: debug screen appear when dial-in user try to login
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 24 23:30:10 PST 2003
>Closed-Date:    Tue Mar 25 10:53:00 PST 2003
>Last-Modified:  Tue Mar 25 10:53:00 PST 2003
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 This is a multi-part message in MIME format.
 
 ------_=_NextPart_001_01C2F22D.16E59FA0
 Content-Type: text/plain;
 	charset="windows-1251"
 Content-Transfer-Encoding: quoted-printable
 
 Maxim,
 =20
 I have tryed to apply this patch but little bit confused.
 Now I have if_ppp.c dated March 17, but your patch for file dated March =
 4.
 After "patch if_ppp.c if_ppp.patch" I got some "Hmm..." messages. ;-)
 # patch if_ppp.c if_ppp.patch
 Hmm...  Looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |diff -u -r1.90 if_ppp.c
 |--- if_ppp.c    4 Mar 2003 23:19:51 -0000       1.90
 |+++ if_ppp.c    23 Mar 2003 17:05:28 -0000
 --------------------------
 Patching file if_ppp.c using Plan A...
 Hunk #1 failed at 1571.
 1 out of 1 hunks failed--saving rejects to if_ppp.c.rej
 Hmm...  Ignoring the trailing garbage.
 done
 
 Please, see if_ppp.c.rej
 ***************
 *** 1571,1577 ****
         rv =3D IF_HANDOFF(&sc->sc_inq, m, NULL);
       else
         rv =3D netisr_queue(isr, m);
 -     if (rv) {
          if (sc->sc_flags & SC_DEBUG)
              if_printf(ifp, "input queue full\n");
          ifp->if_iqdrops++;
 --- 1571,1577 ----
         rv =3D IF_HANDOFF(&sc->sc_inq, m, NULL);
       else
         rv =3D netisr_queue(isr, m);
 +     if (!rv) {
          if (sc->sc_flags & SC_DEBUG)
              if_printf(ifp, "input queue full\n");
          ifp->if_iqdrops++;
 
 So, I think that patch apllied incorrect and still waiting for =
 correction.
 =20
 Also, I had rebuild system at Friday, March 21, but this bug still =
 present in the system.
 Anyway, thank you for your participation.
 =20
 Ilia.=20
 
 	-----=C8=F1=F5=EE=E4=ED=EE=E5 =F1=EE=EE=E1=F9=E5=ED=E8=E5-----=20
 	=CE=F2: Maxim Konovalov [mailto:maxim@macomnet.ru]=20
 	=CE=F2=EF=F0=E0=E2=EB=E5=ED=EE: =C2=F1 23.03.2003 20:18=20
 	=CA=EE=EC=F3: Ilia Starkov=20
 	=CA=EE=EF=E8=FF: bug-followup@freebsd.org=20
 	=D2=E5=EC=E0: Re: kern/50163: debug screen appear when dial-in user try =
 to login
 =09
 =09
 
 	Please try a patch below.
 =09
 	Index: if_ppp.c
 	=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 	RCS file: /home/ncvs/src/sys/net/if_ppp.c,v
 	retrieving revision 1.90
 	diff -u -r1.90 if_ppp.c
 	--- if_ppp.c    4 Mar 2003 23:19:51 -0000       1.90
 	+++ if_ppp.c    23 Mar 2003 17:05:28 -0000
 	@@ -1571,7 +1571,7 @@
 	       rv =3D IF_HANDOFF(&sc->sc_inq, m, NULL);
 	     else
 	       rv =3D netisr_queue(isr, m);
 	-    if (rv) {
 	+    if (!rv) {
 	        if (sc->sc_flags & SC_DEBUG)
 	            if_printf(ifp, "input queue full\n");
 	        ifp->if_iqdrops++;
 =09
 	%%%
 =09
 	--
 	Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org
 =09
 
 
 ------_=_NextPart_001_01C2F22D.16E59FA0
 Content-Type: text/html;
 	charset="windows-1251"
 Content-Transfer-Encoding: quoted-printable
 
 <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
 charset=3Dwindows-1251">=0A=
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">=0A=
 <HTML>=0A=
 <HEAD>=0A=
 =0A=
 <META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
 6.0.6249.1">=0A=
 <TITLE>Re: kern/50163: debug screen appear when dial-in user try to =
 login</TITLE>=0A=
 </HEAD>=0A=
 <BODY dir=3Dltr>=0A=
 <DIV>Maxim,</DIV>=0A=
 <DIV>&nbsp;</DIV>=0A=
 <DIV>I have tryed to apply this patch but little bit confused.</DIV>=0A=
 <DIV>Now I have if_ppp.c dated March 17, but your patch for file dated =
 March =0A=
 4.</DIV>=0A=
 <DIV>After "patch if_ppp.c if_ppp.patch"&nbsp;I got&nbsp;some "Hmm..." =
 messages. =0A=
 ;-)</DIV>=0A=
 <DIV># patch if_ppp.c if_ppp.patch<BR>Hmm...&nbsp; Looks like a unified =
 diff to =0A=
 me...<BR>The text leading up to this =
 was:<BR>--------------------------<BR>|diff =0A=
 -u -r1.90 if_ppp.c<BR>|--- if_ppp.c&nbsp;&nbsp;&nbsp; 4 Mar 2003 =
 23:19:51 =0A=
 -0000&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1.90<BR>|+++ =0A=
 if_ppp.c&nbsp;&nbsp;&nbsp; 23 Mar 2003 17:05:28 =0A=
 -0000<BR>--------------------------<BR>Patching file if_ppp.c using Plan =0A=
 A...<BR>Hunk #1 failed at 1571.<BR>1 out of 1 hunks failed--saving =
 rejects to =0A=
 if_ppp.c.rej<BR>Hmm...&nbsp; Ignoring the trailing =
 garbage.<BR>done<BR></DIV>=0A=
 <DIV>Please, see if_ppp.c.rej</DIV>=0A=
 <DIV>***************<BR>*** 1571,1577 =0A=
 ****<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D =0A=
 IF_HANDOFF(&amp;sc-&gt;sc_inq, m, =
 NULL);<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =0A=
 else<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D =
 netisr_queue(isr, =0A=
 m);<BR>-&nbsp;&nbsp;&nbsp;&nbsp; if (rv) =0A=
 {<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if =
 (sc-&gt;sc_flags &amp; =0A=
 SC_DEBUG)<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
 &nbsp;&nbsp; =0A=
 if_printf(ifp, "input queue =0A=
 full\n");<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =0A=
 ifp-&gt;if_iqdrops++;<BR>--- 1571,1577 =0A=
 ----<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D =0A=
 IF_HANDOFF(&amp;sc-&gt;sc_inq, m, =
 NULL);<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =0A=
 else<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D =
 netisr_queue(isr, =0A=
 m);<BR>+&nbsp;&nbsp;&nbsp;&nbsp; if (!rv) =0A=
 {<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if =
 (sc-&gt;sc_flags &amp; =0A=
 SC_DEBUG)<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
 &nbsp;&nbsp; =0A=
 if_printf(ifp, "input queue =0A=
 full\n");<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =0A=
 ifp-&gt;if_iqdrops++;<BR></DIV>=0A=
 <DIV>So, I think that patch apllied incorrect and still waiting for =0A=
 correction.</DIV>=0A=
 <DIV>&nbsp;</DIV>=0A=
 <DIV>Also, I&nbsp;had rebuild system at Friday, March 21, but this =0A=
 bug&nbsp;still present in the system.</DIV>=0A=
 <DIV>Anyway, thank you for your participation.</DIV>=0A=
 <DIV>&nbsp;</DIV>=0A=
 <DIV>Ilia.&nbsp;</DIV>=0A=
 <BLOCKQUOTE dir=3Dltr style=3D"MARGIN-RIGHT: 0px">=0A=
   <DIV><FONT size=3D2>-----=C8=F1=F5=EE=E4=ED=EE=E5 =
 =F1=EE=EE=E1=F9=E5=ED=E8=E5----- <BR><B>=CE=F2:</B> Maxim Konovalov =0A=
   [mailto:maxim@macomnet.ru] <BR><B>=CE=F2=EF=F0=E0=E2=EB=E5=ED=EE:</B> =
 =C2=F1 23.03.2003 20:18 =0A=
   <BR><B>=CA=EE=EC=F3:</B> Ilia Starkov <BR><B>=CA=EE=EF=E8=FF:</B> =
 bug-followup@freebsd.org =0A=
   <BR><B>=D2=E5=EC=E0:</B> Re: kern/50163: debug screen appear when =
 dial-in user try to =0A=
   login<BR><BR></FONT></DIV>=0A=
   <P><FONT size=3D2>Please try a patch below.<BR><BR>Index: =0A=
   =
 if_ppp.c<BR>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<BR>RCS =0A=
   file: /home/ncvs/src/sys/net/if_ppp.c,v<BR>retrieving revision =
 1.90<BR>diff -u =0A=
   -r1.90 if_ppp.c<BR>--- if_ppp.c&nbsp;&nbsp;&nbsp; 4 Mar 2003 23:19:51 =0A=
   -0000&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1.90<BR>+++ =0A=
   if_ppp.c&nbsp;&nbsp;&nbsp; 23 Mar 2003 17:05:28 -0000<BR>@@ -1571,7 =
 +1571,7 =0A=
   @@<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D =
 IF_HANDOFF(&amp;sc-&gt;sc_inq, =0A=
   m, NULL);<BR>&nbsp;&nbsp;&nbsp;&nbsp; =0A=
   else<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rv =3D netisr_queue(isr, =0A=
   m);<BR>-&nbsp;&nbsp;&nbsp; if (rv) {<BR>+&nbsp;&nbsp;&nbsp; if (!rv) =0A=
   {<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (sc-&gt;sc_flags =
 &amp; =0A=
   SC_DEBUG)<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
 &nbsp;&nbsp;&nbsp; =0A=
   if_printf(ifp, "input queue =0A=
   full\n");<BR>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =0A=
   ifp-&gt;if_iqdrops++;<BR><BR>%%%<BR><BR>--<BR>Maxim Konovalov, =0A=
   maxim@macomnet.ru, maxim@FreeBSD.org<BR></FONT></P></BLOCKQUOTE>=0A=
 =0A=
 </BODY>=0A=
 </HTML>
 ------_=_NextPart_001_01C2F22D.16E59FA0--
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Tue Mar 25 05:39:40 PST 2003 
Responsible-Changed-Why:  
Misfiled PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50266 

From: Giorgos Keramidas <keramida@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/50266: HA: kern/50163: debug screen appear when dial-in user try to login
Date: Tue, 25 Mar 2003 15:43:01 +0200

 Adding to audit trail:
 
 : Date: Tue, 25 Mar 2003 11:19:30 +0300 (MSK)
 : From: Maxim Konovalov <maxim@macomnet.ru>
 : To: "Starkov, Ilya" <Ilya.Starkov@cpcpipe.ru>
 : Cc: Ilia Starkov <star0413@ns4.cpcpipe.ru>, bug-followup@freebsd.org
 : Message-Id: <20030325111632.K25513@news1.macomnet.ru>
 : In-Reply-To: <60589E0AE962564BB7EA5CC5F553112B074F14@m42mxs00.cpcpipe.ru>
 :
 : Hello,
 :
 : Please show ident /usr/src/sys/net/if_ppp.c output. Look, the patch is
 : really simply, you can apply it by hands.
 :
 : The latest revision of if_ppp.c is rev. 1.90 from 4 Mar 2003. Here is
 : a patch for it.
 :
 : Index: sys/net/if_ppp.c
 : ===================================================================
 : RCS file: /home/ncvs/src/sys/net/if_ppp.c,v
 : retrieving revision 1.90
 : diff -u -r1.90 if_ppp.c
 : --- sys/net/if_ppp.c	4 Mar 2003 23:19:51 -0000	1.90
 : +++ sys/net/if_ppp.c	25 Mar 2003 08:15:37 -0000
 : @@ -1571,7 +1571,7 @@
 :        rv = IF_HANDOFF(&sc->sc_inq, m, NULL);
 :      else
 :        rv = netisr_queue(isr, m);
 : -    if (rv) {
 : +    if (!rv) {
 :  	if (sc->sc_flags & SC_DEBUG)
 :  	    if_printf(ifp, "input queue full\n");
 :  	ifp->if_iqdrops++;
 :
 : %%%

From: Giorgos Keramidas <keramida@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/50266: HA: kern/50163: debug screen appear when dial-in user try to login
Date: Tue, 25 Mar 2003 15:45:40 +0200

 Adding to audit trail:
 
 : Message-Id: <60589E0AE962564BB7EA5CC5F553112B1AF43A@m42mxs00.cpcpipe.ru>
 : Date: Tue, 25 Mar 2003 16:25:42 +0300
 : From: "Starkov, Ilya" <Ilya.Starkov@cpcpipe.ru>
 : To: "Maxim Konovalov" <maxim@macomnet.ru>
 : Cc: "Ilia Starkov" <star0413@ns4.cpcpipe.ru>, <bug-followup@freebsd.org>
 :
 : Maxim,
 :
 : I apply patch by hand and result is OK.
 : PPPD works fine.
 :
 : Thank you!
 : Ilia.
State-Changed-From-To: open->closed 
State-Changed-By: johan 
State-Changed-When: Tue Mar 25 10:52:03 PST 2003 
State-Changed-Why:  
This is a followup to PR kern/50163, which now has a reference to 
this PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50266 
>Unformatted:

