From jhb@FreeBSD.org  Wed Mar 12 08:43:59 2003
Return-Path: <jhb@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3C5F637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 12 Mar 2003 08:43:59 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D677043F85
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 12 Mar 2003 08:43:58 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: from freefall.freebsd.org (jhb@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h2CGhwNS091969
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 12 Mar 2003 08:43:58 -0800 (PST)
	(envelope-from jhb@freefall.freebsd.org)
Received: (from jhb@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h2CGhwr4091918;
	Wed, 12 Mar 2003 08:43:58 -0800 (PST)
Message-Id: <200303121643.h2CGhwr4091918@freefall.freebsd.org>
Date: Wed, 12 Mar 2003 08:43:58 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
Reply-To: John Baldwin <jhb@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Lack of error return for some proc sysctl's
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         49963
>Category:       kern
>Synopsis:       Lack of error return for some proc sysctl's
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rwatson
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 12 08:50:05 PST 2003
>Closed-Date:    Sun Aug 17 14:37:06 PDT 2003
>Last-Modified:  Sun Aug 17 14:37:06 PDT 2003
>Originator:     John Baldwin
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD laptop.baldwin.cx 5.0-CURRENT FreeBSD 5.0-CURRENT #799: Mon Mar 10 17:09:27 EST 2003 root@laptop.baldwin.cx:/usr/src/sys/i386/compile/LAPTOP i386

>Description:

	In /sys/kern/kern_proc.c sysctl_kern_proc() and sysctl_kern_proc_args()
	the functions return 0 (success) if we fail to find a process asked for
	by a specific PID or if p_cansee() fails for the process.  It would
	seem more intuitive to return ESRCH in those cases instead.

>How-To-Repeat:
>Fix:

Index: kern_proc.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_proc.c,v
retrieving revision 1.174
diff -u -r1.174 kern_proc.c
--- kern_proc.c 12 Mar 2003 16:14:55 -0000      1.174
+++ kern_proc.c 12 Mar 2003 16:43:04 -0000
@@ -865,10 +865,10 @@
                        return (EINVAL);
                p = pfind((pid_t)name[0]);
                if (!p)
-                       return (0);
+                       return (ESRCH);
                if (p_cansee(curthread, p)) {
                        PROC_UNLOCK(p);
-                       return (0);
+                       return (ESRCH);
                }
                error = sysctl_out_proc(p, req, 0);
                return (error);
@@ -1033,11 +1033,11 @@
 
        p = pfind((pid_t)name[0]);
        if (!p)
-               return (0);
+               return (ESRCH);
 
        if ((!ps_argsopen) && p_cansee(curthread, p)) {
                PROC_UNLOCK(p);
-               return (0);
+               return (ESRCH);
        }
 
        if (req->newptr && curproc != p) {

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rwatson 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Wed Mar 12 09:48:14 PST 2003 
Responsible-Changed-Why:  
Robert wanted this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=49963 
State-Changed-From-To: open->closed 
State-Changed-By: rwatson 
State-Changed-When: Sun Aug 17 14:34:47 PDT 2003 
State-Changed-Why:  
This was corrected in kern_proc.c:1.192 with a similar looking 
patch. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=49963 
>Unformatted:
