From nobody  Sun Nov  9 18:43:54 1997
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id SAA25768;
          Sun, 9 Nov 1997 18:43:54 -0800 (PST)
          (envelope-from nobody)
Message-Id: <199711100243.SAA25768@hub.freebsd.org>
Date: Sun, 9 Nov 1997 18:43:54 -0800 (PST)
From: kps@ucsb.edu
To: freebsd-gnats-submit@freebsd.org
Subject: atalk.diff.2.2 patch to 2.2.5-RELEASE breaks net/if_fddisubr.c
X-Send-Pr-Version: www-1.0

>Number:         4995
>Category:       kern
>Synopsis:       atalk.diff.2.2 patch to 2.2.5-RELEASE breaks net/if_fddisubr.c
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov  9 18:50:01 PST 1997
>Closed-Date:    Tue Jul 28 11:45:47 PDT 1998
>Last-Modified:  Tue Jul 28 11:46:09 PDT 1998
>Originator:     Kevin Schmidt
>Release:        2.2.5-RELEASE
>Organization:
UC Santa Barbara
>Environment:
FreeBSD guido.ucsb.edu 2.2.5-RELEASE FreeBSD 2.2.5-RELEASE #0: Thu Nov  6 17:57:14 PST 1997     root@guido.ucsb.edu:/usr/src/sys/compile/EMAIL  i386

>Description:
Kernel compile fails at net/if_fddisubr.c after atalk.diff.2.2 patches
(described in 2.2.5-RELEASE ERRATA.TXT) are applied.  Text:
cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-externs
-Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith  -nostdinc -I- -I. -I.
./.. -I../../../include -DNETATALK -DIPDIVERT -DIPACCT -DMFS -DPPS_SYNC -DFAILSA
FE -DCOMPAT_43 -DMSDOSFS -DNFS -DFFS -DINET -DKERNEL  ../../net/if_fddisubr.c
../../net/if_fddisubr.c: In function `fddi_output':
../../net/if_fddisubr.c:233: too many arguments to function `at_ifawithnet'
*** Error code 1

>How-To-Repeat:
Apply atalk.diff.2.2 to kernel sources and build kernel with 
'pseudo-device fddi' in config file.
>Fix:

>Release-Note:
>Audit-Trail:

From: Steve Price <sprice@hiwaay.net>
To: freebsd-gnats-submit@freebsd.org, kps@ucsb.edu
Cc:  Subject: Re: kern/4995: atalk.diff.2.2 patch to 2.2.5-RELEASE breaks net/if_fddisubr.c
Date: Sun, 22 Mar 1998 16:49:55 -0600

 Hi,
 
 I can't seem to find atalk.diff.2.2.  Can you tell
 where you retrieved it from?  Or better yet if you
 have found a solution to your problem. :)
 
 Steve

From: "Kevin P. Schmidt" <kps@eci1.ucsb.edu>
To: Steve Price <sprice@hiwaay.net>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/4995: atalk.diff.2.2 patch to 2.2.5-RELEASE breaks net/if_fddisubr.c 
Date: Sun, 22 Mar 1998 15:33:15 PST

 Greetings,
 
 Steve Price <sprice@hiwaay.net> may have said something like:
 > I can't seem to find atalk.diff.2.2.  Can you tell
 > where you retrieved it from?  Or better yet if you
 > have found a solution to your problem. :)
 
 The patch is listed in the 2.2.5-RELEASE ERRATA.TXT file,
 and can be found at:
   ftp://ftp.freebsd.org/pub/FreeBSD/2.2.5-RELEASE/updates/atalk.diff.2.2
 
 I haven't developed a fix as this was just a passing observation
 and not something I really used.  Within the time constraints of
 my job (i.e., usual restrictions) I'd be happy to invest some time
 towards resolving this.  From a quick glance, it appears the netatalk
 kernel support code changed some.  While the ethernet code was
 adjusted to match the netatalk changes, the fddi code was not
 touched by the patch, so its call to 'at_ifawithnet' was
 broken.
 
 Cheers,
 
 Kevin
 
 Kevin Schmidt                                kps@ucsb.edu
 Campus Network Programmer                    (805) 893-7779
 Engineering Computing Infrastructure         (805) 893-8553 FAX
 University of California, Santa Barbara      
 Santa Barbara, CA 93106                      

From: "Kevin P. Schmidt" <kps@eci1.ucsb.edu>
To: Steve Price <sprice@hiwaay.net>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/4995: atalk.diff.2.2 patch to 2.2.5-RELEASE breaks net/if_fddisubr.c 
Date: Mon, 23 Mar 1998 19:04:47 PST

 Steve,
 
 Re: The FDDI+NETATALK breakage introduce by atalk.diff.2.2,
 Steve Price <sprice@hiwaay.net> reportedly said:
 > Yes, if you come up with a fix or notice that it has
 > been fixed in 2.2.6 please let me know.  I will take
 > a look at the patch and make sure that it least works
 > for 2.2.6.
 
 I just installed 2.2.6-980322-BETA and copied the GENERIC
 kernel config, added "options NETATALK" and "pseudo-device fddi",
 and tried a compile.  No luck, blew up just like 2.2.5+atalk.diff.2.2,
 with same error as before:
 ../../net/if_fddisubr.c: In function `fddi_output':
 ../../net/if_fddisubr.c:233: too many arguments to function `at_ifawithnet'
 *** Error code 1
 
 It appears the atalk.diff.2.2 patch has been integrated into the
 sources for 2.2.6, though this still breaks the NETATALK conditional
 code in net/if_fddisubr.c.  The only thing to do at the moment
 is not to compile in both FDDI and NETATALK.
 
 More if I can get to it...  :-)
 
 Kevin
 
 Kevin Schmidt                                kps@ucsb.edu
 Campus Network Programmer                    (805) 893-7779
 Engineering Computing Infrastructure         (805) 893-8553 FAX
 University of California, Santa Barbara      
 Santa Barbara, CA 93106                      
State-Changed-From-To: open->closed 
State-Changed-By: stb 
State-Changed-When: Tue Jul 28 11:45:47 PDT 1998 
State-Changed-Why:  
Fixed by jkh in src/sys/net/if_fddisubr.c 1.9.2.5 (included in 
RELENG_2_2_7_RELEASE). 
>Unformatted:
