From kensmith@dcsl.Buffalo.EDU  Wed Jan 22 11:01:06 2003
Return-Path: <kensmith@dcsl.Buffalo.EDU>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 98FB137B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Jan 2003 11:01:06 -0800 (PST)
Received: from mack.dcsl.buffalo.edu (mack.dcsl.Buffalo.EDU [128.205.37.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AB93F43E4A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Jan 2003 11:01:05 -0800 (PST)
	(envelope-from kensmith@dcsl.Buffalo.EDU)
Received: from mack.dcsl.buffalo.edu (localhost [127.0.0.1])
	by mack.dcsl.buffalo.edu (8.12.6/8.12.4) with ESMTP id h0MJ0wCr000725;
	Wed, 22 Jan 2003 14:00:58 -0500 (EST)
Received: (from kensmith@localhost)
	by mack.dcsl.buffalo.edu (8.12.6/8.12.6/Submit) id h0MJ0wkI000724;
	Wed, 22 Jan 2003 14:00:58 -0500 (EST)
Message-Id: <200301221900.h0MJ0wkI000724@mack.dcsl.buffalo.edu>
Date: Wed, 22 Jan 2003 14:00:58 -0500 (EST)
From: Ken Smith <kensmith@dcsl.Buffalo.EDU>
Reply-To: Ken Smith <kensmith@dcsl.Buffalo.EDU>
To: FreeBSD-gnats-submit@freebsd.org
Cc: kensmith@dcsl.Buffalo.EDU
Subject: vinum driver creates /dev entries with wrong group/perms
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         47372
>Category:       kern
>Synopsis:       vinum driver creates /dev entries with wrong group/perms
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 22 11:10:01 PST 2003
>Closed-Date:    Sun Feb 02 13:38:32 PST 2003
>Last-Modified:  Sun Feb 02 13:38:32 PST 2003
>Originator:     Ken Smith
>Release:        FreeBSD 5.0-RELEASE i386
>Organization:
U. Buffalo CSE Department
>Environment:
System: FreeBSD mack.dcsl.Buffalo.EDU 5.0-RELEASE FreeBSD 5.0-RELEASE #1: Wed Jan 22 13:28:07 EST 2003 root@mack.dcsl.Buffalo.EDU:/usr/src/sys/i386/compile/MACK i386


	
>Description:
	All disk devices are in group operator and group-readable so things
	like Amanda can run as non-privileged users.  The vinum driver
	creates its /dev/vinum devices in group wheel with no group
	readability permissions.
>How-To-Repeat:
	Set up a vinum based volume, change the group ownership and permissions
	manually, then reboot.  Now that devfs is being used the changes
	don't survive a reboot.
>Fix:
	Patch attached below for file in /usr/src/sys/dev/vinum.  It seemed
	to work fine on my system...

*** vinumconfig.c_dist	Thu Dec 12 19:27:32 2002
--- vinumconfig.c	Wed Jan 22 13:27:53 2003
***************
*** 1564,1571 ****
          vol->dev = make_dev(&vinum_cdevsw,
              VINUMRMINOR(volno, VINUM_VOLUME_TYPE),
              UID_ROOT,
!             GID_WHEEL,
!             S_IRUSR | S_IWUSR,
              "vinum/%s",
              vol->name);
  }
--- 1564,1571 ----
          vol->dev = make_dev(&vinum_cdevsw,
              VINUMRMINOR(volno, VINUM_VOLUME_TYPE),
              UID_ROOT,
!             GID_OPERATOR,
!             S_IRUSR | S_IWUSR | S_IRGRP,
              "vinum/%s",
              vol->name);
  }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: anholt 
State-Changed-When: Sun Feb 2 13:35:56 PST 2003 
State-Changed-Why:  
Fixed in -current. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=47372 
>Unformatted:
