From iwaki@bc.niigata-u.ac.jp  Wed Dec 18 21:07:53 2002
Return-Path: <iwaki@bc.niigata-u.ac.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 81A2737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Dec 2002 21:07:53 -0800 (PST)
Received: from pikachu.bsp.bc.niigata-u.ac.jp (pikachu.bsp.bc.niigata-u.ac.jp [133.35.85.2])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9356743EE1
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Dec 2002 21:07:51 -0800 (PST)
	(envelope-from iwaki@bc.niigata-u.ac.jp)
Received: (qmail 7653 invoked by alias); 19 Dec 2002 14:07:38 +0900
Message-Id: <20021219050738.7651.qmail@pikachu.bsp.bc.niigata-u.ac.jp>
Date: Thu, 19 Dec 2002 14:06:29 +0900 (JST)
From: Mamoru Iwaki <iwaki@bc.niigata-u.ac.jp>
To: FreeBSD-gnats-submit@freebsd.org
Subject: MAXDEP in isa/pnpparse.c is too small
X-Send-Pr-Version: 3.113

>Number:         46368
>Category:       kern
>Synopsis:       [isa] [patch] MAXDEP in isa/pnpparse.c is too small
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 18 21:10:01 PST 2002
>Closed-Date:    Wed Jan 30 16:24:47 UTC 2008
>Last-Modified:  Wed Jan 30 16:30:01 UTC 2008
>Originator:     Mamoru Iwaki
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Niigata University
>Environment:
System: FreeBSD mi000.merlin.gs.niigata-u.ac.jp 4.7-STABLE FreeBSD 4.7-STABLE #0: Thu Dec 19 01:11:01 JST 2002 root@mi000.merlin.gs.niigata-u.ac.jp:/usr1/obj/usr/src/sys/MI i386


	
>Description:
	
On booting my machine, it always displays and log the 
following message.  

isa0: too many dependant configs (8)

I don't know how serious it is, but it looks bad for 
arbitration of computer resources in PnP/isa.  

On my system, pnpinfo reports as follows.  

# pnpinfo | grep Device
Device Description: Creative SB AWE64 PnP
Logical Device ID: CTL0042 0x42008c0e #0
Device Description: Audio
Logical Device ID: CTL7002 0x02708c0e #1
Compatible Device ID: PNPb02f (2fb0d041)
Device Description: Game
Logical Device ID: CTL0022 0x22008c0e #2
Device Description: WaveTable
Logical Device ID: CTL2011 0x11208c0e #3
Compatible Device ID: PNP0600 (0006d041)
Device Description: IDE

>How-To-Repeat:
	
>Fix:

	

In line 39, isa/pnpparse.c has a constant named MAXDEP, 
which is set to 8 now.  Simply changing the value from 
8 to 16 like

   - #define MAXDEP  8
   + #define MAXDEP  16

the message has disappeared.  I hope the value is 
independent of other parts, and a more preferable value 
is set in the future releases.  
>Release-Note:
>Audit-Trail:

From: Mamoru Iwaki <iwaki@bc.niigata-u.ac.jp>
To: freebsd-gnats-submit@FreeBSD.org, iwaki@bc.niigata-u.ac.jp
Cc:  
Subject: Re: kern/46368: MAXDEP in isa/pnpparse.c is too small
Date: Sat, 21 Dec 2002 00:32:32 +0900 (JST)

 I found another solution in the following change for 5-current.  
 Applying this change to sys/isa/pnpparse.c, the message has disappeared.  
 I hope this change should be merged into the 4-stable.  
 
 - *	$FreeBSD: /home/ncvs/src/sys/isa/pnpparse.c,v 1.5 2000/03/31 19:35:41 dfr Exp $
 + *	$FreeBSD: /home/ncvs/src/sys/isa/pnpparse.c,v 1.6 2000/04/04 07:48:04 dfr Exp $
 
  				}
 -				if (ncfgs >= MAXDEP) {
 +				if (ncfgs > MAXDEP) {
  					device_printf(parent, "too many dependant configs (%d)\n", MAXDEP);
 
 ---
 -----
 Mamoru IWAKI   (iwaki@bc.niigata-u.ac.jp)
 Graduate School of Science and Technology, Niigata University
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Wed Jan 30 16:24:31 UTC 2008 
State-Changed-Why:  
Fix MFC'd. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46368 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/46368: commit references a PR
Date: Wed, 30 Jan 2008 16:24:48 +0000 (UTC)

 jhb         2008-01-30 16:24:25 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_4)
     sys/isa              pnpparse.c 
   Log:
   MFC 1.6: Allow MAXDEP dependants, not MAXDEP-1.
   
   PR:             kern/46368
   
   Revision  Changes    Path
   1.2.2.4   +2 -2      src/sys/isa/pnpparse.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
