From mcgovern@tick.beta.com  Wed Dec  4 20:13:22 2002
Return-Path: <mcgovern@tick.beta.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2360B37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Dec 2002 20:13:22 -0800 (PST)
Received: from tick.beta.com (tick.beta.com [199.165.180.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2FF2543E9C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Dec 2002 20:13:21 -0800 (PST)
	(envelope-from mcgovern@tick.beta.com)
Received: from tick.beta.com (localhost.beta.com [127.0.0.1])
	by tick.beta.com (8.12.6/8.12.6) with ESMTP id gB54DAG0000654
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 4 Dec 2002 23:13:10 -0500 (EST)
	(envelope-from mcgovern@tick.beta.com)
Received: (from mcgovern@localhost)
	by tick.beta.com (8.12.6/8.12.6/Submit) id gB54D9k6000653;
	Wed, 4 Dec 2002 23:13:09 -0500 (EST)
Message-Id: <200212050413.gB54D9k6000653@tick.beta.com>
Date: Wed, 4 Dec 2002 23:13:09 -0500 (EST)
From: "Brian J. McGovern" <mcgovern@tick.beta.com>
Reply-To: "Brian J. McGovern" <mcgovern@tick.beta.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Add support for Trek Thumbdrive 8MB USB drive
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         46004
>Category:       kern
>Synopsis:       Add support for Trek Thumbdrive 8MB USB drive
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 04 20:20:01 PST 2002
>Closed-Date:    Fri Jan 31 14:37:20 PST 2003
>Last-Modified:  Fri Jan 31 14:37:20 PST 2003
>Originator:     Brian J. McGovern
>Release:        FreeBSD 5.0-DP2 i386
>Organization:
B.E.T.A.
>Environment:
System: FreeBSD tick.beta.com 5.0-DP2 FreeBSD 5.0-DP2 #7: Mon Dec 2 21:20:49 EST 2002 root@tick.beta.com:/usr/src/sys/i386/compile/TICK i386
>Description:
	The attached patches will add support for the Trek Smart Thumbdrives
	(8MB model) to the umass driver, allowing the mounting of the disk
	via a msdos filesystem. It is expected that the other sizes can also
	be supported via differing product codes. Unfortunately, hardware 
	of the larger sizes is unavailable at this time (although I will
	continue to bother Trek to provide it). In any event, this patch
	should be applied to provide a template for users with similar
	hardware to cut, paste, and edit. 
>How-To-Repeat:
	No need to repeat. Its an added feature.
>Fix:
	Diffs follow. If it is needed in a different format, please ask, and
	I can provide it quickly.

diff -u usb/umass.c usb.new/umass.c
--- usb/umass.c	Sat Nov 16 04:07:50 2002
+++ usb.new/umass.c	Mon Dec  2 21:20:39 2002
@@ -323,6 +323,11 @@
 };
 
 Static struct umass_devdescr_t umass_devdescrs[] = {
+	{ USB_VENDOR_TREK, USB_PRODUCT_TREK_THUMBDRIVE_8MB, RID_WILDCARD,
+	  UMASS_PROTO_ATAPI | UMASS_PROTO_BBB,
+	  IGNORE_RESIDUE
+/* | NO_TEST_UNIT_READY */
+	},
 	{ USB_VENDOR_FUJIPHOTO, USB_PRODUCT_FUJIPHOTO_MASS0100, RID_WILDCARD,
 	  UMASS_PROTO_ATAPI | UMASS_PROTO_CBI_I,
 	  RS_NO_CLEAR_UA
diff -u usb/usbdevs usb.new/usbdevs
--- usb/usbdevs	Sat Nov 16 04:07:50 2002
+++ usb.new/usbdevs	Mon Dec  2 20:10:28 2002
@@ -1068,6 +1068,7 @@
 
 /* Trek Technology products */
 product TREK THUMBDRIVE		0x1111	ThumbDrive
+product TREK THUMBDRIVE		0x9988	ThumbDrive
 
 /* Ultima products */
 product ULTIMA 1200UBPLUS	0x4002	1200 UB Plus scanner
diff -u usb/usbdevs.h usb.new/usbdevs.h
--- usb/usbdevs.h	Sat Nov 16 04:07:50 2002
+++ usb.new/usbdevs.h	Mon Dec  2 20:12:13 2002
@@ -1076,6 +1076,8 @@
 /* Trek Technology products */
 #define	USB_PRODUCT_TREK_THUMBDRIVE	0x1111		/* ThumbDrive */
 
+#define USB_PRODUCT_TREK_THUMBDRIVE_8MB	0x9988		/* ThumbDrive */
+
 /* Ultima products */
 #define	USB_PRODUCT_ULTIMA_1200UBPLUS	0x4002		/* 1200 UB Plus scanner */
 
diff -u usb/usbdevs_data.h usb.new/usbdevs_data.h
--- usb/usbdevs_data.h	Sat Nov 16 04:07:50 2002
+++ usb.new/usbdevs_data.h	Mon Dec  2 20:13:48 2002
@@ -2571,6 +2571,13 @@
 	    "Trek Technology",
 	    "ThumbDrive",
 	},
+
+	{
+	    USB_VENDOR_TREK, USB_PRODUCT_TREK_THUMBDRIVE_8MB,
+	    0,
+	    "Trek Technology",
+	    "ThumbDrive",
+	},
 	{
 	    USB_VENDOR_ULTIMA, USB_PRODUCT_ULTIMA_1200UBPLUS,
 	    0,

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->trhodes 
Responsible-Changed-By: trhodes 
Responsible-Changed-When: Fri Dec 6 12:29:51 PST 2002 
Responsible-Changed-Why:  
Not really a bug, new feature.  And I'd like to work on it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46004 

From: Ceri Davies <setantae@submonkey.net>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: kern/46004
Date: Wed, 1 Jan 2003 19:41:24 +0000

 Adding to audit trail, obtained from misfiled PR 46509.
 On Tue, Dec 24, 2002 at 01:10:20AM -0500, Tom Rhodes wrote:
 >  
 >  Brian, this patch doesn't apply cleanly, could you by some chance
 >  send me a newer patch?  I tried to email you before but it
 >  bounced for some reason.
 >  
 >  Thanks!
 >  
 >  --
 >  Tom Rhodes

From: "Brian J. McGovern" <mcgovern@beta.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/46004: Add support for Trek Thumbdrive 8MB USB drive
Date: Mon, 27 Jan 2003 20:31:21 -0500

 This is a multi-part message in MIME format.
 --------------070107020607080506040805
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Here is a new patch against 5.0-RELEASE that should apply cleanly.
     -Brian
 
 --------------070107020607080506040805
 Content-Type: text/plain;
  name="trek.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="trek.diff"
 
 diff -r src/sys/dev/usb/umass.c /usr/src/sys/dev/usb/umass.c
 372c372,375
 < 
 ---
 > 	{ USB_VENDOR_TREK,  USB_PRODUCT_TREK_THUMBDRIVE_8MB, RID_WILDCARD,
 >           UMASS_PROTO_ATAPI | UMASS_PROTO_BBB,
 > 	  IGNORE_RESIDUE
 > 	},
 diff -r src/sys/dev/usb/usbdevs /usr/src/sys/dev/usb/usbdevs
 1070a1071
 > product TREK THUMBDRIVE_8MB	0x9988	ThumbDrive_8MB
 diff -r src/sys/dev/usb/usbdevs.h /usr/src/sys/dev/usb/usbdevs.h
 1077a1078
 > #define USB_PRODUCT_TREK_THUMBDRIVE_8MB	0x9988		/* ThumbDrive 8MB */
 
 --------------070107020607080506040805--
 
State-Changed-From-To: open->patched 
State-Changed-By: trhodes 
State-Changed-When: Thu Jan 30 10:40:22 PST 2003 
State-Changed-Why:  
Patch applied with a minor modification.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46004 
State-Changed-From-To: patched->closed 
State-Changed-By: trhodes 
State-Changed-When: Fri Jan 31 14:36:58 PST 2003 
State-Changed-Why:  
Applied to STABLE today.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46004 
>Unformatted:
