From dgilbert@velocet.ca  Mon Nov 11 12:20:54 2002
Return-Path: <dgilbert@velocet.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EA2C37B404
	for <freebsd-gnats-submit@freebsd.org>; Mon, 11 Nov 2002 12:20:54 -0800 (PST)
Received: from sabre.velocet.net (sabre.velocet.net [216.138.209.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F27FD43E3B
	for <freebsd-gnats-submit@freebsd.org>; Mon, 11 Nov 2002 12:20:53 -0800 (PST)
	(envelope-from dgilbert@velocet.ca)
Received: from trooper.velocet.ca (trooper.velocet.net [216.138.242.2])
	by sabre.velocet.net (Postfix) with ESMTP id 1A01B137FD7
	for <freebsd-gnats-submit@freebsd.org>; Mon, 11 Nov 2002 15:20:48 -0500 (EST)
Received: by trooper.velocet.ca (Postfix, from userid 66)
	id DB71074335; Mon, 11 Nov 2002 15:20:47 -0500 (EST)
Received: by canoe.velocet.net (Postfix, from userid 101)
	id 54D7456766D; Mon, 11 Nov 2002 15:20:45 -0500 (EST)
Message-Id: <20021111202045.54D7456766D@canoe.velocet.net>
Date: Mon, 11 Nov 2002 15:20:45 -0500 (EST)
From: David Gilbert <dgilbert@velocet.ca>
Reply-To: David Gilbert <dgilbert@velocet.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Source Quench packets should not be generated by routers
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45223
>Category:       kern
>Synopsis:       Source Quench packets should not be generated by routers
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    silby
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 11 12:30:01 PST 2002
>Closed-Date:    Sat Nov 30 23:20:36 PST 2002
>Last-Modified:  Sat Nov 30 23:20:36 PST 2002
>Originator:     David Gilbert
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Velocet Communications
>Environment:
System: FreeBSD canoe.velocet.net 4.7-STABLE FreeBSD 4.7-STABLE #8: Fri Nov 1 18:01:25 EST 2002 dgilbert@canoe.velocet.net:/usr/src/sys/compile/CANOE i386

AFAIK, all FreeBSD is affected by this.

>Description:
RFC 1812 says that source quench packets should not be generated by
routers.  Doing so causes DOS amplification.
>How-To-Repeat:
DOS a FreeBSD router.  You can see a 100M full of source quench if your
router is powerful enough.
>Fix:

--- /sys/netinet/ip_input.c     Thu Oct 17 08:29:53 2002
+++ ip_input.c  Mon Nov 11 15:15:31 2002
@@ -1822,9 +1822,7 @@
                break;
 
        case ENOBUFS:
-               type = ICMP_SOURCEQUENCH;
-               code = 0;
-               break;
+               return;
 
        case EACCES:                    /* ipfw denied packet */
                m_freem(mcopy);



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->silby 
Responsible-Changed-By: silby 
Responsible-Changed-When: Mon Nov 11 23:20:33 PST 2002 
Responsible-Changed-Why:  
I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45223 
State-Changed-From-To: open->closed 
State-Changed-By: silby 
State-Changed-When: Sat Nov 30 23:20:08 PST 2002 
State-Changed-Why:  
A modified version of this has been committed to -current, and MFC'd. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45223 
>Unformatted:
