From nobody@FreeBSD.org  Tue Nov  5 09:20:56 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6B62137B401
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Nov 2002 09:20:56 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2943743E88
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Nov 2002 09:20:56 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.6/8.12.6) with ESMTP id gA5HKt7R081726
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 5 Nov 2002 09:20:56 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.6/8.12.6/Submit) id gA5HKtH9081725;
	Tue, 5 Nov 2002 09:20:55 -0800 (PST)
Message-Id: <200211051720.gA5HKtH9081725@www.freebsd.org>
Date: Tue, 5 Nov 2002 09:20:55 -0800 (PST)
From: Bodo Rskamp <jordbaer@mac.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ng_pppoe: relay session identifier does not match value in RFC
X-Send-Pr-Version: www-1.0

>Number:         44936
>Category:       kern
>Synopsis:       ng_pppoe: relay session identifier does not match value in RFC
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dwmalone
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 05 09:30:01 PST 2002
>Closed-Date:    Tue Mar 30 06:03:44 PST 2004
>Last-Modified:  Tue Mar 30 06:03:44 PST 2004
>Originator:     Bodo Rskamp
>Release:        FreeBSD 4.6.2
>Organization:
>Environment:
>Description:
      The value for the Relay-Session-ID is 0x0110 (per RFC 2516), but in ng_pppoe.h the value is 0x0106...
>How-To-Repeat:
      use the Roaring Penguin PPPoE Relay to connect to the FreeBSD pppoed
>Fix:
*** ng_pppoe.h
--- ng_pppoe.h
***************
*** 145,151 ****
  #define PTT_HOST_UNIQ	(0x0103)
  #define PTT_AC_COOKIE	(0x0104)
  #define PTT_VENDOR 	(0x0105)
! #define PTT_RELAY_SID	(0x0106)
  #define PTT_SRV_ERR     (0x0201)
  #define PTT_SYS_ERR  	(0x0202)
  #define PTT_GEN_ERR  	(0x0203)
--- 145,151 ----
  #define PTT_HOST_UNIQ	(0x0103)
  #define PTT_AC_COOKIE	(0x0104)
  #define PTT_VENDOR 	(0x0105)
! #define PTT_RELAY_SID	(0x0110)
  #define PTT_SRV_ERR     (0x0201)
  #define PTT_SYS_ERR  	(0x0202)
  #define PTT_GEN_ERR  	(0x0203)
***************
*** 161,167 ****
  #define PTT_HOST_UNIQ	(0x0301)
  #define PTT_AC_COOKIE	(0x0401)
  #define PTT_VENDOR 	(0x0501)
! #define PTT_RELAY_SID	(0x0601)
  #define PTT_SRV_ERR     (0x0102)
  #define PTT_SYS_ERR  	(0x0202)
  #define PTT_GEN_ERR  	(0x0302)
--- 161,167 ----
  #define PTT_HOST_UNIQ	(0x0301)
  #define PTT_AC_COOKIE	(0x0401)
  #define PTT_VENDOR 	(0x0501)
! #define PTT_RELAY_SID	(0x1001)
  #define PTT_SRV_ERR     (0x0102)
  #define PTT_SYS_ERR  	(0x0202)
  #define PTT_GEN_ERR  	(0x0302)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Wed Mar 17 04:43:46 PST 2004 
Responsible-Changed-Why:  
I've rediscovered this bug, so I'll look into committing the the patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44936 
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Tue Mar 30 06:03:10 PST 2004 
State-Changed-Why:  
Now fixed in -current and -stable. Thanks for the patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44936 
>Unformatted:
