From ast@marabu.ch  Mon Nov  4 00:56:14 2002
Return-Path: <ast@marabu.ch>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2221237B401; Mon,  4 Nov 2002 00:56:14 -0800 (PST)
Received: from oneplusone.ch (oneplusone.ch [212.55.208.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D60F543E8A; Mon,  4 Nov 2002 00:56:12 -0800 (PST)
	(envelope-from ast@marabu.ch)
Received: from oneplusone.ch (localhost [127.0.0.1])
	by oneplusone.ch (8.12.3/8.12.3) with ESMTP id gA48u3vX025315;
	Mon, 4 Nov 2002 09:56:04 +0100 (MET)
	(envelope-from ast@marabu.ch)
Received: (from uucp@localhost)
	by oneplusone.ch (8.12.3/8.12.3/Submit) with UUCP id gA48u3Kd025314;
	Mon, 4 Nov 2002 09:56:03 +0100 (MET)
Received: (from ast@localhost)
	by marabu.ch (8.11.6/8.11.6) id gA48mAx37336;
	Mon, 4 Nov 2002 09:48:10 +0100 (MET)
	(envelope-from ast)
Message-Id: <200211040848.gA48mAx37336@marabu.ch>
Date: Mon, 4 Nov 2002 09:48:10 +0100 (MET)
From: Adrian Steinmann <ast@marabu.ch>
Reply-To: Adrian Steinmann <ast@marabu.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: sos@freebsd.org
Subject: kernel config now requires atapicd with ata, atadisk
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         44873
>Category:       kern
>Synopsis:       kernel config now requires atapicd with ata, atadisk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 04 01:00:13 PST 2002
>Closed-Date:    Mon Nov 04 04:17:56 PST 2002
>Last-Modified:  Mon Nov 04 04:17:56 PST 2002
>Originator:     Adrian Steinmann
>Release:        -stable
>Organization:
Webgroup Consulting AG
>Environment:
System: FreeBSD nano.marabu.ch 4.6.2-STYX FreeBSD 4.6.2-STYX #0: Tue Apr 16 11:06:34 GMT 2002 root@rumori.com:/usr/src/sys/compile/STYX i386

>Description:
	kernel config with ata supports needs additional line to compile

>How-To-Repeat:

A kernel config file with only
	device ata
	device atadisk
but no
	device atapicd
will fail to make buildkernel (this used to work up to 4_7_0_RELEASE):

cc -c -Os -pipe  -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi  -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter  -D_KERNEL -include opt_global.h -elf  -mpreferred-stack-boundary=2  ../../dev/ata/ata-card.c
../../dev/ata/ata-all.c:599: warning: type defaults to `int' in declaration of `splx'
../../dev/ata/ata-all.c:599: warning: parameter names (without types) in function declaration
../../dev/ata/ata-all.c:599: conflicting types for `splx'
../../sys/systm.h:257: previous declaration of `splx'
../../dev/ata/ata-all.c:599: warning: redundant redeclaration of `splx' in same scope
../../sys/systm.h:257: warning: previous declaration of `splx'
../../dev/ata/ata-all.c:599: warning: data definition has no type or storage class
../../dev/ata/ata-all.c:600: syntax error before `}'
../../dev/ata/ata-all.c:65: warning: `ata_cdevsw' defined but not used
../../dev/ata/ata-all.c:540: warning: `ata_boot_attach' defined but not used
../../dev/ata/ata-all.c:83: warning: `ata_intr' used but never defined
../../dev/ata/ata-all.c:85: warning: `ata_service' declared `static' but never defined
../../dev/ata/ata-all.c:86: warning: `bswap' used but never defined
../../dev/ata/ata-all.c:87: warning: `btrim' used but never defined
../../dev/ata/ata-all.c:88: warning: `bpack' used but never defined
../../dev/ata/ata-all.c:89: warning: `ata_change_mode' used but never defined
../../dev/ata/ata-all.c:90: warning: `ata_drawersensor' used but never defined
*** Error code 1
cc -c -Os -pipe  -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi  -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter  -D_KERNEL -include opt_global.h -elf  -mpreferred-stack-boundary=2  ../../dev/ata/ata-disk.c
1 error
*** Error code 2

Stop in /root/build.
*** Error code 1

Stop in /root/build.

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: roam 
State-Changed-When: Mon Nov 4 01:23:30 PST 2002 
State-Changed-Why:  
This was fixed in rev. 1.50.2.42 of src/sys/dev/ata/ata-all.c 
by Thomas Moestl about two days ago, wasn't it? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44873 

From: Peter Pentchev <roam@ringlet.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/44873: kernel config now requires atapicd with ata, atadisk
Date: Mon, 4 Nov 2002 12:59:31 +0200

 Adding the originator's response to the audit trail..
 
 ----- Forwarded message from Adrian Steinmann <ast@marabu.ch> -----
 
 From: Adrian Steinmann <ast@marabu.ch>
 Date: Mon,  4 Nov 2002 11:47:25 +0100
 To: Peter Pentchev <roam@FreeBSD.org>
 Subject: Re: kern/44873: kernel config now requires atapicd with ata, atadisk
 Cc: freebsd-bugs@FreeBSD.org
 
 Peter Pentchev <roam@FreeBSD.org> wrote:
 
    This was fixed in rev. 1.50.2.42 of src/sys/dev/ata/ata-all.c
 
 Ah, yes, I was building against 1.50.2.41, 1.50.2.42 works for me!
 
 Thanks
 Adrian
 
 ----- End forwarded message -----
State-Changed-From-To: feedback->closed 
State-Changed-By: roam 
State-Changed-When: Mon Nov 4 04:17:19 PST 2002 
State-Changed-Why:  
The originator confirms that thomas's follow-up commit has indeed 
fixed the problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44873 
>Unformatted:
