From nobody@FreeBSD.org  Tue Oct 29 02:55:24 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2732437B401
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Oct 2002 02:55:24 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB1ED43E3B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Oct 2002 02:55:23 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.6/8.12.6) with ESMTP id g9TAtN7R055644
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Oct 2002 02:55:23 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.6/8.12.6/Submit) id g9TAtNnR055643;
	Tue, 29 Oct 2002 02:55:23 -0800 (PST)
Message-Id: <200210291055.g9TAtNnR055643@www.freebsd.org>
Date: Tue, 29 Oct 2002 02:55:23 -0800 (PST)
From: Jay Rossiter <cryptographite@attbi.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dev/dpt/dpt.h is missing defines required for DPT_HANDLE_TIMEOUTS kernel option
X-Send-Pr-Version: www-1.0

>Number:         44587
>Category:       kern
>Synopsis:       dev/dpt/dpt.h is missing defines required for DPT_HANDLE_TIMEOUTS kernel option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sbruno
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 29 03:00:03 PST 2002
>Closed-Date:    Wed Apr 10 23:40:02 UTC 2013
>Last-Modified:  Wed Apr 10 23:40:02 UTC 2013
>Originator:     Jay Rossiter
>Release:        4.7
>Organization:
>Environment:
FreeBSD zen 4.7-STABLE FreeBSD 4.7-STABLE #30: Mon Oct 28 15:02:25 PST 2002 root@zen:/usr/obj/usr/src/sys/ZEN  i386
>Description:
After seeing some CCB Timeout errors using my DPT SCSI card, I tried
enabling the "DPT_HANDLE_TIMEOUTS" option listed in lint.  The build
broke with missing defines.  I've just checked CVS, and it appears
that the necessary defines were removed _four years ago_.  The code
has never been updated to reflect the fact.
>How-To-Repeat:
Add to kernel config file and build:

device dpt
options DPT_HANDLE_TIMEOUTS
>Fix:
It is not known if reinserting the defines will solve the issue or not.
The defines were removed from dpt.h in revision 1.2 - they were added
in 1.1.  File is currently revision 1.12.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-scsi 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 30 23:50:28 GMT 2004 
Responsible-Changed-Why:  
Seems to be a bug in a SCSI driver. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44587 

From: Sean Bruno <seanwbruno@gmail.com>
To: bug-followup@FreeBSD.org, cryptographite@attbi.com
Cc:  
Subject: Re: kern/44587: dev/dpt/dpt.h is missing defines required for
 DPT_HANDLE_TIMEOUTS kernel option
Date: Mon, 08 Apr 2013 22:09:33 -0700

 --=-1oVZYsh6Um1nxKGSj3ob
 Content-Type: text/plain; charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable
 
 setting DPT_HANDLE_TIMEOUTS as a kernel config options definitely does
 not work any more.
 
 sys/sys/dpt.h was deleted at svn r39402 ish
 
 sys/dev/dpt.h was added at svn r39234 as a replacement
 
 This happened with the implementation of CAM support of dpt(4).
 
 The method used for "option DPT_HANDLE_TIMEOUTS" is completely useless
 and should be removed alltogether at this point.=20
 
 --=-1oVZYsh6Um1nxKGSj3ob
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.13 (FreeBSD)
 
 iQEcBAABAgAGBQJRY6KFAAoJEBkJRdwI6BaH1uEH/jmnlZgMq9j+BMeUmieThPls
 wR1kCi11WK9BT7YHSfQ3pvIHzlhEAcy6BFiwcT3iPeqa29Y/eTFInQHNHvQyerWa
 xRmMVYO5YU+SPJRSDdvXZ0HL+F0VOTxOx7kh890HP4luwN7EfAyvHZqCPdIBHR95
 RCb6UxfrwLC6MvQ01lZNoq/m/q9fjWj4TGqful1Vg+uvBNxe/QbORWHk54dzykhQ
 DvZMipMwBk/QhHyXGcAaAz0r0in/J8QdZnjAJiHucEWhqqqQJ17wXFAlcPLhlm1M
 N+W7+1FspYVcA1qQxRGFWw0qoC1F2yYVnuoIfQ0Yfpy9mK2f9jIs/nVqTcXYpjI=
 =mDKR
 -----END PGP SIGNATURE-----
 
 --=-1oVZYsh6Um1nxKGSj3ob--
 

From: Sean Bruno <seanwbruno@gmail.com>
To: bug-followup@FreeBSD.org, cryptographite@attbi.com
Cc:  
Subject: Re: kern/44587: dev/dpt/dpt.h is missing defines required for
 DPT_HANDLE_TIMEOUTS kernel option
Date: Tue, 09 Apr 2013 12:46:56 -0700

 --=-TtB46BOqDEW7zUEpuqRD
 Content-Type: multipart/mixed; boundary="=-djHxNd34EOkbkEVteM/S"
 
 
 --=-djHxNd34EOkbkEVteM/S
 Content-Type: text/plain; charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable
 
 I propose the following as DPT_HANDLE_TIMEOUTS can't possibly work.  We
 should nuke it and be done with it.
 
 
 
 --=-djHxNd34EOkbkEVteM/S
 Content-Disposition: attachment; filename="dpt_handle_timeouts_delete.txt"
 Content-Type: text/plain; name="dpt_handle_timeouts_delete.txt"; charset="us-ascii"
 Content-Transfer-Encoding: base64
 
 SW5kZXg6IHN5cy9jb25mL05PVEVTDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lzL2NvbmYvTk9URVMJKHJl
 dmlzaW9uIDI0OTMxNCkNCisrKyBzeXMvY29uZi9OT1RFUwkod29ya2luZyBjb3B5KQ0KQEAgLTE2
 MjYsMTAgKzE2MjYsNiBAQA0KICMgICBEUFRfTUVBU1VSRV9QRVJGT1JNQU5DRSBFbmFibGVzIGEg
 c2V0IG9mIChzZW1pKWludmFzaXZlIG1ldHJpY3MuIFZhcmlvdXMNCiAjICAgICAgICAgICAgICAg
 ICAgICAgICAgICAgaW5zdHJ1bWVudHMgYXJlIGVuYWJsZWQuICBUaGUgdG9vbHMgaW4NCiAjICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgL3Vzci9zYmluL2RwdF8qIGFzc3VtZSB0aGVzZSB0byBi
 ZSBlbmFibGVkLg0KLSMgICBEUFRfSEFORExFX1RJTUVPVVRTICAgICBOb3JtYWxseSBkZXZpY2Ug
 dGltZW91dHMgYXJlIGhhbmRsZWQgYnkgdGhlIERQVC4NCi0jICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgSWYgeW91IHdhbnQgdGhlIGRyaXZlciB0byBoYW5kbGUgdGltZW91dHMsIGVuYWJsZQ0K
 LSMgICAgICAgICAgICAgICAgICAgICAgICAgICB0aGlzIG9wdGlvbi4gIElmIHlvdXIgc3lzdGVt
 IGlzIHZlcnkgYnVzeSwgdGhpcw0KLSMgICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb24g
 d2lsbCBjcmVhdGUgbW9yZSB0cm91YmxlIHRoYW4gc29sdmUuDQogIyAgIERQVF9USU1FT1VUX0ZB
 Q1RPUiAgICAgIFVzZWQgdG8gY29tcHV0ZSB0aGUgZXhjZXNzaXZlIGFtb3VudCBvZiB0aW1lIHRv
 DQogIyAgICAgICAgICAgICAgICAgICAgICAgICAgIHdhaXQgd2hlbiB0aW1pbmcgb3V0IHdpdGgg
 dGhlIGFib3ZlIG9wdGlvbi4NCiAjICBEUFRfREVCVUdfeHh4eCAgICAgICAgICAgVGhlc2UgYXJl
 IGNvbnRyb2xsYWJsZSBmcm9tIHN5cy9kZXYvZHB0L2RwdC5oDQpAQCAtMTY0NSw3ICsxNjQxLDYg
 QEANCiANCiAjIERQVCBvcHRpb25zDQogIyFDQU0jIG9wdGlvbnMgCURQVF9NRUFTVVJFX1BFUkZP
 Uk1BTkNFDQotIyFDQU0jIG9wdGlvbnMgCURQVF9IQU5ETEVfVElNRU9VVFMNCiBvcHRpb25zIAlE
 UFRfVElNRU9VVF9GQUNUT1I9NA0KIG9wdGlvbnMgCURQVF9MT1NUX0lSUQ0KIG9wdGlvbnMgCURQ
 VF9SRVNFVF9IQkENCkluZGV4OiBzeXMvY29uZi9vcHRpb25zDQo9PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lz
 L2NvbmYvb3B0aW9ucwkocmV2aXNpb24gMjQ5MzE0KQ0KKysrIHN5cy9jb25mL29wdGlvbnMJKHdv
 cmtpbmcgY29weSkNCkBAIC01MzQsNyArNTM0LDYgQEANCiANCiAjIERQVCBkcml2ZXIgZGVidWcg
 ZmxhZ3MNCiBEUFRfTUVBU1VSRV9QRVJGT1JNQU5DRQlvcHRfZHB0LmgNCi1EUFRfSEFORExFX1RJ
 TUVPVVRTCW9wdF9kcHQuaA0KIERQVF9USU1FT1VUX0ZBQ1RPUglvcHRfZHB0LmgNCiBEUFRfTE9T
 VF9JUlEJCW9wdF9kcHQuaA0KIERQVF9SRVNFVF9IQkEJCW9wdF9kcHQuaA0KSW5kZXg6IHN5cy9k
 ZXYvZHB0L2RwdC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lzL2Rldi9kcHQvZHB0LmgJKHJldmlzaW9u
 IDI0OTMxNCkNCisrKyBzeXMvZGV2L2RwdC9kcHQuaAkod29ya2luZyBjb3B5KQ0KQEAgLTExMTUs
 MTAgKzExMTUsNiBAQA0KICNkZWZpbmUgRFBUX0xPU1RfSVJRX0FDVElWRQkweDIwMDAwMDAwDQog
 I2VuZGlmDQogCQ0KLSNpZmRlZiBEUFRfSEFORExFX1RJTUVPVVRTDQotI2RlZmluZSBEUFRfSEFf
 VElNRU9VVFNfU0VUCTB4NDAwMDAwMDANCi0jZGVmaW5lIERQVF9IQV9USU1FT1VUU19BQ1RJVkUJ
 MHg4MDAwMDAwMA0KLSNlbmRpZg0KIA0KIAl1X2ludDhfdCAgcHJpbWFyeTsJLyogdHJ1ZSBpZiBw
 cmltYXJ5ICovCQ0KIA0KSW5kZXg6IHN5cy9kZXYvZHB0L2RwdF9zY3NpLmMNCj09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
 Ci0tLSBzeXMvZGV2L2RwdC9kcHRfc2NzaS5jCShyZXZpc2lvbiAyNDkzMTQpDQorKysgc3lzL2Rl
 di9kcHQvZHB0X3Njc2kuYwkod29ya2luZyBjb3B5KQ0KQEAgLTE2MzIsOSArMTYzMiw2IEBADQog
 CQkJICAgICAgICJjbGVhciBFT0MuXG4gICAgIE1hcmtpbmcgYXMgTE9TVC5cbiIsDQogCQkJICAg
 ICAgIGRjY2ItPnRyYW5zYWN0aW9uX2lkKTsNCiANCi0jaWZkZWYgRFBUX0hBTkRMRV9USU1FT1VU
 Uw0KLQkJCWRjY2ItPnN0YXRlIHw9IERQVF9DQ0JfU1RBVEVfTUFSS0VEX0xPU1Q7DQotI2VuZGlm
 DQogCQkJLyogVGhpcyBDTEVBUlMgdGhlIGludGVycnVwdCEgKi8NCiAJCQlzdGF0dXMgPSBkcHRf
 aW5iKGRwdCwgSEFfUlNUQVRVUyk7DQogCQkJY29udGludWU7DQpAQCAtMjUyNCwxNTQgKzI1MjEs
 NCBAQA0KIAlyZXR1cm47DQogfQ0KIA0KLSNpZmRlZiBEUFRfSEFORExFX1RJTUVPVVRTDQotLyoq
 DQotICogVGhpcyBmdW5jdGlvbiB3YWxrcyBkb3duIHRoZSBTVUJNSVRURUQgcXVldWUuDQotICog
 RXZlcnkgcmVxdWVzdCB0aGF0IGlzIHRvbyBvbGQgZ2V0cyBhYm9ydGVkIGFuZCBtYXJrZWQuDQot
 ICogU2luY2UgdGhlIERQVCB3aWxsIGNvbXBsZXRlIChpbnRlcnJ1cHQpIGltbWVkaWF0ZWx5ICh3
 aGF0IGRvZXMgdGhhdCBtZWFuPyksDQotICogV2UganVzdCB3YWxrIHRoZSBsaXN0LCBhYm9ydGlu
 ZyBvbGQgY29tbWFuZHMgYW5kIG1hcmtpbmcgdGhlbSBhcyBzdWNoLg0KLSAqIFRoZSBkcHRfY29t
 cGxldGUgZnVuY3Rpb24gd2lsbCBnZXQgcmlkIG9mIHRoZSB0aGF0IHdlcmUgaW50ZXJydXB0ZWQg
 aW4gdGhlDQotICogbm9ybWFsIG1hbm5lci4NCi0gKg0KLSAqIFRoaXMgZnVuY3Rpb24gbmVlZHMg
 dG8gcnVuIGF0IHNwbGNhbSgpLCBhcyBpdCBpbnRlcmFjdHMgd2l0aCB0aGUgc3VibWl0dGVkDQot
 ICogcXVldWUsIGFzIHdlbGwgYXMgdGhlIGNvbXBsZXRlZCBhbmQgZnJlZSBxdWV1ZXMuICBKdXN0
 IGxpa2UgZHB0X2ludHIoKSBkb2VzLg0KLSAqIFRvIHJ1biBpdCBhdCBhbnkgSVNQTCBvdGhlciB0
 aGFuIHRoYXQgb2YgZHB0X2ludHIoKSwgd2lsbCBtZWFuIHRoYXQgZHB0X2ludHINCi0gKiB3aWxs
 YmUgYWJsZSB0byBwcmUtZW1wdCBpdCwgZ3JhYiBhIHRyYW5zYWN0aW9uIGluIHByb2dyZXNzICh0
 b3dhcmRzDQotICogZGVzdHJ1Y3Rpb24pIGFuZCBvcGVyYXRlIG9uIGl0LiAgVGhlIHN0YXRlIG9m
 IHRoaXMgdHJhbnNhY3Rpb24gd2lsbCBiZSBub3QNCi0gKiB2ZXJ5IGNsZWFyLg0KLSAqIFRoZSBv
 bmx5IG90aGVyIG9wdGlvbiwgaXMgdG8gbG9jayBpdCBvbmx5IGFzIGxvbmcgYXMgbmVjZXNzYXJ5
 IGJ1dCBoYXZlDQotICogZHB0X2ludHIoKSBzcGluLXdhaXQgb24gaXQuIEluIGEgVVAgZW52aXJv
 bm1lbnQgdGhpcyBtYWtlcyBubyBzZW5zZSBhbmQgaW4NCi0gKiBhIFNNUCBlbnZpcm9ubWVudCwg
 dGhlIGFkdmFudGFnZSBpcyBkdWJ2aW91cyBmb3IgYSBmdW5jdGlvbiB0aGF0IHJ1bnMgb25jZQ0K
 LSAqIGV2ZXJ5IHRlbiBzZWNvbmRzIGZvciBmZXcgbWljcm9zZWNvbmRzIGFuZCwgb24gc3lzdGVt
 cyB3aXRoIGhlYWx0aHkNCi0gKiBoYXJkd2FyZSwgZG9lcyBub3QgZG8gYW55dGhpbmcgYW55d2F5
 Lg0KLSAqLw0KLQ0KLXN0YXRpYyB2b2lkDQotZHB0X2hhbmRsZV90aW1lb3V0cyhkcHRfc29mdGNf
 dCAqIGRwdCkNCi17DQotCWRwdF9jY2JfdCAgICAgICpjY2I7DQotDQotCWlmIChkcHQtPnN0YXRl
 ICYgRFBUX0hBX1RJTUVPVVRTX0FDVElWRSkgew0KLQkJZGV2aWNlX3ByaW50ZihkcHQtPmRldiwg
 IldBUk5JTkc6IFRpbWVvdXQgSGFuZGxpbmcgQ29sbGlzaW9uXG4iKTsNCi0JCXJldHVybjsNCi0J
 fQ0KLQlkcHQtPnN0YXRlIHw9IERQVF9IQV9USU1FT1VUU19BQ1RJVkU7DQotDQotCS8qIExvb3Ag
 dGhyb3VnaCB0aGUgZW50aXJlIHN1Ym1pdHRlZCBxdWV1ZSwgbG9va2luZyBmb3IgbG9zdCBzb3Vs
 cyAqLw0KLQlUQUlMUV9GSVJTVChjY2IsICYmZHB0LT5zdWJtaXR0ZWRfY2NicywgbGlua3MpIHsN
 Ci0JCXN0cnVjdCBzY3NpX3hmZXIgKnhzOw0KLQkJdV9pbnQzMl90ICAgICAgIGFnZSwgbWF4X2Fn
 ZTsNCi0NCi0JCXhzID0gY2NiLT54czsNCi0JCWFnZSA9IGRwdF90aW1lX2RlbHRhKGNjYi0+Y29t
 bWFuZF9zdGFydGVkLCBtaWNyb3RpbWVfbm93KTsNCi0NCi0jZGVmaW5lIFRlblNlYwkxMDAwMDAw
 MA0KLQ0KLQkJaWYgKHhzID09IE5VTEwpIHsJLyogTG9jYWwsIG5vbi1rZXJuZWwgY2FsbCAqLw0K
 LQkJCW1heF9hZ2UgPSBUZW5TZWM7DQotCQl9IGVsc2Ugew0KLQkJCW1heF9hZ2UgPSAoKCh4cy0+
 dGltZW91dCAqIChkcHQtPnN1Ym1pdHRlZF9jY2JzX2NvdW50DQotCQkJCQkJICAgICsgRFBUX1RJ
 TUVPVVRfRkFDVE9SKSkNCi0JCQkJICAgID4gVGVuU2VjKQ0KLQkJCQkgPyAoeHMtPnRpbWVvdXQg
 KiAoZHB0LT5zdWJtaXR0ZWRfY2Nic19jb3VudA0KLQkJCQkJCSAgICsgRFBUX1RJTUVPVVRfRkFD
 VE9SKSkNCi0JCQkJICAgOiBUZW5TZWMpOw0KLQkJfQ0KLQ0KLQkJLyoNCi0JCSAqIElmIGEgdHJh
 bnNhY3Rpb24gaXMgbWFya2VkIGxvc3QgYW5kIGlzIFRXSUNFIGFzIG9sZCBhcyB3ZQ0KLQkJICog
 Y2FyZSwgdGhlbiwgYW5kIG9ubHkgdGhlbiBkbyB3ZSBkZXN0cm95IGl0IQ0KLQkJICovDQotCQlp
 ZiAoY2NiLT5zdGF0ZSAmIERQVF9DQ0JfU1RBVEVfTUFSS0VEX0xPU1QpIHsNCi0JCQkvKiBSZW1l
 bWJlciB3aG8gaXMgbmV4dCAqLw0KLQkJCWlmIChhZ2UgPiAobWF4X2FnZSAqIDIpKSB7DQotCQkJ
 CWRwdF9RcmVtb3ZlX3N1Ym1pdHRlZChkcHQsIGNjYik7DQotCQkJCWNjYi0+c3RhdGUgJj0gfkRQ
 VF9DQ0JfU1RBVEVfTUFSS0VEX0xPU1Q7DQotCQkJCWNjYi0+c3RhdGUgfD0gRFBUX0NDQl9TVEFU
 RV9BQk9SVEVEOw0KLSNkZWZpbmUgY21kX25hbWUgc2NzaV9jbWRfbmFtZShjY2ItPmVhdGFfY2Ni
 LmNwX3Njc2lfY21kKQ0KLQkJCQlpZiAoY2NiLT5yZXRyaWVzKysgPiBEUFRfUkVUUklFUykgew0K
 LQkJCQkJZGV2aWNlX3ByaW50ZihkcHQtPmRldiwNCi0JCQkJCSAgICAgICAiRVJST1I6IERlc3Ry
 b3lpbmcgc3RhbGUgIg0KLQkJCQkJICAgICAgICIlZCAoJXMpXG4iDQotCQkJCQkgICAgICAgIgkJ
 b24gIg0KLQkJCQkJICAgICAgICJjJWRiJWR0JWR1JWQgKCVkLyVkKVxuIiwNCi0JCQkJCSAgICAg
 ICBjY2ItPnRyYW5zYWN0aW9uX2lkLA0KLQkJCQkJICAgICAgIGNtZF9uYW1lLA0KLQkJCQkJICAg
 ICAgIGRldmljZV9nZXRfdW5pdChkcHQtPmRldiksDQotCQkJCQkgICAgICAgY2NiLT5lYXRhX2Nj
 Yi5jcF9jaGFubmVsLA0KLQkJCQkJICAgICAgIGNjYi0+ZWF0YV9jY2IuY3BfaWQsDQotCQkJCQkg
 ICAgICAgY2NiLT5lYXRhX2NjYi5jcF9MVU4sIGFnZSwNCi0JCQkJCSAgICAgICBjY2ItPnJldHJp
 ZXMpOw0KLSNkZWZpbmUgc2VuZF9jY2IgJmNjYi0+ZWF0YV9jY2INCi0jZGVmaW5lIEVTQQkgRUFU
 QV9TUEVDSUZJQ19BQk9SVA0KLQkJCQkJKHZvaWQpIGRwdF9zZW5kX2ltbWVkaWF0ZShkcHQsDQot
 CQkJCQkJCQkgIHNlbmRfY2NiLA0KLQkJCQkJCQkJICBFU0EsDQotCQkJCQkJCQkgIDAsIDApOw0K
 LQkJCQkJZHB0X1FwdXNoX2ZyZWUoZHB0LCBjY2IpOw0KLQ0KLQkJCQkJLyogVGhlIFNDU0kgbGF5
 ZXIgc2hvdWxkIHJlLXRyeSAqLw0KLQkJCQkJeHMtPmVycm9yIHw9IFhTX1RJTUVPVVQ7DQotCQkJ
 CQl4cy0+ZmxhZ3MgfD0gU0NTSV9JVFNET05FOw0KLQkJCQkJc2NzaV9kb25lKHhzKTsNCi0JCQkJ
 fSBlbHNlIHsNCi0JCQkJCWRldmljZV9wcmludGYoZHB0LT5kZXYsDQotCQkJCQkgICAgICAgIkVS
 Uk9SOiBTdGFsZSAlZCAoJXMpIG9uICINCi0JCQkJCSAgICAgICAiYyVkYiVkdCVkdSVkICglZClc
 biINCi0JCQkJCSAgICAgIgkJZ2V0cyBhbm90aGVyICINCi0JCQkJCSAgICAgICAiY2hhbmNlKCVk
 LyVkKVxuIiwNCi0JCQkJCSAgICAgICBjY2ItPnRyYW5zYWN0aW9uX2lkLA0KLQkJCQkJICAgICAg
 IGNtZF9uYW1lLA0KLQkJCQkJICAgICAgIGRldmljZV9nZXRfdW5pdChkcHQtPmRldiksDQotCQkJ
 CQkgICAgICAgY2NiLT5lYXRhX2NjYi5jcF9jaGFubmVsLA0KLQkJCQkJICAgICAgIGNjYi0+ZWF0
 YV9jY2IuY3BfaWQsDQotCQkJCQkgICAgICAgY2NiLT5lYXRhX2NjYi5jcF9MVU4sDQotCQkJCQkg
 ICAgYWdlLCBjY2ItPnJldHJpZXMsIERQVF9SRVRSSUVTKTsNCi0NCi0JCQkJCWRwdF9RcHVzaF93
 YWl0aW5nKGRwdCwgY2NiKTsNCi0JCQkJCWRwdF9zY2hlZF9xdWV1ZShkcHQpOw0KLQkJCQl9DQot
 CQkJfQ0KLQkJfSBlbHNlIHsNCi0JCQkvKg0KLQkJCSAqIFRoaXMgaXMgYSB0cmFuc2FjdGlvbiB0
 aGF0IGlzIG5vdCB0byBiZSBkZXN0cm95ZWQNCi0JCQkgKiAoeWV0KSBCdXQgaXQgaXMgdG9vIG9s
 ZCBmb3Igb3VyIGxpa2luZy4gV2Ugd2FpdCBhcw0KLQkJCSAqIGxvbmcgYXMgdGhlIHVwcGVyIGxh
 eWVyIHRoaW5rcy4gTm90IHJlYWxseSwgd2UNCi0JCQkgKiBtdWx0aXBseSB0aGF0IGJ5IHRoZSBu
 dW1iZXIgb2YgY29tbWFuZHMgaW4gdGhlDQotCQkJICogc3VibWl0dGVkIHF1ZXVlICsgMS4NCi0J
 CQkgKi8NCi0JCQlpZiAoIShjY2ItPnN0YXRlICYgRFBUX0NDQl9TVEFURV9NQVJLRURfTE9TVCkg
 JiYNCi0JCQkgICAgKGFnZSAhPSB+MCkgJiYgKGFnZSA+IG1heF9hZ2UpKSB7DQotCQkJCWRldmlj
 ZV9wcmludGYoZHB0LT5kZXYsDQotCQkJCSAgICAgICAiRVJST1I6IE1hcmtpbmcgJWQgKCVzKSBv
 biAiDQotCQkJCSAgICAgICAiYyVkYiVkdCVkdSVkIFxuIg0KLQkJCQkgICAgICAgIiAgICAgICAg
 ICAgIGFzIGxhdGUgYWZ0ZXIgJWR1c2VjXG4iLA0KLQkJCQkgICAgICAgY2NiLT50cmFuc2FjdGlv
 bl9pZCwNCi0JCQkJICAgICAgIGNtZF9uYW1lLA0KLQkJCQkgICAgICAgZGV2aWNlX2dldF91bml0
 KGRwdC0+ZGV2KSwNCi0JCQkJICAgICAgIGNjYi0+ZWF0YV9jY2IuY3BfY2hhbm5lbCwNCi0JCQkJ
 ICAgICAgIGNjYi0+ZWF0YV9jY2IuY3BfaWQsDQotCQkJCSAgICAgICBjY2ItPmVhdGFfY2NiLmNw
 X0xVTiwgYWdlKTsNCi0JCQkJY2NiLT5zdGF0ZSB8PSBEUFRfQ0NCX1NUQVRFX01BUktFRF9MT1NU
 Ow0KLQkJCX0NCi0JCX0NCi0JfQ0KLQ0KLQlkcHQtPnN0YXRlICY9IH5EUFRfSEFfVElNRU9VVFNf
 QUNUSVZFOw0KLX0NCi0NCi1zdGF0aWMgdm9pZA0KLWRwdF90aW1lb3V0KHZvaWQgKmFyZykNCi17
 DQotCWRwdF9zb2Z0Y190ICAgICpkcHQgPSAoZHB0X3NvZnRjX3QgKikgYXJnOw0KLQ0KLQltdHhf
 YXNzZXJ0KCZkcHQtPmxvY2ssIE1BX09XTkVEKTsNCi0JaWYgKCEoZHB0LT5zdGF0ZSAmIERQVF9I
 QV9USU1FT1VUU19BQ1RJVkUpKQ0KLQkJZHB0X2hhbmRsZV90aW1lb3V0cyhkcHQpOw0KLQ0KLQlj
 YWxsb3V0X3Jlc2V0KCZkcHQtPnRpbWVyLCBoeiAqIDEwLCBkcHRfdGltZW91dCwgZHB0KTsNCi19
 DQotDQotI2VuZGlmCQkJCS8qIERQVF9IQU5ETEVfVElNRU9VVFMgKi8NCi0NCiAjZW5kaWYNCl==
 
 
 --=-djHxNd34EOkbkEVteM/S--
 
 --=-TtB46BOqDEW7zUEpuqRD
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.13 (FreeBSD)
 
 iQEcBAABAgAGBQJRZHAwAAoJEBkJRdwI6BaHXngH/3VDTUVGzNBX/bslKo534MBu
 /+9AmBXuXwOzjeOnFvIrnV2mrrujFC8thB+0TZSU98VdPQUfrbVjNY+qo3lyonbh
 MPeh8Jy7wfQyOIQ3RnGoivK6l/JgRAJb6bTHGzj3laaP+w34jZ9eGWQfgBIuPWAf
 sjkM4y5b/s3+ZDogA04HVxEfkx8NYmlRIchlwCCuqXUP3cqNxdvVAHod5ErD6UK8
 Lu6ar2Qr04HkHVMqR1XRwsR7SUGx9R3QpPOt++ux++p2hARbpRjXkYS8hnB9VcAv
 3MF24UrI7wcx2bzvmIEERzbUDOTVKfyZVNLZy5w5aNMrOf4fLIS2kC53Rt7HYZM=
 =W1NJ
 -----END PGP SIGNATURE-----
 
 --=-TtB46BOqDEW7zUEpuqRD--
 
Responsible-Changed-From-To: freebsd-scsi->sbruno 
Responsible-Changed-By: sbruno 
Responsible-Changed-When: Tue Apr 9 19:51:26 UTC 2013 
Responsible-Changed-Why:  
I'll take this for now.  Even if all we do is nuke this driver's option 
from the system. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44587 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/44587: commit references a PR
Date: Wed, 10 Apr 2013 23:20:18 +0000 (UTC)

 Author: sbruno
 Date: Wed Apr 10 23:20:09 2013
 New Revision: 249348
 URL: http://svnweb.freebsd.org/changeset/base/249348
 
 Log:
   options DPT_HANDLE_TIMEOUTS hasn't worked since dpt(4) was converted to CAM
   somewhere around svn r39402 to r39234.
   
   I don't know of anyone who really wants to test these changes, but they
   only remove the deprecated code in question.  This shreds the driver down a
   bit and *removes* options from the kernel configs.
   
   These don't appear to be referenced in the man page, so no need to check it
   there.
   
   PR:		kern/44587
   Obtained from:	Yahoo! Inc.
   MFC after:	2 weeks
 
 Modified:
   head/sys/conf/NOTES
   head/sys/conf/options
   head/sys/dev/dpt/dpt.h
   head/sys/dev/dpt/dpt_scsi.c
 
 Modified: head/sys/conf/NOTES
 ==============================================================================
 --- head/sys/conf/NOTES	Wed Apr 10 22:12:21 2013	(r249347)
 +++ head/sys/conf/NOTES	Wed Apr 10 23:20:09 2013	(r249348)
 @@ -1623,20 +1623,10 @@ options 	ISP_DEFAULT_ROLES=0
  # Compaq are actually DPT controllers.
  #
  # See src/sys/dev/dpt for debugging and other subtle options.
 -#   DPT_MEASURE_PERFORMANCE Enables a set of (semi)invasive metrics. Various
 +#  DPT_MEASURE_PERFORMANCE  Enables a set of (semi)invasive metrics. Various
  #                           instruments are enabled.  The tools in
  #                           /usr/sbin/dpt_* assume these to be enabled.
 -#   DPT_HANDLE_TIMEOUTS     Normally device timeouts are handled by the DPT.
 -#                           If you want the driver to handle timeouts, enable
 -#                           this option.  If your system is very busy, this
 -#                           option will create more trouble than solve.
 -#   DPT_TIMEOUT_FACTOR      Used to compute the excessive amount of time to
 -#                           wait when timing out with the above option.
  #  DPT_DEBUG_xxxx           These are controllable from sys/dev/dpt/dpt.h
 -#  DPT_LOST_IRQ             When enabled, will try, once per second, to catch
 -#                           any interrupt that got lost.  Seems to help in some
 -#                           DPT-firmware/Motherboard combinations.  Minimal
 -#                           cost, great benefit.
  #  DPT_RESET_HBA            Make "reset" actually reset the controller
  #                           instead of fudging it.  Only enable this if you
  #			    are 100% certain you need it.
 @@ -1645,9 +1635,6 @@ device		dpt
  
  # DPT options
  #!CAM# options 	DPT_MEASURE_PERFORMANCE
 -#!CAM# options 	DPT_HANDLE_TIMEOUTS
 -options 	DPT_TIMEOUT_FACTOR=4
 -options 	DPT_LOST_IRQ
  options 	DPT_RESET_HBA
  
  #
 
 Modified: head/sys/conf/options
 ==============================================================================
 --- head/sys/conf/options	Wed Apr 10 22:12:21 2013	(r249347)
 +++ head/sys/conf/options	Wed Apr 10 23:20:09 2013	(r249348)
 @@ -534,9 +534,6 @@ NATM
  
  # DPT driver debug flags
  DPT_MEASURE_PERFORMANCE	opt_dpt.h
 -DPT_HANDLE_TIMEOUTS	opt_dpt.h
 -DPT_TIMEOUT_FACTOR	opt_dpt.h
 -DPT_LOST_IRQ		opt_dpt.h
  DPT_RESET_HBA		opt_dpt.h
  
  # Misc debug flags.  Most of these should probably be replaced with
 
 Modified: head/sys/dev/dpt/dpt.h
 ==============================================================================
 --- head/sys/dev/dpt/dpt.h	Wed Apr 10 22:12:21 2013	(r249347)
 +++ head/sys/dev/dpt/dpt.h	Wed Apr 10 23:20:09 2013	(r249348)
 @@ -1110,16 +1110,6 @@ typedef struct dpt_softc {
  #define DPT_HA_COMMAND_ACTIVE  	0x00000080
  #define DPT_HA_QUIET            0x00000100
  
 -#ifdef DPT_LOST_IRQ
 -#define DPT_LOST_IRQ_SET	0x10000000
 -#define DPT_LOST_IRQ_ACTIVE	0x20000000
 -#endif
 -	
 -#ifdef DPT_HANDLE_TIMEOUTS
 -#define DPT_HA_TIMEOUTS_SET	0x40000000
 -#define DPT_HA_TIMEOUTS_ACTIVE	0x80000000
 -#endif
 -
  	u_int8_t  primary;	/* true if primary */	
  
  	u_int8_t  more_support		:1,	/* HBA supports MORE flag */
 
 Modified: head/sys/dev/dpt/dpt_scsi.c
 ==============================================================================
 --- head/sys/dev/dpt/dpt_scsi.c	Wed Apr 10 22:12:21 2013	(r249347)
 +++ head/sys/dev/dpt/dpt_scsi.c	Wed Apr 10 23:20:09 2013	(r249348)
 @@ -1632,9 +1632,6 @@ dpt_intr_locked(dpt_softc_t *dpt)
  			       "clear EOC.\n     Marking as LOST.\n",
  			       dccb->transaction_id);
  
 -#ifdef DPT_HANDLE_TIMEOUTS
 -			dccb->state |= DPT_CCB_STATE_MARKED_LOST;
 -#endif
  			/* This CLEARS the interrupt! */
  			status = dpt_inb(dpt, HA_RSTATUS);
  			continue;
 @@ -2524,154 +2521,4 @@ dpt_user_cmd_done(dpt_softc_t * dpt, int
  	return;
  }
  
 -#ifdef DPT_HANDLE_TIMEOUTS
 -/**
 - * This function walks down the SUBMITTED queue.
 - * Every request that is too old gets aborted and marked.
 - * Since the DPT will complete (interrupt) immediately (what does that mean?),
 - * We just walk the list, aborting old commands and marking them as such.
 - * The dpt_complete function will get rid of the that were interrupted in the
 - * normal manner.
 - *
 - * This function needs to run at splcam(), as it interacts with the submitted
 - * queue, as well as the completed and free queues.  Just like dpt_intr() does.
 - * To run it at any ISPL other than that of dpt_intr(), will mean that dpt_intr
 - * willbe able to pre-empt it, grab a transaction in progress (towards
 - * destruction) and operate on it.  The state of this transaction will be not
 - * very clear.
 - * The only other option, is to lock it only as long as necessary but have
 - * dpt_intr() spin-wait on it. In a UP environment this makes no sense and in
 - * a SMP environment, the advantage is dubvious for a function that runs once
 - * every ten seconds for few microseconds and, on systems with healthy
 - * hardware, does not do anything anyway.
 - */
 -
 -static void
 -dpt_handle_timeouts(dpt_softc_t * dpt)
 -{
 -	dpt_ccb_t      *ccb;
 -
 -	if (dpt->state & DPT_HA_TIMEOUTS_ACTIVE) {
 -		device_printf(dpt->dev, "WARNING: Timeout Handling Collision\n");
 -		return;
 -	}
 -	dpt->state |= DPT_HA_TIMEOUTS_ACTIVE;
 -
 -	/* Loop through the entire submitted queue, looking for lost souls */
 -	TAILQ_FIRST(ccb, &&dpt->submitted_ccbs, links) {
 -		struct scsi_xfer *xs;
 -		u_int32_t       age, max_age;
 -
 -		xs = ccb->xs;
 -		age = dpt_time_delta(ccb->command_started, microtime_now);
 -
 -#define TenSec	10000000
 -
 -		if (xs == NULL) {	/* Local, non-kernel call */
 -			max_age = TenSec;
 -		} else {
 -			max_age = (((xs->timeout * (dpt->submitted_ccbs_count
 -						    + DPT_TIMEOUT_FACTOR))
 -				    > TenSec)
 -				 ? (xs->timeout * (dpt->submitted_ccbs_count
 -						   + DPT_TIMEOUT_FACTOR))
 -				   : TenSec);
 -		}
 -
 -		/*
 -		 * If a transaction is marked lost and is TWICE as old as we
 -		 * care, then, and only then do we destroy it!
 -		 */
 -		if (ccb->state & DPT_CCB_STATE_MARKED_LOST) {
 -			/* Remember who is next */
 -			if (age > (max_age * 2)) {
 -				dpt_Qremove_submitted(dpt, ccb);
 -				ccb->state &= ~DPT_CCB_STATE_MARKED_LOST;
 -				ccb->state |= DPT_CCB_STATE_ABORTED;
 -#define cmd_name scsi_cmd_name(ccb->eata_ccb.cp_scsi_cmd)
 -				if (ccb->retries++ > DPT_RETRIES) {
 -					device_printf(dpt->dev,
 -					       "ERROR: Destroying stale "
 -					       "%d (%s)\n"
 -					       "		on "
 -					       "c%db%dt%du%d (%d/%d)\n",
 -					       ccb->transaction_id,
 -					       cmd_name,
 -					       device_get_unit(dpt->dev),
 -					       ccb->eata_ccb.cp_channel,
 -					       ccb->eata_ccb.cp_id,
 -					       ccb->eata_ccb.cp_LUN, age,
 -					       ccb->retries);
 -#define send_ccb &ccb->eata_ccb
 -#define ESA	 EATA_SPECIFIC_ABORT
 -					(void) dpt_send_immediate(dpt,
 -								  send_ccb,
 -								  ESA,
 -								  0, 0);
 -					dpt_Qpush_free(dpt, ccb);
 -
 -					/* The SCSI layer should re-try */
 -					xs->error |= XS_TIMEOUT;
 -					xs->flags |= SCSI_ITSDONE;
 -					scsi_done(xs);
 -				} else {
 -					device_printf(dpt->dev,
 -					       "ERROR: Stale %d (%s) on "
 -					       "c%db%dt%du%d (%d)\n"
 -					     "		gets another "
 -					       "chance(%d/%d)\n",
 -					       ccb->transaction_id,
 -					       cmd_name,
 -					       device_get_unit(dpt->dev),
 -					       ccb->eata_ccb.cp_channel,
 -					       ccb->eata_ccb.cp_id,
 -					       ccb->eata_ccb.cp_LUN,
 -					    age, ccb->retries, DPT_RETRIES);
 -
 -					dpt_Qpush_waiting(dpt, ccb);
 -					dpt_sched_queue(dpt);
 -				}
 -			}
 -		} else {
 -			/*
 -			 * This is a transaction that is not to be destroyed
 -			 * (yet) But it is too old for our liking. We wait as
 -			 * long as the upper layer thinks. Not really, we
 -			 * multiply that by the number of commands in the
 -			 * submitted queue + 1.
 -			 */
 -			if (!(ccb->state & DPT_CCB_STATE_MARKED_LOST) &&
 -			    (age != ~0) && (age > max_age)) {
 -				device_printf(dpt->dev,
 -				       "ERROR: Marking %d (%s) on "
 -				       "c%db%dt%du%d \n"
 -				       "            as late after %dusec\n",
 -				       ccb->transaction_id,
 -				       cmd_name,
 -				       device_get_unit(dpt->dev),
 -				       ccb->eata_ccb.cp_channel,
 -				       ccb->eata_ccb.cp_id,
 -				       ccb->eata_ccb.cp_LUN, age);
 -				ccb->state |= DPT_CCB_STATE_MARKED_LOST;
 -			}
 -		}
 -	}
 -
 -	dpt->state &= ~DPT_HA_TIMEOUTS_ACTIVE;
 -}
 -
 -static void
 -dpt_timeout(void *arg)
 -{
 -	dpt_softc_t    *dpt = (dpt_softc_t *) arg;
 -
 -	mtx_assert(&dpt->lock, MA_OWNED);
 -	if (!(dpt->state & DPT_HA_TIMEOUTS_ACTIVE))
 -		dpt_handle_timeouts(dpt);
 -
 -	callout_reset(&dpt->timer, hz * 10, dpt_timeout, dpt);
 -}
 -
 -#endif				/* DPT_HANDLE_TIMEOUTS */
 -
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: sbruno 
State-Changed-When: Wed Apr 10 23:38:51 UTC 2013 
State-Changed-Why:  
I consider this bug closed now as the code in question has been removed from 
the driver.  This code hasn't worked for 12 years, but I will accept patches 
to make it work again if its still needed, somewhere ...  

http://www.freebsd.org/cgi/query-pr.cgi?pr=44587 
>Unformatted:
